Page MenuHomePhorge

[Python 3] wallace - modules change / relative imports
ClosedPublic

Authored by ghane on Jun 14 2022, 4:57 PM.
Tags
None
Referenced Files
F12339030: D3626.id.diff
Sat, May 25, 10:31 AM
Unknown Object (File)
Fri, May 24, 6:43 PM
Unknown Object (File)
Fri, May 24, 11:32 AM
Unknown Object (File)
Sun, May 19, 4:13 AM
Unknown Object (File)
Sun, May 19, 2:21 AM
Unknown Object (File)
Sat, May 18, 10:19 PM
Unknown Object (File)
Tue, May 14, 10:28 PM
Unknown Object (File)
Wed, May 8, 3:01 AM
Subscribers

Details

Summary

some modules changed
and there are also some relative imports fixes (dynamic imports)

Diff Detail

Repository
rP pykolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ghane requested review of this revision.Jun 14 2022, 4:57 PM
ghane created this revision.
sicherha subscribed.
sicherha added inline comments.
wallace/module_gpgencrypt.py
32

email.mime.base.MIMEBase and email.mime.text.MIMEText are both available in Python 2.7 - we can drop the try and consistently use the new module names.

This revision now requires changes to proceed.Jun 15 2022, 11:46 PM
ghane marked an inline comment as done.

dropped old imports in try..except lesser than 2.7
try...except removed

This revision is now accepted and ready to land.Jun 16 2022, 11:33 PM

Turns out the changes in wallace/__init__.py and wallace/modules.py have already landed on master - see commits 63532e93 and c2b69efb. Could you drop them from this diff and keep only the changes to wallace/module_gpgencrypt.py?

This revision now requires changes to proceed.Jun 16 2022, 11:46 PM
This revision is now accepted and ready to land.Jun 17 2022, 10:06 PM
This revision was automatically updated to reflect the committed changes.