Paths

Table of Contentst

[Python 3] test-wallace changed modules
ClosedPublic
Actions

Authored by ghane on Jun 14 2022, 7:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 21, 4:54 PM

	Unknown Object (File)
	Sun, Apr 21, 4:54 PM

	Unknown Object (File)
	Sun, Apr 21, 4:54 PM

	Unknown Object (File)
	Sun, Apr 21, 4:54 PM

	Unknown Object (File)
	Wed, Apr 17, 9:27 AM

	Unknown Object (File)
	Sun, Apr 14, 2:21 PM

	Unknown Object (File)
	Sat, Apr 13, 6:30 AM

	Unknown Object (File)
	Sat, Mar 30, 5:48 AM

View All 71 Files

Subscribers

sicherha

Details

Reviewers

sicherha

Group Reviewers

PyKolab Developers

Commits

rP727d3ae9fc3f: [Python 3] test-wallace changed modules

Summary

modulenames or their structure changed

Diff Detail

Repository

rP pykolab

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

ghane requested review of this revision.Jun 14 2022, 7:43 PM

ghane created this revision.

ghane added a parent revision: D3626: [Python 3] wallace - modules change / relative imports.

sicherha requested changes to this revision.Jun 15 2022, 11:52 PM

sicherha subscribed.

sicherha added inline comments.

test-wallace.py
35–39	All these modules are available in Python 2.7. Drop the `try`-block and use only the `import`s from the `except`-block. Also, I think `Encoders` isn't used anywhere in this file, so we can probably drop that line.

This revision now requires changes to proceed.Jun 15 2022, 11:52 PM

try...except
and old or unused imports
removed as explained

sicherha accepted this revision.Jun 16 2022, 11:33 PM

This revision is now accepted and ready to land.Jun 16 2022, 11:33 PM

Closed by commit rP727d3ae9fc3f: [Python 3] test-wallace changed modules (authored by sicherha). · Explain WhyJun 16 2022, 11:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

test-wallace.py

17 lines

Diff 10412

View Options

[Python 3] test-wallace changed modulesClosedPublicActions