Details

src/app/Policy/Greylist/Request.php
113	I would say if there is no recipient set $enabled = false so we bail out after capturing the sender statistics? @vanmeeuwen Should we capture sender statistics if the recipient is not found,? should we greylist if the recipient is not found?
src/database/migrations/2021_08_25_120000_drop_greylist_settings_table.php
28	I suppose in principle we have to (we'd be running code expecting the table).

Looks good to me. We should probably also create a policycontrollertest, to test if this actually works, but that doesn't need to be in this diff.

In D2815#33931, @mollekopf wrote:

Looks good to me. We should probably also create a policycontrollertest, to test if this actually works, but that doesn't need to be in this diff.

There are some controller tests in tests/Feature/Stories, but I agree not enough of the controller alone.

mollekopf accepted this revision.Aug 27 2021, 9:20 AM

This revision is now accepted and ready to land.Aug 27 2021, 9:20 AM

Closed by commit rKa53ecb760738: Fix greylisting setting (authored by machniak). · Explain WhyAug 27 2021, 9:23 AM

This revision was automatically updated to reflect the committed changes.

		Path
M		src/app/Http/Controllers/API/V4/PolicyController.php (2 lines)
M		src/app/IP4Net.php (20 lines)
M		src/app/IP6Net.php (20 lines)
M		src/app/Policy/Greylist/Request.php (78 lines)
D	M	src/app/Policy/Greylist/Setting.php (17 lines)
M		src/app/Traits/UserConfigTrait.php (6 lines)
M		src/app/Utils.php (22 lines)
A	M	src/database/migrations/2021_08_25_120000_drop_greylist_settings_table.php (43 lines)
M		src/resources/vue/Admin/User.vue (6 lines)
M		src/resources/vue/User/Info.vue (6 lines)
M		src/tests/Browser/Reseller/UserTest.php (10 lines)
M		src/tests/Feature/Controller/UsersTest.php (10 lines)
M		src/tests/Feature/Stories/GreylistTest.php (209 lines)
M		src/tests/Feature/UserTest.php (21 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8056	4bccbc9		Aug 25 2021, 12:28 PM	★	★
Diff 2	8062	4bccbc9	- Small perf. improvement, skip redundant query	Aug 25 2021, 1:26 PM	★	★
Diff 3	8068	4bccbc9	- Performance optimizations	Aug 25 2021, 3:09 PM	★	★
Diff 4	8080	4bccbc9	- Move greylisting setting back to user_settings, cleanup	Aug 25 2021, 4:47 PM	★	★
Diff 5	8086	4bccbc9	- Remove redundant ->limit(1)	Aug 25 2021, 4:55 PM	★	★
Diff 6	8137	d72eac6	rKa53ecb76073897a4d84dc645594beb224b9919a4	Aug 27 2021, 9:22 AM	★	★

Fix greylisting setting
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 8137

src/app/Http/Controllers/API/V4/PolicyController.php

src/app/IP4Net.php

src/app/IP6Net.php

src/app/Policy/Greylist/Request.php

src/app/Policy/Greylist/Setting.php

src/app/Traits/UserConfigTrait.php

src/app/Utils.php

src/database/migrations/2021_08_25_120000_drop_greylist_settings_table.php

src/resources/vue/Admin/User.vue

src/resources/vue/User/Info.vue

src/tests/Browser/Reseller/UserTest.php

src/tests/Feature/Controller/UsersTest.php

src/tests/Feature/Stories/GreylistTest.php

src/tests/Feature/UserTest.php

Fix greylisting settingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8137

src/app/Http/Controllers/API/V4/PolicyController.php

src/app/IP4Net.php

src/app/IP6Net.php

src/app/Policy/Greylist/Request.php

src/app/Policy/Greylist/Setting.php

src/app/Traits/UserConfigTrait.php

src/app/Utils.php

src/database/migrations/2021_08_25_120000_drop_greylist_settings_table.php

src/resources/vue/Admin/User.vue

src/resources/vue/User/Info.vue

src/tests/Browser/Reseller/UserTest.php

src/tests/Feature/Controller/UsersTest.php

src/tests/Feature/Stories/GreylistTest.php

src/tests/Feature/UserTest.php

Fix greylisting setting
ClosedPublic
Actions

Revision Contents
Changeset List