./phpunit
Details
Details
- Reviewers
mollekopf - Group Reviewers
Restricted Project - Commits
- rKa53ecb760738: Fix greylisting setting
Diff Detail
Diff Detail
- Repository
- rK kolab
- Branch
- dev/greylist-tests
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 36385 Build 14401: arc lint + arc unit
Event Timeline
| src/app/Policy/Greylist/Request.php | ||
|---|---|---|
| 150 | I would say if there is no recipient set $enabled = false so we bail out after capturing the sender statistics? @vanmeeuwen Should we capture sender statistics if the recipient is not found,? should we greylist if the recipient is not found? | |
| src/database/migrations/2021_08_25_120000_drop_greylist_settings_table.php | ||
| 27 ↗ | (On Diff #8086) | I suppose in principle we have to (we'd be running code expecting the table). |
Comment Actions
Looks good to me. We should probably also create a policycontrollertest, to test if this actually works, but that doesn't need to be in this diff.
Comment Actions
There are some controller tests in tests/Feature/Stories, but I agree not enough of the controller alone.