Page MenuHomePhorge

Fix greylisting setting
ClosedPublic

Authored by machniak on Aug 25 2021, 12:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 4:33 AM
Unknown Object (File)
Sun, Apr 7, 6:45 AM
Unknown Object (File)
Thu, Apr 4, 8:14 PM
Unknown Object (File)
Thu, Mar 28, 1:10 PM
Unknown Object (File)
Thu, Mar 28, 11:49 AM
Unknown Object (File)
Mar 7 2024, 5:24 AM
Unknown Object (File)
Mar 7 2024, 1:21 AM
Unknown Object (File)
Jan 31 2024, 3:27 PM
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rKa53ecb760738: Fix greylisting setting
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/greylist-tests
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 36397
Build 14413: arc lint + arc unit

Event Timeline

machniak created this revision.
  • Small perf. improvement, skip redundant query
  • Performance optimizations
  • Move greylisting setting back to user_settings, cleanup
  • Remove redundant ->limit(1)
mollekopf added inline comments.
src/app/Policy/Greylist/Request.php
150

I would say if there is no recipient set $enabled = false so we bail out after capturing the sender statistics?

@vanmeeuwen Should we capture sender statistics if the recipient is not found,? should we greylist if the recipient is not found?

src/database/migrations/2021_08_25_120000_drop_greylist_settings_table.php
27 ↗(On Diff #8086)

I suppose in principle we have to (we'd be running code expecting the table).

Looks good to me. We should probably also create a policycontrollertest, to test if this actually works, but that doesn't need to be in this diff.

Looks good to me. We should probably also create a policycontrollertest, to test if this actually works, but that doesn't need to be in this diff.

There are some controller tests in tests/Feature/Stories, but I agree not enough of the controller alone.

This revision is now accepted and ready to land.Aug 27 2021, 9:20 AM
This revision was automatically updated to reflect the committed changes.