Paths

Table of Contentst

Differential D1702

Better structure for console commands, and unification of code/behavior
AbandonedPublic
Actions

Authored by vanmeeuwen on Oct 5 2020, 9:45 AM.

Project Tags

None

Referenced Files

	F117745864: D1702.1775172200.diff
	Wed, Apr 1, 11:23 PM

	F117738980: D1702.1775157110.diff
	Wed, Apr 1, 7:11 PM

Subscribers

Restricted Project

Details

Reviewers

Group Reviewers

Restricted Project

Summary

Merge branch 'master' into arcpatch-D1684

Standardize downloading a file

Demonstrate command restructuring with magic

Test Plan

./phpunit (tests not updated)

Diff Detail

Repository

Branch

arcpatch-D1702

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 31693
Build 12043: arc lint + arc unit

Event Timeline

vanmeeuwen requested review of this revision.Oct 5 2020, 9:45 AM

vanmeeuwen created this revision.

Harbormaster completed remote builds in B31120: Diff 4522.Oct 5 2020, 9:45 AM

Further reduce duplication

Harbormaster completed remote builds in B31123: Diff 4528.Oct 5 2020, 9:53 AM

show-case implementation of 'relations'

Harbormaster completed remote builds in B31129: Diff 4534.Oct 5 2020, 11:32 AM

Commentary and documentation
user:wallets translation to the new system
More magic

Harbormaster completed remote builds in B31135: Diff 4540.Oct 5 2020, 4:23 PM

And... another iteration to experiment with.

Harbormaster completed remote builds in B31141: Diff 4546.Oct 5 2020, 5:05 PM

Some create object logic

Harbormaster completed remote builds in B31171: Diff 4576.Oct 6 2020, 10:48 AM

vanmeeuwen mentioned this in D1684: Better structure for console commands, and unification of code/behavior.Nov 9 2020, 1:14 PM

Rebase on master

Some preliminary export commands
Add wallet:balances command
Merge branch 'master' into arcpatch-D1702
Move some commands to a scalpel namespace, add generic ObjectUpdateCommand

Harbormaster completed remote builds in B31690: Diff 5008.Nov 9 2020, 1:14 PM

Move some more commands around

Harbormaster completed remote builds in B31693: Diff 5014.Nov 9 2020, 1:50 PM

machniak requested changes to this revision.Dec 23 2020, 10:35 AM

machniak subscribed.

machniak added inline comments.

src/app/Console/ObjectCreateCommand.php
76	This is redundant. `create()` method already returns the object on success.
src/app/Console/ObjectListCommand.php
42	You miss command prefix here.
src/app/Console/ObjectRelationListCommand.php
118	I think instead of ->each() you can use foreach for all above types and array. Also, `\Illuminate\Database\Eloquent\Relations\Relation` does not implement each() method itself, so I guess the check is not right. I'm not sure but mabe we could use `is_countable()` here as replacement for these three IFs.
src/app/Console/ObjectUpdateCommand.php
93	Should we have an error printed here?
src/app/Domain.php
435	I think $this->error() in here is not correct. Also the `TODO` above.

This revision now requires changes to proceed.Dec 23 2020, 10:35 AM

I think this was already landed in some form.

Large Diff

This large diff affects 161 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

src/

app/

Console/

lines

Commands/

	DB/

	PingCommand.php
	DBPing.php

lines

Data/

Export/

BalanceCommand.php

lines

lines

	ExportCommand.php
	ImportCommand.php

lines

ImportCommand.php

lines

DiscountList.php

DiscountsCommand.php

lines

	Domain/

	Add.php
	DomainAdd.php

lines

	Delete.php
	DomainDelete.php

lines

	ListDomains.php
	DomainList.php

lines

	SetStatus.php
	DomainSetStatus.php

lines

	SetWallet.php
	DomainSetWallet.php

lines

	Status.php
	DomainStatus.php

lines

	Suspend.php
	DomainSuspend.php

lines

	Unsuspend.php
	DomainUnsuspend.php

lines

Domain/

UsersCommand.php

lines

DomainDelete.php

DomainListUsers.php

DomainSetStatus.php

DomainSetWallet.php

DomainStatus.php

DomainSuspend.php

DomainUnsuspend.php

DomainsCommand.php

lines

EntitlementsCommand.php

lines

Job/

DomainCreate.php

lines

DomainUpdate.php

lines

lines

lines

WalletCheck.php

lines

lines

Package/

SkusCommand.php

lines

PackageSkus.php

PackagesCommand.php

lines

PlanPackages.php

lines

PlansCommand.php

lines

Scalpel/

Discount/

CreateCommand.php

lines

ReadCommand.php

lines

Domain/

CreateCommand.php

lines

ReadCommand.php

lines

UpdateCommand.php

lines

Entitlement/

CreateCommand.php

lines

ReadCommand.php

lines

UpdateCommand.php

lines

Package/

ReadCommand.php

lines

Plan/

ReadCommand.php

lines

Sku/

ReadCommand.php

lines

Transaction/

ReadCommand.php

lines

User/

CreateCommand.php

lines

ReadCommand.php

lines

UserSetting/

ReadCommand.php

lines

Wallet/

ReadCommand.php

lines

WalletSetting/

ReadCommand.php

lines

lines

TransactionsCommand.php

lines

	User/

	AddAlias.php
	UserAddAlias.php

lines

	Delete.php
	UserDelete.php

lines

	Discount.php
	UserDiscount.php

lines

	ForceDelete.php
	UserForceDelete.php

lines

	Status.php
	UserStatus.php

lines

	Suspend.php
	UserSuspend.php

lines

	Unsuspend.php
	UserUnsuspend.php

lines

	Verify.php
	UserVerify.php

lines

User/

AliasesCommand.php

lines

DomainsCommand.php

lines

EntitlementsCommand.php

lines

WalletCommand.php

lines

WalletsCommand.php

lines

UserAddAlias.php

UserDiscount.php

UserDomains.php

UserEntitlements.php

UserForceDelete.php

UserSettingsCommand.php

lines

UserSuspend.php

UserUnsuspend.php

UserWallets.php

UsersCommand.php

lines

	Wallet/

	AddTransaction.php
	WalletAddTransaction.php

lines

	Balances.php
	WalletBalances.php

lines

	Charge.php
	WalletCharge.php

lines

	Expected.php
	WalletExpected.php

lines

	GetBalance.php
	WalletGetBalance.php

lines

	GetDiscount.php
	WalletGetDiscount.php

lines

	Mandate.php
	WalletMandate.php

lines

	SetBalance.php
	WalletSetBalance.php

lines

	SetDiscount.php
	WalletSetDiscount.php

lines

	Transactions.php
	WalletTransactions.php

lines

	Until.php
	WalletUntil.php

lines

Wallet/

ControllersCommand.php

lines

EntitlementsCommand.php

lines

OwnerCommand.php

lines

WalletAddTransaction.php

WalletBalances.php

WalletCharge.php

WalletDiscount.php

WalletExpected.php

WalletGetBalance.php

WalletGetDiscount.php

WalletMandate.php

WalletSetBalance.php

WalletSetDiscount.php

WalletSettingsCommand.php

lines

WalletTransactions.php

WalletUntil.php

WalletsCommand.php

lines

Development/

DomainStatus.php

ObjectCreateCommand.php

lines

ObjectListCommand.php

lines

ObjectReadCommand.php

lines

ObjectRelationListCommand.php

lines

ObjectUpdateCommand.php

lines

lines

lines

database/

seeds/

local/

lines

tests/

Feature/

Console/

	Domain/

	AddTest.php
	UserDiscountTest.php

lines

	DeleteTest.php
	UserDiscountTest.php

lines

	ListUsersTest.php
	UserDiscountTest.php

lines

	SetStatusTest.php
	UserDiscountTest.php

lines

	SetWalletTest.php
	UserDiscountTest.php

lines

	SuspendTest.php
	UserDiscountTest.php

lines

	UnsuspendTest.php
	UserDiscountTest.php

lines

Domain/

ListDomainsTest.php

lines

lines

	User/

	AddAliasTest.php
	UserDiscountTest.php

lines

	DeleteTest.php
	WalletDiscountTest.php

lines

	DiscountTest.php
	UserDiscountTest.php

lines

	DomainsTest.php
	UserDomainsTest.php

lines

	EntitlementsTest.php
	UserEntitlementsTest.php

lines

	ForceDeleteTest.php
	UserForceDeleteTest.php

lines

	SuspendTest.php
	UserDiscountTest.php

lines

	UnsuspendTest.php
	UserDiscountTest.php

lines

	VerifyTest.php
	UserDiscountTest.php

lines

	WalletsTest.php
	UserWalletsTest.php

lines

User/

lines

UserDiscountTest.php

UserDomainsTest.php

UserEntitlementsTest.php

UserForceDeleteTest.php

UserWalletsTest.php

Wallet/

AddTransactionTest.php

lines

BalancesTest.php

lines

ExpectedTest.php

lines

GetBalanceTest.php

lines

GetDiscountTest.php

lines

SetBalanceTest.php

lines

SetDiscountTest.php

lines

TransactionsTest.php

lines

lines

	Wallet/

	ChargeTest.php
	WalletChargeTest.php

lines

	MandateTest.php
	UserDiscountTest.php

lines

WalletChargeTest.php

WalletDiscountTest.php

Diff 5014

src/app/Console/Command.php

src/app/Console/Commands/DB/PingCommand.php

src/app/Console/Commands/DBPing.php

src/app/Console/Commands/Data/Export/BalanceCommand.php

src/app/Console/Commands/Data/Export/VATCommand.php

src/app/Console/Commands/Data/ExportCommand.php

src/app/Console/Commands/Data/ImportCommand.php

src/app/Console/Commands/DiscountList.php

src/app/Console/Commands/DiscountsCommand.php

src/app/Console/Commands/Domain/Add.php

src/app/Console/Commands/Domain/Delete.php

src/app/Console/Commands/Domain/ListDomains.php

src/app/Console/Commands/Domain/SetStatus.php

src/app/Console/Commands/Domain/SetWallet.php

src/app/Console/Commands/Domain/Status.php

src/app/Console/Commands/Domain/Suspend.php

src/app/Console/Commands/Domain/Unsuspend.php

src/app/Console/Commands/Domain/UsersCommand.php

src/app/Console/Commands/DomainAdd.php

src/app/Console/Commands/DomainDelete.php

src/app/Console/Commands/DomainList.php

src/app/Console/Commands/DomainListUsers.php

src/app/Console/Commands/DomainSetStatus.php

src/app/Console/Commands/DomainSetWallet.php

src/app/Console/Commands/DomainStatus.php

src/app/Console/Commands/DomainSuspend.php

src/app/Console/Commands/DomainUnsuspend.php

src/app/Console/Commands/DomainsCommand.php

src/app/Console/Commands/EntitlementsCommand.php

src/app/Console/Commands/Job/DomainCreate.php

src/app/Console/Commands/Job/DomainUpdate.php

src/app/Console/Commands/Job/UserCreate.php

src/app/Console/Commands/Job/UserUpdate.php

src/app/Console/Commands/Job/WalletCheck.php

src/app/Console/Commands/MollieInfo.php

src/app/Console/Commands/Package/SkusCommand.php

src/app/Console/Commands/PackageSkus.php

src/app/Console/Commands/PackagesCommand.php

src/app/Console/Commands/PlanPackages.php

src/app/Console/Commands/PlansCommand.php

src/app/Console/Commands/Scalpel/Discount/CreateCommand.php

src/app/Console/Commands/Scalpel/Discount/ReadCommand.php

src/app/Console/Commands/Scalpel/Domain/CreateCommand.php

src/app/Console/Commands/Scalpel/Domain/ReadCommand.php

src/app/Console/Commands/Scalpel/Domain/UpdateCommand.php

src/app/Console/Commands/Scalpel/Entitlement/CreateCommand.php

src/app/Console/Commands/Scalpel/Entitlement/ReadCommand.php

src/app/Console/Commands/Scalpel/Entitlement/UpdateCommand.php

src/app/Console/Commands/Scalpel/Package/ReadCommand.php

src/app/Console/Commands/Scalpel/Plan/ReadCommand.php

src/app/Console/Commands/Scalpel/Sku/ReadCommand.php

src/app/Console/Commands/Scalpel/Transaction/ReadCommand.php

src/app/Console/Commands/Scalpel/User/CreateCommand.php

src/app/Console/Commands/Scalpel/User/ReadCommand.php

src/app/Console/Commands/Scalpel/UserSetting/ReadCommand.php

src/app/Console/Commands/Scalpel/Wallet/ReadCommand.php

src/app/Console/Commands/Scalpel/WalletSetting/ReadCommand.php

src/app/Console/Commands/StripeInfo.php

src/app/Console/Commands/TransactionsCommand.php

src/app/Console/Commands/User/AddAlias.php

src/app/Console/Commands/User/AliasesCommand.php

src/app/Console/Commands/User/Delete.php

src/app/Console/Commands/User/Discount.php

src/app/Console/Commands/User/DomainsCommand.php

src/app/Console/Commands/User/EntitlementsCommand.php

src/app/Console/Commands/User/ForceDelete.php

src/app/Console/Commands/User/Status.php

src/app/Console/Commands/User/Suspend.php

src/app/Console/Commands/User/Unsuspend.php

src/app/Console/Commands/User/Verify.php

src/app/Console/Commands/User/WalletCommand.php

src/app/Console/Commands/User/WalletsCommand.php

src/app/Console/Commands/UserAddAlias.php

src/app/Console/Commands/UserDelete.php

src/app/Console/Commands/UserDiscount.php

src/app/Console/Commands/UserDomains.php

src/app/Console/Commands/UserEntitlements.php

src/app/Console/Commands/UserForceDelete.php

src/app/Console/Commands/UserSettingsCommand.php

src/app/Console/Commands/UserStatus.php

src/app/Console/Commands/UserSuspend.php

src/app/Console/Commands/UserUnsuspend.php

src/app/Console/Commands/UserVerify.php

src/app/Console/Commands/UserWallets.php

src/app/Console/Commands/UsersCommand.php

src/app/Console/Commands/Wallet/AddTransaction.php

src/app/Console/Commands/Wallet/Balances.php

src/app/Console/Commands/Wallet/Charge.php

src/app/Console/Commands/Wallet/ControllersCommand.php

src/app/Console/Commands/Wallet/EntitlementsCommand.php

src/app/Console/Commands/Wallet/Expected.php

src/app/Console/Commands/Wallet/GetBalance.php

src/app/Console/Commands/Wallet/GetDiscount.php

src/app/Console/Commands/Wallet/Mandate.php

src/app/Console/Commands/Wallet/OwnerCommand.php

src/app/Console/Commands/Wallet/SetBalance.php

src/app/Console/Commands/Wallet/SetDiscount.php

src/app/Console/Commands/Wallet/Transactions.php

src/app/Console/Commands/Wallet/Until.php

src/app/Console/Commands/WalletAddTransaction.php

src/app/Console/Commands/WalletBalances.php

src/app/Console/Commands/WalletCharge.php

src/app/Console/Commands/WalletDiscount.php

src/app/Console/Commands/WalletExpected.php

src/app/Console/Commands/WalletGetBalance.php

src/app/Console/Commands/WalletGetDiscount.php

src/app/Console/Commands/WalletMandate.php

src/app/Console/Commands/WalletSetBalance.php

src/app/Console/Commands/WalletSetDiscount.php

src/app/Console/Commands/WalletSettingsCommand.php

src/app/Console/Commands/WalletTransactions.php

src/app/Console/Commands/WalletUntil.php

src/app/Console/Commands/WalletsCommand.php

src/app/Console/Development/DomainStatus.php

src/app/Console/Development/UserStatus.php

src/app/Console/ObjectCreateCommand.php

Loading...

src/app/Console/ObjectListCommand.php

Loading...

src/app/Console/ObjectReadCommand.php

src/app/Console/ObjectRelationListCommand.php

Loading...

src/app/Console/ObjectUpdateCommand.php

Loading...

src/app/Domain.php

Loading...

src/app/User.php

src/database/seeds/local/UserSeeder.php

src/tests/Feature/Console/Domain/AddTest.php

src/tests/Feature/Console/Domain/DeleteTest.php

src/tests/Feature/Console/Domain/ListDomainsTest.php

src/tests/Feature/Console/Domain/ListUsersTest.php

src/tests/Feature/Console/Domain/SetStatusTest.php

src/tests/Feature/Console/Domain/SetWalletTest.php

src/tests/Feature/Console/Domain/StatusTest.php

src/tests/Feature/Console/Domain/SuspendTest.php

src/tests/Feature/Console/Domain/UnsuspendTest.php

src/tests/Feature/Console/User/AddAliasTest.php

src/tests/Feature/Console/User/DeleteTest.php

src/tests/Feature/Console/User/DiscountTest.php

src/tests/Feature/Console/User/DomainsTest.php

src/tests/Feature/Console/User/EntitlementsTest.php

src/tests/Feature/Console/User/ForceDeleteTest.php

src/tests/Feature/Console/User/StatusTest.php

src/tests/Feature/Console/User/SuspendTest.php

src/tests/Feature/Console/User/UnsuspendTest.php

src/tests/Feature/Console/User/VerifyTest.php

src/tests/Feature/Console/User/WalletsTest.php

src/tests/Feature/Console/UserDiscountTest.php

src/tests/Feature/Console/UserDomainsTest.php

src/tests/Feature/Console/UserEntitlementsTest.php

src/tests/Feature/Console/UserForceDeleteTest.php

src/tests/Feature/Console/UserWalletsTest.php

src/tests/Feature/Console/Wallet/AddTransactionTest.php

src/tests/Feature/Console/Wallet/BalancesTest.php

src/tests/Feature/Console/Wallet/ChargeTest.php

src/tests/Feature/Console/Wallet/ExpectedTest.php

src/tests/Feature/Console/Wallet/GetBalanceTest.php

src/tests/Feature/Console/Wallet/GetDiscountTest.php

src/tests/Feature/Console/Wallet/MandateTest.php

src/tests/Feature/Console/Wallet/SetBalanceTest.php

src/tests/Feature/Console/Wallet/SetDiscountTest.php

src/tests/Feature/Console/Wallet/TransactionsTest.php

src/tests/Feature/Console/Wallet/UntilTest.php

src/tests/Feature/Console/WalletChargeTest.php

src/tests/Feature/Console/WalletDiscountTest.php