Paths

Table of Contentst

Differential D1702

Better structure for console commands, and unification of code/behavior
AbandonedPublic
Actions

Authored by vanmeeuwen on Oct 5 2020, 11:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 12, 9:31 AM

	Unknown Object (File)
	Mon, Apr 8, 3:58 AM

	Unknown Object (File)
	Mon, Apr 8, 3:27 AM

	Unknown Object (File)
	Mon, Apr 8, 2:28 AM

	Unknown Object (File)
	Wed, Apr 3, 3:12 AM

	Unknown Object (File)
	Wed, Apr 3, 2:45 AM

	Unknown Object (File)
	Fri, Mar 29, 6:21 PM

	Unknown Object (File)
	Fri, Mar 29, 2:01 PM

View All 89 Files

Subscribers

Restricted Project

Details

Reviewers

Group Reviewers

Restricted Project

Summary

Merge branch 'master' into arcpatch-D1684

Standardize downloading a file

Demonstrate command restructuring with magic

Test Plan

./phpunit (tests not updated)

Diff Detail

Repository

Branch

arcpatch-D1702

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 31690
Build 12040: arc lint + arc unit

Event Timeline

vanmeeuwen requested review of this revision.Oct 5 2020, 11:45 AM

vanmeeuwen created this revision.

Harbormaster completed remote builds in B31120: Diff 4522.Oct 5 2020, 11:45 AM

Further reduce duplication

Harbormaster completed remote builds in B31123: Diff 4528.Oct 5 2020, 11:53 AM

show-case implementation of 'relations'

Harbormaster completed remote builds in B31129: Diff 4534.Oct 5 2020, 1:32 PM

Commentary and documentation
user:wallets translation to the new system
More magic

Harbormaster completed remote builds in B31135: Diff 4540.Oct 5 2020, 6:23 PM

And... another iteration to experiment with.

Harbormaster completed remote builds in B31141: Diff 4546.Oct 5 2020, 7:05 PM

Some create object logic

Harbormaster completed remote builds in B31171: Diff 4576.Oct 6 2020, 12:48 PM

vanmeeuwen mentioned this in D1684: Better structure for console commands, and unification of code/behavior.Nov 9 2020, 2:14 PM

Rebase on master

Some preliminary export commands
Add wallet:balances command
Merge branch 'master' into arcpatch-D1702
Move some commands to a scalpel namespace, add generic ObjectUpdateCommand

Harbormaster completed remote builds in B31690: Diff 5008.Nov 9 2020, 2:14 PM

Move some more commands around

Harbormaster completed remote builds in B31693: Diff 5014.Nov 9 2020, 2:50 PM

machniak requested changes to this revision.Dec 23 2020, 11:35 AM

machniak subscribed.

machniak added inline comments.

src/app/Console/ObjectCreateCommand.php
77	This is redundant. `create()` method already returns the object on success.
src/app/Console/ObjectListCommand.php
43	You miss command prefix here.
src/app/Console/ObjectRelationListCommand.php
119	I think instead of ->each() you can use foreach for all above types and array. Also, `\Illuminate\Database\Eloquent\Relations\Relation` does not implement each() method itself, so I guess the check is not right. I'm not sure but mabe we could use `is_countable()` here as replacement for these three IFs.
src/app/Console/ObjectUpdateCommand.php
94	Should we have an error printed here?
src/app/Domain.php
435	I think $this->error() in here is not correct. Also the `TODO` above.

This revision now requires changes to proceed.Dec 23 2020, 11:35 AM

I think this was already landed in some form.

Large Diff

This large diff affects 161 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

src/

app/

Console/

12 lines

Commands/

	DB/

	PingCommand.php
	DBPing.php

16 lines

Data/

Export/

BalanceCommand.php

55 lines

59 lines

	ExportCommand.php
	ImportCommand.php

23 lines

ImportCommand.php

4 lines

Discount/

CreateCommand.php

12 lines

ReadCommand.php

12 lines

DiscountList.php

DiscountsCommand.php

12 lines

	Domain/

	Add.php
	DomainAdd.php

6 lines

	Delete.php
	DomainDelete.php

19 lines

	ListDomains.php
	DomainList.php

16 lines

	SetStatus.php
	DomainSetStatus.php

9 lines

	SetWallet.php
	DomainSetWallet.php

8 lines

	Status.php
	DomainStatus.php

25 lines

	Suspend.php
	DomainSuspend.php

21 lines

	Unsuspend.php
	DomainUnsuspend.php

21 lines

Domain/

UsersCommand.php

13 lines

DomainDelete.php

DomainListUsers.php

DomainSetStatus.php

DomainSetWallet.php

DomainStatus.php

DomainSuspend.php

DomainUnsuspend.php

DomainsCommand.php

12 lines

EntitlementsCommand.php

12 lines

Job/

DomainCreate.php

6 lines

DomainUpdate.php

6 lines

6 lines

6 lines

WalletCheck.php

3 lines

8 lines

Package/

ReadCommand.php

12 lines

SkusCommand.php

45 lines

PackageSkus.php

PackagesCommand.php

12 lines

Plan/

ReadCommand.php

12 lines

PlanPackages.php

12 lines

PlansCommand.php

12 lines

Scalpel/

Domain/

CreateCommand.php

13 lines

ReadCommand.php

13 lines

UpdateCommand.php

13 lines

Entitlement/

CreateCommand.php

56 lines

ReadCommand.php

13 lines

UpdateCommand.php

13 lines

Sku/

ReadCommand.php

12 lines

7 lines

Transaction/

ReadCommand.php

12 lines

TransactionsCommand.php

12 lines

	User/

	AddAlias.php
	UserAddAlias.php

19 lines

	Delete.php
	UserDelete.php

19 lines

	Discount.php
	UserDiscount.php

22 lines

	ForceDelete.php
	UserForceDelete.php

17 lines

	Status.php
	UserStatus.php

21 lines

	Suspend.php
	UserSuspend.php

21 lines

	Unsuspend.php
	UserUnsuspend.php

21 lines

	Verify.php
	UserVerify.php

21 lines

User/

AliasesCommand.php

13 lines

CreateCommand.php

12 lines

DomainsCommand.php

13 lines

EntitlementsCommand.php

13 lines

ReadCommand.php

12 lines

WalletCommand.php

13 lines

WalletsCommand.php

13 lines

UserAddAlias.php

UserDiscount.php

UserDomains.php

UserEntitlements.php

UserForceDelete.php

UserSetting/

ReadCommand.php

12 lines

UserSettingsCommand.php

12 lines

UserSuspend.php

UserUnsuspend.php

UserWallets.php

UsersCommand.php

12 lines

	Wallet/

	AddTransaction.php
	WalletAddTransaction.php

17 lines

	Balances.php
	WalletBalances.php

16 lines

	Charge.php
	WalletCharge.php

17 lines

	Expected.php
	WalletExpected.php

20 lines

	GetBalance.php
	WalletGetBalance.php

17 lines

	GetDiscount.php
	WalletGetDiscount.php

17 lines

	Mandate.php
	WalletMandate.php

17 lines

	SetBalance.php
	WalletSetBalance.php

17 lines

	SetDiscount.php
	WalletSetDiscount.php

20 lines

	Transactions.php
	WalletTransactions.php

19 lines

	Until.php
	WalletUntil.php

17 lines

Wallet/

ControllersCommand.php

13 lines

EntitlementsCommand.php

13 lines

OwnerCommand.php

13 lines

ReadCommand.php

12 lines

WalletAddTransaction.php

WalletBalances.php

WalletCharge.php

WalletDiscount.php

WalletExpected.php

WalletGetBalance.php

WalletGetDiscount.php

WalletMandate.php

WalletSetBalance.php

WalletSetDiscount.php

WalletSetting/

ReadCommand.php

12 lines

WalletSettingsCommand.php

12 lines

WalletTransactions.php

WalletUntil.php

WalletsCommand.php

12 lines

Development/

DomainStatus.php

ObjectCreateCommand.php

86 lines

ObjectListCommand.php

75 lines

ObjectReadCommand.php

58 lines

ObjectRelationListCommand.php

125 lines

ObjectUpdateCommand.php

106 lines

208 lines

2 lines

database/

seeds/

local/

2 lines

tests/

Feature/

Console/

	Domain/

	AddTest.php
	UserDiscountTest.php

7 lines

	DeleteTest.php
	UserDiscountTest.php

7 lines

	ListUsersTest.php
	UserDiscountTest.php

7 lines

	SetStatusTest.php
	UserDiscountTest.php

7 lines

	SetWalletTest.php
	UserDiscountTest.php

7 lines

	SuspendTest.php
	UserDiscountTest.php

7 lines

	UnsuspendTest.php
	UserDiscountTest.php

7 lines

Domain/

ListDomainsTest.php

19 lines

19 lines

	User/

	AddAliasTest.php
	UserDiscountTest.php

7 lines

	DeleteTest.php
	WalletDiscountTest.php

7 lines

	DiscountTest.php
	UserDiscountTest.php

7 lines

	DomainsTest.php
	UserDomainsTest.php

7 lines

	EntitlementsTest.php
	UserEntitlementsTest.php

7 lines

	ForceDeleteTest.php
	UserForceDeleteTest.php

4 lines

	SuspendTest.php
	UserDiscountTest.php

7 lines

	UnsuspendTest.php
	UserDiscountTest.php

7 lines

	VerifyTest.php
	UserDiscountTest.php

7 lines

	WalletsTest.php
	UserWalletsTest.php

7 lines

User/

19 lines

UserDiscountTest.php

UserDomainsTest.php

UserEntitlementsTest.php

UserForceDeleteTest.php

UserWalletsTest.php

Wallet/

AddTransactionTest.php

16 lines

BalancesTest.php

19 lines

ExpectedTest.php

19 lines

GetBalanceTest.php

16 lines

GetDiscountTest.php

16 lines

SetBalanceTest.php

16 lines

SetDiscountTest.php

16 lines

TransactionsTest.php

16 lines

48 lines

	Wallet/

	ChargeTest.php
	WalletChargeTest.php

4 lines

	MandateTest.php
	UserDiscountTest.php

7 lines

WalletChargeTest.php

WalletDiscountTest.php

Diff 5008

src/app/Console/Command.php

src/app/Console/Commands/DB/PingCommand.php

src/app/Console/Commands/DBPing.php

src/app/Console/Commands/Data/Export/BalanceCommand.php

src/app/Console/Commands/Data/Export/VATCommand.php

src/app/Console/Commands/Data/ExportCommand.php

src/app/Console/Commands/Data/ImportCommand.php

src/app/Console/Commands/Discount/CreateCommand.php

src/app/Console/Commands/Discount/ReadCommand.php

src/app/Console/Commands/DiscountList.php

src/app/Console/Commands/DiscountsCommand.php

src/app/Console/Commands/Domain/Add.php

src/app/Console/Commands/Domain/Delete.php

src/app/Console/Commands/Domain/ListDomains.php

src/app/Console/Commands/Domain/SetStatus.php

src/app/Console/Commands/Domain/SetWallet.php

src/app/Console/Commands/Domain/Status.php

src/app/Console/Commands/Domain/Suspend.php

src/app/Console/Commands/Domain/Unsuspend.php

src/app/Console/Commands/Domain/UsersCommand.php

src/app/Console/Commands/DomainAdd.php

src/app/Console/Commands/DomainDelete.php

src/app/Console/Commands/DomainList.php

src/app/Console/Commands/DomainListUsers.php

src/app/Console/Commands/DomainSetStatus.php

src/app/Console/Commands/DomainSetWallet.php

src/app/Console/Commands/DomainStatus.php

src/app/Console/Commands/DomainSuspend.php

src/app/Console/Commands/DomainUnsuspend.php

src/app/Console/Commands/DomainsCommand.php

src/app/Console/Commands/EntitlementsCommand.php

src/app/Console/Commands/Job/DomainCreate.php

src/app/Console/Commands/Job/DomainUpdate.php

src/app/Console/Commands/Job/UserCreate.php

src/app/Console/Commands/Job/UserUpdate.php

src/app/Console/Commands/Job/WalletCheck.php

src/app/Console/Commands/MollieInfo.php

src/app/Console/Commands/Package/ReadCommand.php

src/app/Console/Commands/Package/SkusCommand.php

src/app/Console/Commands/PackageSkus.php

src/app/Console/Commands/PackagesCommand.php

src/app/Console/Commands/Plan/ReadCommand.php

src/app/Console/Commands/PlanPackages.php

src/app/Console/Commands/PlansCommand.php

src/app/Console/Commands/Scalpel/Domain/CreateCommand.php

src/app/Console/Commands/Scalpel/Domain/ReadCommand.php

src/app/Console/Commands/Scalpel/Domain/UpdateCommand.php

src/app/Console/Commands/Scalpel/Entitlement/CreateCommand.php

src/app/Console/Commands/Scalpel/Entitlement/ReadCommand.php

src/app/Console/Commands/Scalpel/Entitlement/UpdateCommand.php

src/app/Console/Commands/Sku/ReadCommand.php

src/app/Console/Commands/StripeInfo.php

src/app/Console/Commands/Transaction/ReadCommand.php

src/app/Console/Commands/TransactionsCommand.php

src/app/Console/Commands/User/AddAlias.php

src/app/Console/Commands/User/AliasesCommand.php

src/app/Console/Commands/User/CreateCommand.php

src/app/Console/Commands/User/Delete.php

src/app/Console/Commands/User/Discount.php

src/app/Console/Commands/User/DomainsCommand.php

src/app/Console/Commands/User/EntitlementsCommand.php

src/app/Console/Commands/User/ForceDelete.php

src/app/Console/Commands/User/ReadCommand.php

src/app/Console/Commands/User/Status.php

src/app/Console/Commands/User/Suspend.php

src/app/Console/Commands/User/Unsuspend.php

src/app/Console/Commands/User/Verify.php

src/app/Console/Commands/User/WalletCommand.php

src/app/Console/Commands/User/WalletsCommand.php

src/app/Console/Commands/UserAddAlias.php

src/app/Console/Commands/UserDelete.php

src/app/Console/Commands/UserDiscount.php

src/app/Console/Commands/UserDomains.php

src/app/Console/Commands/UserEntitlements.php

src/app/Console/Commands/UserForceDelete.php

src/app/Console/Commands/UserSetting/ReadCommand.php

src/app/Console/Commands/UserSettingsCommand.php

src/app/Console/Commands/UserStatus.php

src/app/Console/Commands/UserSuspend.php

src/app/Console/Commands/UserUnsuspend.php

src/app/Console/Commands/UserVerify.php

src/app/Console/Commands/UserWallets.php

src/app/Console/Commands/UsersCommand.php

src/app/Console/Commands/Wallet/AddTransaction.php

src/app/Console/Commands/Wallet/Balances.php

src/app/Console/Commands/Wallet/Charge.php

src/app/Console/Commands/Wallet/ControllersCommand.php

src/app/Console/Commands/Wallet/EntitlementsCommand.php

src/app/Console/Commands/Wallet/Expected.php

src/app/Console/Commands/Wallet/GetBalance.php

src/app/Console/Commands/Wallet/GetDiscount.php

src/app/Console/Commands/Wallet/Mandate.php

src/app/Console/Commands/Wallet/OwnerCommand.php

src/app/Console/Commands/Wallet/ReadCommand.php

src/app/Console/Commands/Wallet/SetBalance.php

src/app/Console/Commands/Wallet/SetDiscount.php

src/app/Console/Commands/Wallet/Transactions.php

src/app/Console/Commands/Wallet/Until.php

src/app/Console/Commands/WalletAddTransaction.php

src/app/Console/Commands/WalletBalances.php

src/app/Console/Commands/WalletCharge.php

src/app/Console/Commands/WalletDiscount.php

src/app/Console/Commands/WalletExpected.php

src/app/Console/Commands/WalletGetBalance.php

src/app/Console/Commands/WalletGetDiscount.php

src/app/Console/Commands/WalletMandate.php

src/app/Console/Commands/WalletSetBalance.php

src/app/Console/Commands/WalletSetDiscount.php

src/app/Console/Commands/WalletSetting/ReadCommand.php

src/app/Console/Commands/WalletSettingsCommand.php

src/app/Console/Commands/WalletTransactions.php

src/app/Console/Commands/WalletUntil.php

src/app/Console/Commands/WalletsCommand.php

src/app/Console/Development/DomainStatus.php

src/app/Console/Development/UserStatus.php

src/app/Console/ObjectCreateCommand.php

Loading...

src/app/Console/ObjectListCommand.php

Loading...

src/app/Console/ObjectReadCommand.php

src/app/Console/ObjectRelationListCommand.php

Loading...

src/app/Console/ObjectUpdateCommand.php

Loading...

src/app/Domain.php

Loading...

src/app/User.php

src/database/seeds/local/UserSeeder.php

src/tests/Feature/Console/Domain/AddTest.php

src/tests/Feature/Console/Domain/DeleteTest.php

src/tests/Feature/Console/Domain/ListDomainsTest.php

src/tests/Feature/Console/Domain/ListUsersTest.php

src/tests/Feature/Console/Domain/SetStatusTest.php

src/tests/Feature/Console/Domain/SetWalletTest.php

src/tests/Feature/Console/Domain/StatusTest.php

src/tests/Feature/Console/Domain/SuspendTest.php

src/tests/Feature/Console/Domain/UnsuspendTest.php

src/tests/Feature/Console/User/AddAliasTest.php

src/tests/Feature/Console/User/DeleteTest.php

src/tests/Feature/Console/User/DiscountTest.php

src/tests/Feature/Console/User/DomainsTest.php

src/tests/Feature/Console/User/EntitlementsTest.php

src/tests/Feature/Console/User/ForceDeleteTest.php

src/tests/Feature/Console/User/StatusTest.php

src/tests/Feature/Console/User/SuspendTest.php

src/tests/Feature/Console/User/UnsuspendTest.php

src/tests/Feature/Console/User/VerifyTest.php

src/tests/Feature/Console/User/WalletsTest.php

src/tests/Feature/Console/UserDiscountTest.php

src/tests/Feature/Console/UserDomainsTest.php

src/tests/Feature/Console/UserEntitlementsTest.php

src/tests/Feature/Console/UserForceDeleteTest.php

src/tests/Feature/Console/UserWalletsTest.php

src/tests/Feature/Console/Wallet/AddTransactionTest.php

src/tests/Feature/Console/Wallet/BalancesTest.php

src/tests/Feature/Console/Wallet/ChargeTest.php

src/tests/Feature/Console/Wallet/ExpectedTest.php

src/tests/Feature/Console/Wallet/GetBalanceTest.php

src/tests/Feature/Console/Wallet/GetDiscountTest.php

src/tests/Feature/Console/Wallet/MandateTest.php

src/tests/Feature/Console/Wallet/SetBalanceTest.php

src/tests/Feature/Console/Wallet/SetDiscountTest.php

src/tests/Feature/Console/Wallet/TransactionsTest.php

src/tests/Feature/Console/Wallet/UntilTest.php

src/tests/Feature/Console/WalletChargeTest.php

src/tests/Feature/Console/WalletDiscountTest.php