Page MenuHomekolab.org

Better structure for console commands, and unification of code/behavior
Needs ReviewPublic

Authored by machniak on Fri, Oct 2, 1:12 PM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/cli-refactor
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31081
Build 11650: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Fri, Oct 2, 1:12 PM
machniak created this revision.

We're just taking note of some of the restructuring here, largely agreeable, and then I'll counter-propose an approach for review on Monday.

src/app/Console/Commands/Domain/SetStatus.php
35

In any command line, it is important to consider that should some stdout or stderr be rendered, it is accurate to the occasion for which it is rendered.

This should therefore be: Domain {$this->argument('domain')} not found (if that is syntactically valid.