Merge branch 'master' into arcpatch-D1684
Standardize downloading a file
Demonstrate command restructuring with magic
machniak |
Restricted Project |
Merge branch 'master' into arcpatch-D1684
Standardize downloading a file
Demonstrate command restructuring with magic
./phpunit (tests not updated)
No Linters Available |
No Unit Test Coverage |
Buildable 31693 | |
Build 12043: arc lint + arc unit |
Rebase on master
src/app/Console/ObjectCreateCommand.php | ||
---|---|---|
76 | This is redundant. create() method already returns the object on success. | |
src/app/Console/ObjectListCommand.php | ||
42 | You miss command prefix here. | |
src/app/Console/ObjectRelationListCommand.php | ||
118 | I think instead of ->each() you can use foreach for all above types and array. Also, \Illuminate\Database\Eloquent\Relations\Relation does not implement each() method itself, so I guess the check is not right. I'm not sure but mabe we could use is_countable() here as replacement for these three IFs. | |
src/app/Console/ObjectUpdateCommand.php | ||
93 | Should we have an error printed here? | |
src/app/Domain.php | ||
435 | I think $this->error() in here is not correct. Also the TODO above. |
Commit | Tree | Parents | Author | Summary | Date |
---|---|---|---|---|---|
39b4d814f5de | 8c50011bdebe | 7d1f75eaba48 | Jeroen van Meeuwen | Move some more commands around | Nov 9 2020, 2:50 PM |
7d1f75eaba48 | dbb00141e4c7 | ebf632487857 | Jeroen van Meeuwen | Move some commands to a scalpel namespace, add generic ObjectUpdateCommand | Nov 9 2020, 2:12 PM |
ebf632487857 | 9ca3902c1f03 | 5d961d04c8c5 dfbde4d7b827 | Jeroen van Meeuwen | Merge branch 'master' into arcpatch-D1702 | Nov 9 2020, 11:47 AM |
5d961d04c8c5 | 762051a994c9 | c7b5c68561f4 | Jeroen van Meeuwen | Add wallet:balances command | Nov 9 2020, 11:44 AM |
c7b5c68561f4 | 12ee19df8d13 | fcd5dee0fbe7 | Jeroen van Meeuwen | Some preliminary export commands | Oct 6 2020, 5:08 PM |
fcd5dee0fbe7 | 7627d0d0a502 | 7fb26dbf8cc0 | Jeroen van Meeuwen | Better structure for console commands, and unification of code/behavior (Show More…) | Oct 6 2020, 4:35 PM |