Merge remote-tracking branch 'origin/3.8' into 3.x
- origin/3.8: (22 commits) (PUP-1802) Update SHA to puppet_for_the_win (PUP-3429) task_scheduler should use 'day_of_week' instead of 'on' (PUP-2628) Add members to groups instead of full list for Windows (PUP-4291) Add max warnings/errors to issue reporter options (PUP-4151) Add preview_outputdir setting (PUP-4278) Fix grammar error when unless then-part was empty (PUP-4123) Make corrections for comments in review (PUP-4201) Add support for structured logging (maint) Fix missing EOL on last line (PUP-4128) Add infrastructure for migration check of significant WS (PUP-4130) Add infrastructure for migrate check of in-expression (PUP-4127) Add infrastructure for migration check of case type mismatch (PUP-4126) Add infrastrcture for type mismatch in == and != (PUP-4125) Add infrastructure for migration check of UC bare word. (PUP-4123) Make EvaluatingParser skip evaluator cache when migrating (PUP-4124) Add calls to MigrationChecker for empty string == true (PUP-4129) Add infrastrucure to call migration checks for numbers (PUP.4123) Add ability to create a set of Diagnostic (PUP-4123) Add a spec test for MigrationChecker use (PUP-4123) Enable evaluator and checker to pick up a MigrationChecker ...