HomePhorge
Diffusion puppet 5f2b7ed7b24a

(PUP-4123) Make corrections for comments in review
5f2b7ed7b24aUnpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-4123) Make corrections for comments in review

This adds missing docs for added parameter in publc API.
Makes MigrationChecker API private.
Fixes inconsistent use of @migration_checker vs migration_checker.
Fixes use of ||= to assign to uninitialized instance variable.

Details

Provenance
Henrik Lindberg <henrik.lindberg@cloudsmith.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU589e341e7e8e: (maint) Fix missing EOL on last line
Branches
Unknown
Tags
Unknown

Event Timeline

Henrik Lindberg <henrik.lindberg@cloudsmith.com> committed rPU5f2b7ed7b24a: (PUP-4123) Make corrections for comments in review (authored by Henrik Lindberg <henrik.lindberg@cloudsmith.com>).Mar 23 2015, 12:37 PM

Changes (5)

PathSize
lib/
puppet/
pops/
evaluator/
migration/
parser/
validation/

rPU5f2b7ed7b24a

View Options

lib/puppet/pops/evaluator/evaluator_impl.rb

Loading...
View Options

lib/puppet/pops/migration/migration_checker.rb

Loading...
View Options

lib/puppet/pops/parser/evaluating_parser.rb

Loading...
View Options

lib/puppet/pops/validation.rb

Loading...
View Options

lib/puppet/pops/validation/checker4_0.rb

Loading...