Page MenuHomePhorge
Feed All Stories

Jun 4 2025

mollekopf committed rKbdeec760d9ab: phpunit --verbose no longer exists.
Jun 4 2025, 9:35 AM
mollekopf closed D5283: Docker: Enable 'kolab' plugin.
Jun 4 2025, 9:35 AM
mollekopf closed D5289: Make the api for the kolab plugin accessible on a localhost domain.
Jun 4 2025, 9:35 AM
mollekopf committed rK4178fa40e4d2: ci/testctl refresh function.
Jun 4 2025, 9:35 AM
mollekopf committed rK205e3dedcd8c: Docker: Enable the 'kolab' plugin (authored by machniak).
Jun 4 2025, 9:35 AM
mollekopf committed rK3e63d0c451bc: Make the api for the kolab plugin accessible on a localhost domain.
Jun 4 2025, 9:35 AM
machniak accepted D5289: Make the api for the kolab plugin accessible on a localhost domain.
Jun 4 2025, 9:18 AM
machniak committed rK978bfc28527e: Fix test regressions.
Jun 4 2025, 9:17 AM
machniak closed D5286: LDIF import improvements/fixes.
Jun 4 2025, 9:08 AM
machniak committed rKf17ebdd1a737: LDIF import improvements/fixes.
Jun 4 2025, 9:08 AM
machniak closed D5301: Refactor password policy, support LDAP password algos in password history.
Jun 4 2025, 9:07 AM
machniak committed rK07588e20ae4b: Refactor password policy, support LDAP password algos in password history.
Jun 4 2025, 9:07 AM
mollekopf accepted D5301: Refactor password policy, support LDAP password algos in password history.
Jun 4 2025, 8:51 AM
mollekopf accepted D5286: LDIF import improvements/fixes.
Jun 4 2025, 8:47 AM
machniak requested review of D5301: Refactor password policy, support LDAP password algos in password history.
Jun 4 2025, 8:45 AM
mollekopf updated the diff for D5289: Make the api for the kolab plugin accessible on a localhost domain.

check the hostname via middleware to return 404 on non-implemented routes

Jun 4 2025, 8:06 AM
mollekopf updated the diff for D5289: Make the api for the kolab plugin accessible on a localhost domain.

Remove the domain requirement completely instead

Jun 4 2025, 6:58 AM
mollekopf closed D5295: Speed up syncroton_content cleanup queries with an index.
Jun 4 2025, 5:58 AM
mollekopf committed rS730e2907be00: Speed up syncroton_content cleanup queries with an index.
Jun 4 2025, 5:58 AM

Jun 3 2025

machniak updated the diff for D5286: LDIF import improvements/fixes.
  • Small CS fix
Jun 3 2025, 12:56 PM
machniak updated the diff for D5286: LDIF import improvements/fixes.
  • Support delegation in LDIF import
  • Optimize user creation
  • Optimize aliases import
  • Support import of password history
  • Rename migration file
Jun 3 2025, 12:44 PM
machniak accepted D5295: Speed up syncroton_content cleanup queries with an index.

We should do the same in syncroton_folder table

Jun 3 2025, 8:23 AM
mollekopf updated the diff for D5295: Speed up syncroton_content cleanup queries with an index.

Let's try with replacing the index then...

Jun 3 2025, 6:53 AM
machniak added inline comments to D5295: Speed up syncroton_content cleanup queries with an index.
Jun 3 2025, 6:50 AM
machniak requested changes to D5295: Speed up syncroton_content cleanup queries with an index.
Jun 3 2025, 6:48 AM
machniak added a comment to D5295: Speed up syncroton_content cleanup queries with an index.

BTW, we have the same situation in syncroton_folder table. The table is smaller, so it probably is not a problem, but we should use the same index there.

Jun 3 2025, 6:47 AM
mollekopf updated the diff for D5295: Speed up syncroton_content cleanup queries with an index.

Composite key with device_id makes a lot more sense

Jun 3 2025, 6:43 AM
machniak accepted D5295: Speed up syncroton_content cleanup queries with an index.

Seems to work:

MariaDB [roundcube]> ANALYZE SELECT * FROM `syncroton_content` WHERE `device_id` = 'b64bcab5169887ba3318728b5174be9958cf3a00' AND `folder_id` = '75e3e4a5c192280e5d6f62281453edbeb9d8252b' AND `is_deleted` = 1;
+------+-------------+-------------------+------+---------------------------------------------------------------+------+---------+------+-------+----------+----------+------------+-------------+
| id   | select_type | table             | type | possible_keys                                                 | key  | key_len | ref  | rows  | r_rows   | filtered | r_filtered | Extra       |
+------+-------------+-------------------+------+---------------------------------------------------------------+------+---------+------+-------+----------+----------+------------+-------------+
|    1 | SIMPLE      | syncroton_content | ALL  | device_id--folder_id--contentid,syncroton_contents::device_id | NULL | NULL    | NULL | 18487 | 17559.00 |    50.00 |       0.00 | Using where |
+------+-------------+-------------------+------+---------------------------------------------------------------+------+---------+------+-------+----------+----------+------------+-------------+
Jun 3 2025, 5:40 AM

Jun 2 2025

mollekopf added inline comments to D5295: Speed up syncroton_content cleanup queries with an index.
Jun 2 2025, 11:00 PM
mollekopf added a comment to D5298: Syncroton sql table cleanup.

This is just a draft for potential further improvements. Untested, and unclear if actually an improvement.

Jun 2 2025, 11:00 PM
mollekopf requested review of D5298: Syncroton sql table cleanup.
Jun 2 2025, 10:59 PM
mollekopf updated the diff for D5295: Speed up syncroton_content cleanup queries with an index.

Use KEY which is a synonym for INDEX

Jun 2 2025, 10:51 PM
mollekopf added a comment to D5295: Speed up syncroton_content cleanup queries with an index.

Seems to work:

Jun 2 2025, 10:44 PM
mollekopf committed R113:6568aa022035: Support configuring the oauth redirect uri.
Jun 2 2025, 9:18 PM
mollekopf committed R113:875a7ef26fe6: Avoid reparenting special folders..
Jun 2 2025, 9:18 PM
mollekopf committed R113:acad55cb6a7d: Log exceptions to stdout also with the logfmt driver.
Jun 2 2025, 9:18 PM
mollekopf committed R113:e2712d55f95a: logfmt stdout logger.
Jun 2 2025, 9:18 PM
mollekopf committed R113:b2d11880322f: Add a backtrace when an exception is raised so we know where it.
Jun 2 2025, 9:18 PM
mollekopf committed R113:45fdfeee73e6: php8 warning.
Jun 2 2025, 9:18 PM
mollekopf committed R113:32c099ee09a1: per_user_logging for stdout logging.
Jun 2 2025, 9:18 PM
mollekopf committed R113:f422aeda3ab5: php8 compat.
Jun 2 2025, 9:18 PM
mollekopf committed R113:563d80ff7d97: Also print an error on E_COMPILE_ERROR.
Jun 2 2025, 9:18 PM
mollekopf committed R113:6f9e529c1aa8: php8 compat.
Jun 2 2025, 9:18 PM
mollekopf committed R113:b414e60f8d96: Do not log deprecation messages no production systems.
Jun 2 2025, 9:18 PM
mollekopf committed R113:af0bdb3b2660: Don't log an imap authentication error when log_logins=true (authored by machniak).
Jun 2 2025, 9:18 PM
mollekopf committed R113:c23b37dd3a7f: kolab skin updates.
Jun 2 2025, 9:18 PM
mollekopf committed R113:739900c3f1bb: Optimize fetchPartBody() for huge results w/o formatting and decoding (authored by machniak).
Jun 2 2025, 9:18 PM
mollekopf committed R113:2322c1f32a2c: php8 compat.
Jun 2 2025, 9:18 PM
mollekopf committed R113:d4e4f4c478c6: php8 compat.
Jun 2 2025, 9:18 PM
mollekopf committed R113:121ca9793447: Fixed managesieve.js.
Jun 2 2025, 9:18 PM
mollekopf committed R113:c7af3b218cee: Added the kolab skin because the other repo is not publicly available.
Jun 2 2025, 9:18 PM
mollekopf committed R113:7eb97177a4f9: CS fixes, update changelog (authored by machniak).
Jun 2 2025, 9:18 PM
mollekopf committed R113:9905e6b2efb0: Update changelog (authored by machniak).
Jun 2 2025, 9:18 PM
mollekopf committed R113:3f7174a80aef: Add a warning regarding implicit ssl.
Jun 2 2025, 9:18 PM
mollekopf committed R113:5aabfcf44d7d: Use rcube_utils::remote_addr() to take HTTP_X_FORWARDED_FOR into account.
Jun 2 2025, 9:18 PM
mollekopf committed R113:75638b2102ac: Enigma: WOAT Support (#8626).
Jun 2 2025, 9:18 PM
mollekopf committed R113:e8cd8dc30e26: Introduce optional support to inject PROXY protocol headers after.
Jun 2 2025, 9:18 PM
machniak committed R113:2ae7cec1ca70: Makefile: Use npx, we install lessc locally.
Jun 2 2025, 9:18 PM
mollekopf committed R113:b77944ec28d3: Added a composer.json.
Jun 2 2025, 9:18 PM
machniak committed R113:7f836fc7bc81: Update changelog.
Jun 2 2025, 9:18 PM
machniak committed R113:ff8c9ef59c7e: Fix bug where attachments with content type of `application/vnd.ms-tnef` were….
Jun 2 2025, 9:18 PM
GitHub <noreply@github.com> committed R113:0376f69e958a: Validate URL parameter in upload code (#9866) (authored by Pablo Zmdl <57864086+pabzm@users.noreply.github.com>).
Jun 2 2025, 9:18 PM
machniak committed R113:c174c4150a70: - Fix connecting to LDAP using ldapi:// URI (#8990).
Jun 2 2025, 9:18 PM
machniak committed R113:2ad3ba61b285: Fix cursor position on "below the quote" reply in HTML mode (#8700).
Jun 2 2025, 9:18 PM
machniak added a comment to D5295: Speed up syncroton_content cleanup queries with an index.

Did you test whether it indeed does sped up the query?

Jun 2 2025, 6:31 PM
mollekopf added a reviewer for D5295: Speed up syncroton_content cleanup queries with an index: Syncroton Developers.
Jun 2 2025, 3:29 PM
mollekopf added a comment to D5295: Speed up syncroton_content cleanup queries with an index.

This is completely untested, and the syntax may be wrong, so not ready to be merged.

Jun 2 2025, 3:29 PM
mollekopf requested review of D5295: Speed up syncroton_content cleanup queries with an index.
Jun 2 2025, 3:28 PM
mollekopf updated the diff for D5289: Make the api for the kolab plugin accessible on a localhost domain.

I didn't actually plan on removing auth.

Jun 2 2025, 11:16 AM
mollekopf closed D5292: Log if a request fails.
Jun 2 2025, 11:05 AM
mollekopf committed rRPK986a2a2ed63e: Log if a request fails.
Jun 2 2025, 11:05 AM
machniak updated the diff for D5286: LDIF import improvements/fixes.
  • Lowercase kolabAllowSMTPSender value
Jun 2 2025, 10:32 AM
machniak updated the diff for D5286: LDIF import improvements/fixes.
  • Lower-case addresses in shared folders' acl
Jun 2 2025, 10:13 AM
machniak updated the diff for D5286: LDIF import improvements/fixes.
  • Fix domains import
Jun 2 2025, 9:48 AM
machniak updated the diff for D5286: LDIF import improvements/fixes.
  • Prevent an error when a line reminder is null, not a string
  • Prefer displayName over CN for contacts
  • phpstan error fix
Jun 2 2025, 9:14 AM
machniak accepted D5292: Log if a request fails.
Jun 2 2025, 8:19 AM
mollekopf updated the diff for D5292: Log if a request fails.

use raise_error, fixed double $

Jun 2 2025, 8:16 AM
machniak requested changes to D5292: Log if a request fails.
Jun 2 2025, 7:20 AM
mollekopf added a reviewer for D5292: Log if a request fails: Roundcube Kolab Plugins Developers.
Jun 2 2025, 7:11 AM
mollekopf requested review of D5292: Log if a request fails.
Jun 2 2025, 7:10 AM
machniak added a comment to D5289: Make the api for the kolab plugin accessible on a localhost domain.

I don't like it. Services do not require authentication, but this APIs require auth. Especially the delegation write (POST/DELETE) requests.

Jun 2 2025, 6:59 AM
mollekopf added a reviewer for D5289: Make the api for the kolab plugin accessible on a localhost domain: Restricted Project.

I'm not sure if this is all of the api that is required.

Jun 2 2025, 6:50 AM
mollekopf requested review of D5289: Make the api for the kolab plugin accessible on a localhost domain.
Jun 2 2025, 6:49 AM

May 30 2025

mollekopf committed rRPK5b8defefba6b: We need roundcube to work with php 8.0.
May 30 2025, 7:46 PM
mollekopf committed rRPK86a67dca397d: composer.json fixes.
May 30 2025, 7:33 PM
mollekopf committed rKdee5dd29ce81: Support injecting mail to port 25 to test inbound mail.
May 30 2025, 5:14 PM
mollekopf closed D5271: Fold rate-limiting into the submission policy and get mailfilter to work.
May 30 2025, 5:14 PM
mollekopf committed rKd85fd1b53ad8: Fold rate-limiting into the submission policy and get mailfilter to work.
May 30 2025, 5:14 PM
mollekopf committed rK644a7b01df19: Fixed the reject empty sender check.
May 30 2025, 5:14 PM
machniak closed D5280: Move password policy check into the PolicyController.
May 30 2025, 2:09 PM
machniak committed rKb15cbbc2c7d3: Move password policy check into the PolicyController.
May 30 2025, 2:09 PM
machniak requested review of D5286: LDIF import improvements/fixes.
May 30 2025, 1:45 PM
machniak committed rK0b1db847307f: Fix users-per-country chart.
May 30 2025, 10:16 AM
mollekopf accepted D5280: Move password policy check into the PolicyController.
May 30 2025, 9:45 AM
mollekopf updated the diff for D5271: Fold rate-limiting into the submission policy and get mailfilter to work.

Get mailfilter to not block outgoing email.

May 30 2025, 9:16 AM

May 29 2025

machniak requested review of D5283: Docker: Enable 'kolab' plugin.
May 29 2025, 1:15 PM
machniak committed rRPKb931c20dcb60: Add composer.json for the 'kolab' plugin.
May 29 2025, 1:01 PM
machniak requested review of D5280: Move password policy check into the PolicyController.
May 29 2025, 9:46 AM
machniak closed D5277: Lower-case routes.
May 29 2025, 7:43 AM
machniak committed rKdebfe2315f7f: Lower-case routes.
May 29 2025, 7:43 AM