Paths

Table of Contentst

Differential D5292

Log if a request fails
ClosedPublic
Actions

Authored by mollekopf on Jun 2 2025, 7:10 AM.

Project Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Group Reviewers

Roundcube Kolab Plugins Developers

Commits

rRPK986a2a2ed63e: Log if a request fails

Diff Detail

Repository

rRPK roundcubemail-plugins-kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Jun 2 2025, 7:10 AM

mollekopf created this revision.

Harbormaster completed remote builds in B53736: Diff 15210.Jun 2 2025, 7:10 AM

mollekopf added a reviewer: Roundcube Kolab Plugins Developers.Jun 2 2025, 7:11 AM

machniak requested changes to this revision.Jun 2 2025, 7:20 AM

machniak subscribed.

machniak added inline comments.

plugins/kolab/Kolab/Client.php
111	Double $.
120	We should log to 'kolab.log' only in debug mode, and this is redundant to what we do in the middleware above. So, I suppose here we would better use `$rcube->raise_error()`

This revision now requires changes to proceed.Jun 2 2025, 7:20 AM

use raise_error, fixed double $

Harbormaster completed remote builds in B53739: Diff 15213.Jun 2 2025, 8:16 AM

machniak accepted this revision.Jun 2 2025, 8:19 AM

machniak added inline comments.

plugins/kolab/Kolab/Client.php
120	You need 2nd argument set to `true`.

This revision is now accepted and ready to land.Jun 2 2025, 8:19 AM

Closed by commit rRPK986a2a2ed63e: Log if a request fails. · Explain WhyJun 2 2025, 11:05 AM

This revision was automatically updated to reflect the committed changes.

mollekopf added a commit: rRPK986a2a2ed63e: Log if a request fails.

Revision Contents
Changeset List

Path

Size

plugins/

kolab/

Kolab/

lines

Diff 15228

plugins/kolab/Kolab/Client.php

Loading...