Project Tags

None

Referenced Files

None

Subscribers

machniak

Details

Reviewers

machniak

Group Reviewers

Restricted Project

Commits

rK3e63d0c451bc: Make the api for the kolab plugin accessible on a localhost domain

Summary

...by removing the domain requirement for regular api calls.

The requests from the roundcube kolab plugin are not arriving
necessarily via the domain, but are in general handled like other
service requests.

admin./reseller. api calls can still override the others by being
handled first.

Diff Detail

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Jun 2 2025, 6:49 AM

mollekopf created this revision.

Harbormaster completed remote builds in B53733: Diff 15207.Jun 2 2025, 6:49 AM

I'm not sure if this is all of the api that is required.

I don't like it. Services do not require authentication, but this APIs require auth. Especially the delegation write (POST/DELETE) requests.

I didn't actually plan on removing auth.

I think our options are:

Duplicate the api without the domain requirement
Remove the domain requirement for all of the api (but make sure admin. and reseller. still work as expected)

I thought we tried the latter option at some point, but maybe that was just an experiment...

Harbormaster completed remote builds in B53757: Diff 15231.Jun 2 2025, 11:16 AM

Remove the domain requirement completely instead

Harbormaster completed remote builds in B53877: Diff 15261.Jun 4 2025, 6:58 AM

check the hostname via middleware to return 404 on non-implemented routes

Harbormaster completed remote builds in B53880: Diff 15264.Jun 4 2025, 8:06 AM

machniak accepted this revision.Jun 4 2025, 9:18 AM

This revision is now accepted and ready to land.Jun 4 2025, 9:18 AM

Closed by commit rK3e63d0c451bc: Make the api for the kolab plugin accessible on a localhost domain. · Explain WhyJun 4 2025, 9:35 AM

This revision was automatically updated to reflect the committed changes.

mollekopf added a commit: rK3e63d0c451bc: Make the api for the kolab plugin accessible on a localhost domain.

Make the api for the kolab plugin accessible on a localhost domain
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 15276

src/app/Http/Kernel.php

src/app/Http/Middleware/RegularHosts.php

src/routes/api.php

Make the api for the kolab plugin accessible on a localhost domainClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 15276

src/app/Http/Kernel.php

src/app/Http/Middleware/RegularHosts.php

src/routes/api.php

Make the api for the kolab plugin accessible on a localhost domain
ClosedPublic
Actions

Revision Contents
Changeset List