Indeed. I just noticed that the actual error wasn't an exception. It was PHP Fatal error: Uncaught Error: __clone method called on non-object in /usr/share/roundcubemail/plugins/libcalendaring/lib/libcalendaring_vcalendar.php:633, so to catch it we'd have to catch Throwable, I suppose, I'm not sure.

I suppose it would be better to just make sure that the logic in Sync.php works instead of ignoring ical errors specifically.

What I find a bit odd is that we already try to catch exceptions in Command/Sync.php on all getEntry calls, so that should already take care of it, no?

• phpdoc

• Missing DAV/Search

You can just push it once you looked over the migration change.

Looks good apart from the migration change (which might be fine but doesn't relate to the diff).

nice cleanup

In D4827#59694, @machniak wrote:

Good progress, but I was about to work on DAV, and I already have some conflicting code. Please, don't work on DAV at this moment.

Small imap fixup, let the exporter implement the migration strategy

Good progress, but I was about to work on DAV, and I already have some conflicting code. Please, don't work on DAV at this moment.

dav migration, separate migrators for imap/dav

Short term, we should update the php-http-request2 package. 2.6.0 supports PHP >= 5.6 still, so there's no issue with that.

This only implements migrating imap messages but highlights how the current framework doesn't cleanly facilitate not using the job per item strategy.
I think there's a cleaner approach to implementing the two strategies than what I did above, e.g. by moving the processFolder logic entirely to the exporter.

I think we can merge it and take it from there.

Thanks - I've added it to my "must fix list" when upgrading...

• Merge branch 'master' into dev/dav-folders-init

• Small improvements

• Fix case

• Remove unused $response variable

Maybe this would be better as a subtab in the finances tab, but it's a start.

Don't break all existing logic related to cost

Sum up charges and fees first, then limit by wallet balance.

it was a smarty version issue.
bookworm comes with smarty4.