Page MenuHomePhorge
Feed All Stories

Apr 18 2025

machniak closed D5181: Metrics: Improve collectPayersCount() - use transactions instead of payments.
Apr 18 2025, 6:10 AM
machniak committed rKe28b38b374ca: Metrics: Improve collectPayersCount() - use transactions instead of payments.
Apr 18 2025, 6:10 AM
machniak closed D5178: Stats: Make payers count depend on transactions not payments.
Apr 18 2025, 6:10 AM
machniak committed rK572831c5be12: Stats: Make payers count depend on transactions not payments.
Apr 18 2025, 6:10 AM
machniak closed D5175: Rate Limit: Check wallet transactions instead of payments.
Apr 18 2025, 6:10 AM
machniak committed rK8f92cf54215b: Rate Limit: Check wallet transactions instead of payments.
Apr 18 2025, 6:10 AM
machniak requested changes to D5187: Clear caches so we can detect new folders.
Apr 18 2025, 6:04 AM
machniak committed rS42a25d1899f6: Fix phpstan errors on PHP 8.2.
Apr 18 2025, 6:03 AM
machniak abandoned D5160: Remove usage of undeclared variable.

The line was removed in 11d585165aee0.

Apr 18 2025, 5:33 AM
machniak updated the diff for D5199: Kolab integration plugin.
  • Add configuration feature to the kolab plugin
Apr 18 2025, 5:22 AM
machniak updated the diff for D5205: Webmail configuration API.
  • Add a sample on skin/logo
Apr 18 2025, 4:56 AM
mollekopf updated the diff for D5187: Clear caches so we can detect new folders.

This now properly tests the metadata cache issue.

Apr 18 2025, 1:56 AM

Apr 17 2025

machniak requested review of D5205: Webmail configuration API.
Apr 17 2025, 1:39 PM
machniak retitled D5172: Delegation from [WIP] Delegation
Apr 17 2025, 8:44 AM
machniak updated the diff for D5172: Delegation.
  • Replace delegation activated_at column with typical status column
Apr 17 2025, 8:43 AM

Apr 16 2025

machniak added a comment to D5202: IMAP and LDAP Facades (mocking).

This is now completed for LDAP and IMAP facades and ready for review. There were some more tricks needed, but I like the result. These changes already revealed two small bugs that I fixed.

Apr 16 2025, 1:42 PM
machniak retitled D5202: IMAP and LDAP Facades (mocking) from [POC] IMAP Facade (mocking)
Apr 16 2025, 1:38 PM
machniak updated the diff for D5202: IMAP and LDAP Facades (mocking).
  • Add LDAP facade and migrate tests
Apr 16 2025, 1:37 PM
machniak accepted D5184: Sleep after the loop so we can respond immediately.
Apr 16 2025, 7:48 AM
mollekopf updated the diff for D5184: Sleep after the loop so we can respond immediately.

We either have time left to sleep, or we break. So no point in having the min anymore.

Apr 16 2025, 7:40 AM
mollekopf added inline comments to D5184: Sleep after the loop so we can respond immediately.
Apr 16 2025, 7:36 AM
mollekopf added inline comments to D5184: Sleep after the loop so we can respond immediately.
Apr 16 2025, 7:31 AM
mollekopf updated the diff for D5184: Sleep after the loop so we can respond immediately.

Avoid unnecessary and confusing secondsLeft updates

Apr 16 2025, 7:30 AM
mollekopf added a comment to D5202: IMAP and LDAP Facades (mocking).

I'm going to keep tests against a real backend in tests/Feature/Backends/, where all IMAP methods should have it's test. Also DataMigrator tests and Infrastructure tests will stay this way.

But anywhere else we can use mocking.

Apr 16 2025, 7:18 AM
machniak added a comment to D5202: IMAP and LDAP Facades (mocking).

I'm going to keep tests against a real backend in tests/Feature/Backends/, where all IMAP methods should have it's test. Also DataMigrator tests and Infrastructure tests will stay this way.

Apr 16 2025, 7:00 AM
mollekopf added a comment to D5202: IMAP and LDAP Facades (mocking).

I think this is a good idea. There's always a tradeoff where there is some value in testing against the actual backend vs having a mock + a separate imap backend test. But I think especially we the currently relatively simple interface having a mock makes a lot of sense to make our tests faster and more robust.

Apr 16 2025, 6:55 AM

Apr 15 2025

machniak updated the diff for D5172: Delegation.
  • Include delegator name in the response
  • Fix UI
Apr 15 2025, 1:48 PM
machniak requested review of D5202: IMAP and LDAP Facades (mocking).
Apr 15 2025, 1:10 PM
machniak committed rRPK220d7aaf7bdf: Calendar: Allow shared folder to be set as a default calendar.
Apr 15 2025, 1:09 PM
machniak updated the diff for D5199: Kolab integration plugin.
  • Exclude self from user autocomplete result
Apr 15 2025, 11:22 AM
machniak requested review of D5199: Kolab integration plugin.
Apr 15 2025, 11:16 AM

Apr 14 2025

mollekopf added a comment to D5196: Test caching in Ping.

That's not exactly the same as doing it in another client. I don't like the test code in Ping command code. Maybe create a php script that will sleep for a few seconds and then do the metadata update, which you could call using exec() before the Ping request in the test.

Apr 14 2025, 10:11 AM
mollekopf added inline comments to D5187: Clear caches so we can detect new folders.
Apr 14 2025, 10:06 AM

Apr 13 2025

machniak added a comment to D5196: Test caching in Ping.

That's not exactly the same as doing it in another client. I don't like the test code in Ping command code. Maybe create a php script that will sleep for a few seconds and then do the metadata update, which you could call using exec() before the Ping request in the test.

Apr 13 2025, 6:45 AM
machniak requested changes to D5184: Sleep after the loop so we can respond immediately.
Apr 13 2025, 6:22 AM
mollekopf added a reviewer for D5196: Test caching in Ping: Syncroton Developers.
Apr 13 2025, 4:49 AM
mollekopf added inline comments to D5187: Clear caches so we can detect new folders.
Apr 13 2025, 4:44 AM
mollekopf requested review of D5196: Test caching in Ping.
Apr 13 2025, 4:39 AM
mollekopf added inline comments to D5184: Sleep after the loop so we can respond immediately.
Apr 13 2025, 3:12 AM
mollekopf updated the diff for D5187: Clear caches so we can detect new folders.

Added some tests

Apr 13 2025, 3:07 AM
mollekopf updated the diff for D5184: Sleep after the loop so we can respond immediately.

Stick to the logic that we only sleep if we have a at least ping-timeout + 10s left.

Apr 13 2025, 3:06 AM

Apr 12 2025

machniak accepted D5193: Force default folders to be always subscribed.
Apr 12 2025, 10:34 AM
machniak added inline comments to D5184: Sleep after the loop so we can respond immediately.
Apr 12 2025, 10:30 AM
mollekopf added inline comments to D5184: Sleep after the loop so we can respond immediately.
Apr 12 2025, 10:21 AM
mollekopf updated the diff for D5193: Force default folders to be always subscribed.

Adjust the kolab4 implementation as well

Apr 12 2025, 10:15 AM
mollekopf added inline comments to D5187: Clear caches so we can detect new folders.
Apr 12 2025, 10:03 AM
mollekopf added inline comments to D5187: Clear caches so we can detect new folders.
Apr 12 2025, 9:24 AM

Apr 11 2025

machniak requested changes to D5184: Sleep after the loop so we can respond immediately.
Apr 11 2025, 4:14 PM
machniak requested changes to D5193: Force default folders to be always subscribed.

kolab_sync_storage_kolab4::folder_id2name() implementation will need similar change. There DAV folders are handled separately.

Apr 11 2025, 4:02 PM
machniak requested changes to D5187: Clear caches so we can detect new folders.
Apr 11 2025, 3:48 PM
mollekopf added a reviewer for D5184: Sleep after the loop so we can respond immediately: Syncroton Developers.
Apr 11 2025, 3:02 PM
mollekopf added a reviewer for D5193: Force default folders to be always subscribed: Syncroton Developers.
Apr 11 2025, 3:00 PM
mollekopf added a reviewer for D5187: Clear caches so we can detect new folders: Syncroton Developers.
Apr 11 2025, 3:00 PM
mollekopf accepted D5181: Metrics: Improve collectPayersCount() - use transactions instead of payments.
Apr 11 2025, 2:59 PM
mollekopf requested review of D5193: Force default folders to be always subscribed.
Apr 11 2025, 2:58 PM
mollekopf requested review of D5190: Skip folder tests that don't work in the containers.
Apr 11 2025, 2:58 PM
mollekopf requested review of D5187: Clear caches so we can detect new folders.
Apr 11 2025, 2:58 PM
mollekopf requested review of D5184: Sleep after the loop so we can respond immediately.
Apr 11 2025, 2:58 PM
machniak updated the diff for D5172: Delegation.
  • Code cleanup
  • Merge branch 'master' into dev/delegation
  • Cleanup
  • Cleanup
Apr 11 2025, 12:26 PM
machniak committed rKa16d0773c8a0: Silence phpstan issues with new Horizon.
Apr 11 2025, 12:00 PM
machniak updated the diff for D5172: Delegation.
  • Browser tests
  • Merge branch 'master' into dev/delegation
  • More on delegation logic
  • Resetting identities on delegation delete
  • Unsubscribing/unsharing of IMAP folders
  • Unsubscribing/unsharing of DAV folders
Apr 11 2025, 10:32 AM

Apr 10 2025

machniak requested review of D5181: Metrics: Improve collectPayersCount() - use transactions instead of payments.
Apr 10 2025, 11:07 AM
machniak updated the diff for D5175: Rate Limit: Check wallet transactions instead of payments.
  • Skip transactions with amount<=0
Apr 10 2025, 6:48 AM
machniak updated the diff for D5178: Stats: Make payers count depend on transactions not payments.
  • Skip transactions with amount=0
Apr 10 2025, 6:42 AM

Apr 9 2025

mollekopf accepted D5175: Rate Limit: Check wallet transactions instead of payments.
Apr 9 2025, 3:27 PM
mollekopf accepted D5178: Stats: Make payers count depend on transactions not payments.

I think we'll need the same in the metrics controller.

Apr 9 2025, 3:25 PM
machniak requested review of D5178: Stats: Make payers count depend on transactions not payments.
Apr 9 2025, 1:26 PM
machniak requested review of D5175: Rate Limit: Check wallet transactions instead of payments.
Apr 9 2025, 12:54 PM

Apr 8 2025

mollekopf archived Zanshin Developers.
Apr 8 2025, 10:39 AM
mollekopf archived Zanshin.
Apr 8 2025, 10:39 AM
machniak added a comment to T8394: Some calendar entries are not displayed - wrong kolabformat.

kolabobject is part of php-kolab package.

Apr 8 2025, 10:28 AM
mollekopf changed the Can Use Application policy for application Diffusion from All Users to Public (No Login Required).
Apr 8 2025, 10:18 AM
mollekopf changed the Can Use Application policy for application Diffusion from Public (No Login Required) to All Users.
Apr 8 2025, 9:39 AM

Apr 7 2025

machniak committed rRPKb4c938b66fa4: Calendar: Inactive calendar can also be the default.
Apr 7 2025, 1:06 PM
machniak closed D5169: Jobs refactoring: Use withFakeQueueInteractions() and dispatchSync().
Apr 7 2025, 12:30 PM
machniak committed rKa7a936d8a47c: Jobs refactoring: Use withFakeQueueInteractions() and dispatchSync().
Apr 7 2025, 12:30 PM
machniak closed D5166: Small performance improvement in User::isDegraded().
Apr 7 2025, 12:30 PM
machniak committed rK681fac8bd5b2: Small performance improvement in User::isDegraded().
Apr 7 2025, 12:30 PM
machniak closed D5163: Dispatch user DeleteJobs after delete (not before).
Apr 7 2025, 12:30 PM
machniak committed rKed43349657fd: Dispatch user DeleteJobs after delete (not before).
Apr 7 2025, 12:30 PM
machniak requested review of D5172: Delegation.
Apr 7 2025, 11:56 AM
mollekopf added a comment to T8414: https://docs.kolab.org/ is not available .

docs.kolab.org was built from this repository: https://git.kolab.org/diffusion/D/ (which should be the same as the github one, but if in question git.kolab.org is the up-to-date version).

Apr 7 2025, 8:56 AM · Bug Reports
menge added a comment to T8414: https://docs.kolab.org/ is not available .

There where many documents

  • Howtos
  • Admin and Developer Guids
  • Kolab Architecture
Apr 7 2025, 8:27 AM · Bug Reports
mollekopf accepted D5163: Dispatch user DeleteJobs after delete (not before).
Apr 7 2025, 7:53 AM
mollekopf accepted D5169: Jobs refactoring: Use withFakeQueueInteractions() and dispatchSync().
Apr 7 2025, 7:50 AM
mollekopf accepted D5166: Small performance improvement in User::isDegraded().
Apr 7 2025, 7:31 AM
mollekopf added inline comments to D5166: Small performance improvement in User::isDegraded().
Apr 7 2025, 7:31 AM

Apr 6 2025

machniak renamed Kolab Groupware Development Scratch Book from شركة تنظيف مكيفات بالدمام to Kolab Groupware Development Scratch Book.
Apr 6 2025, 9:31 AM
machniak deleted Strategies For Crafting Academic Papers.
Apr 6 2025, 9:25 AM
CletisBruce created Strategies For Crafting Academic Papers.
Apr 6 2025, 7:33 AM

Apr 5 2025

machniak closed T8409: kolab-webadmin: more php8 deprecation warnings as Resolved.

Fixed in master of kolab-webadmin and kolab-net-ldap3.

Apr 5 2025, 2:38 PM · Web Administration Panel, Bug Reports
machniak committed rWAP89215c2d0e52: Fix PHP Deprecated: Creation of dynamic property User::$user_bind_dn.
Apr 5 2025, 2:37 PM
machniak committed rPNL998b91a230ef: Fix PHP Deprecated: Creation of dynamic property LDAP::$additional_filter is….
Apr 5 2025, 2:34 PM
machniak assigned T8414: https://docs.kolab.org/ is not available to mollekopf.

I'm not sure about this since we have Knowledge Base. https://kb.kolab.org/2023/03/install-kolab-16-on-alma-linux-9/

Apr 5 2025, 2:27 PM · Bug Reports
machniak closed T8418: Fatal error: Uncaught Error: Cannot access private property LDAP::$domain as Resolved by committing rPNL11d585165aee: Remove invalid and redundant debug message.
Apr 5 2025, 2:24 PM · Web Administration Panel, Bug Reports
machniak committed rPNL11d585165aee: Remove invalid and redundant debug message.
Apr 5 2025, 2:24 PM

Apr 3 2025

machniak requested review of D5169: Jobs refactoring: Use withFakeQueueInteractions() and dispatchSync().
Apr 3 2025, 1:15 PM

Mar 31 2025

machniak committed rK86e868d04aa8: EWS: Skip "Calendar Version Store" folder.
Mar 31 2025, 9:10 AM

Mar 28 2025

machniak requested review of D5166: Small performance improvement in User::isDegraded().
Mar 28 2025, 11:15 AM
machniak requested review of D5163: Dispatch user DeleteJobs after delete (not before).
Mar 28 2025, 10:43 AM