Page MenuHomePhorge

kolab-webadmin: more php8 deprecation warnings
Open, Needs TriagePublic

Description

[31-Oct-2024 12:05:23 UTC] PHP Deprecated: Creation of dynamic property User::$user_bind_dn is deprecated in /usr/share/kolab-webadmin/li
b/kolab_api_controller.php on line 264
[31-Oct-2024 12:05:23 UTC] PHP Deprecated: Creation of dynamic property User::$user_bind_pw is deprecated in /usr/share/kolab-webadmin/lib/kolab_api_controller.php on line 264

Should be fixed with:

--- /home/jochen/tmp/kolab-webadmin/lib/User.php        2024-10-27 16:37:00.846759557 +0100
+++ lib/User.php        2024-10-31 13:17:30.460872333 +0100
@@ -33,6 +33,8 @@
     private $password;
     private $domain;
     private $working_domain;
+    public $user_bind_dn;
+    public $user_bind_pw;


     public function authenticate($username, $password, $domain = null, &$attributes = null)

Then we have:

[31-Oct-2024 12:17:47 UTC] PHP Deprecated: Creation of dynamic property LDAP::$additional_filter is deprecated in /usr/share/php/Net/LDAP3.php on line 1776

manually edited diff:

--- /home/jochen/tmp/kolab-webadmin/lib/Auth/LDAP.php   2024-10-31 20:16:16.209023726 +0100
+++ ./lib/Auth/LDAP.php 2024-10-31 13:18:55.509568498 +0100
@@ -32,7 +32,9 @@
     private $_ldap_uri;
     private $_ldap_port;
     private $_ldap_scheme;
-    private $sort_result_key;
+    private $user_bind_dn;
+    private $user_bind_pw;
+    private $additional_filter;

     /**
      * Class constructor

And finally:
[31-Oct-2024 12:17:47 UTC] PHP Warning: Undefined array key "aclrights" in /usr/share/php/Net/LDAP3.php on line 742

This could be fixed by updating php-net-ldap3 or vendoring a new release (like it's done in roundcubemail).

Details

Ticket Type
Task