Page MenuHomePhorge
Feed Advanced Search

Jun 29 2017

machniak committed rRPK2ad0d6651dfb: Move more common methods used by tasklist and calendar to libcalendaring (authored by machniak).
Move more common methods used by tasklist and calendar to libcalendaring
Jun 29 2017, 11:22 AM

Jun 28 2017

machniak committed rRPKc718804f36ca: Fix recognizing an organizer in event delete confirmation dialog (authored by machniak).
Fix recognizing an organizer in event delete confirmation dialog
Jun 28 2017, 1:16 PM

Jun 27 2017

machniak committed rRPKab5b61b38b75: Remove redundant vars (authored by machniak).
Remove redundant vars
Jun 27 2017, 1:23 PM
machniak closed T2519: Possibly a bug when recurring events makes Outlook with ActiveSync switch to permanent disconnected mode as Resolved.

Fixed.

Jun 27 2017, 12:16 PM · Syncroton, Bug Reports
machniak committed rS4e805ba57d99: T2519: Fix Recurrence element structure (authored by machniak).
T2519: Fix Recurrence element structure
Jun 27 2017, 12:16 PM
machniak added a comment to T2519: Possibly a bug when recurring events makes Outlook with ActiveSync switch to permanent disconnected mode.

@adomaitis Looks like both DayOfWeek and Until are optional. In this case I think we just should not include DayOfWeek in the response. Did you test that?

Jun 27 2017, 10:41 AM · Syncroton, Bug Reports

Jun 22 2017

machniak added a project to T2507: Make canceled events more distiguishable in calendar view: Roundcube Kolab Plugins .
Jun 22 2017, 8:52 AM · Roundcube Kolab Plugins , Architecture & Design
machniak added a comment to T2498: Wallace logs errors when run in debug 9 mode.

Not exactly the same error, but we have already T2163.

Jun 22 2017, 8:51 AM · PyKolab, Bug Reports

Jun 21 2017

machniak added a comment to T2504: Inconsistent behavior while accepting invitations in roundcube.
  1. So, the iTips differ not much. I don't think CLASS:PUBLIC is relevant.
  2. I think it's possible. When the event time changes client could request "re-sheduling". You'd need to see what's in G's iTip in step 4.
Jun 21 2017, 3:14 PM · PyKolab, Roundcube Kolab Plugins , Roundcube, Bug Reports
machniak added a comment to T2504: Inconsistent behavior while accepting invitations in roundcube.

We'd need to see iTip payload. I guess that in step 4, the event is in "re-sheduling" mode, i.e. the attendee status is re-set to NEEDS-ACTION. In such a case (and settings) wallace will not respond with ACCEPT. I have no idea what could be different in iTip replies sent in step 2 and 6.

Jun 21 2017, 1:01 PM · PyKolab, Roundcube Kolab Plugins , Roundcube, Bug Reports
machniak added a comment to T1796: Document editor UI considerations.

FYI, Collabora Online 2.1.2 added support for avatars and custom button. So, technically it should be possible to move all our functionality into the editor frame.

Jun 21 2017, 10:23 AM · Roundcube Kolab Plugins , WOPI
machniak closed T2492: PHP Fatal error on some vCard4 BDAY/ANNIVERSARY input as Resolved.

Fixed.

Jun 21 2017, 10:00 AM · iRony
machniak committed rI8fd8407339c2: Fix PHP Fatal error on some vCard4 BDAY/ANNIVERSARY input (T2492) (authored by machniak).
Fix PHP Fatal error on some vCard4 BDAY/ANNIVERSARY input (T2492)
Jun 21 2017, 10:00 AM
machniak created T2492: PHP Fatal error on some vCard4 BDAY/ANNIVERSARY input.
Jun 21 2017, 9:26 AM · iRony
machniak created T2489: Improve GAL merging support.
Jun 21 2017, 8:42 AM · Syncroton

Jun 20 2017

machniak added a comment to T2483: Support MeetingResponse.

SendResponse element was added in version >=16.0 of the ActiveSync protocol, which means it is optional and can be excluded from the initial implementation. Also, from what I see it is about calendar events. I didn't found any information about handling of iTips for TODO (tasks), so they are probably ignored.

Jun 20 2017, 12:18 PM · Syncroton
machniak updated the diff for D449: Kolab ActiveSync (Syncroton) configuration manual.

Add note about uid and changed fields

Jun 20 2017, 10:52 AM
machniak added a comment to T2477: GAL for Outlook.

One additional change is required in the ldap_public config:

Note: To make the LDAP addressbook sources working we need two additional
	//       fields ('uid' and 'changed') specified in the fieldmap array
	//       of the LDAP configuration ('ldap_public' option). For example:
	//          'uid'     => 'nsuniqueid',
	//          'changed' => 'modifytimestamp',
Jun 20 2017, 10:49 AM · Syncroton
machniak committed rSc2cdb863178c: Add important note about uid and changed fields in GAL config (authored by machniak).
Add important note about uid and changed fields in GAL config
Jun 20 2017, 10:47 AM
machniak committed rIfd53ed716c1e: Fix deprecation-warning log spam (authored by machniak).
Fix deprecation-warning log spam
Jun 20 2017, 9:03 AM
machniak closed D339: Fix deprecation-warning log spam by committing rIfd53ed716c1e: Fix deprecation-warning log spam.
Jun 20 2017, 9:03 AM

Jun 19 2017

machniak committed rRSC8fa511592989: Compat. fixes for Roundcube 1.3 (authored by machniak).
Compat. fixes for Roundcube 1.3
Jun 19 2017, 1:51 PM
machniak updated the diff for D449: Kolab ActiveSync (Syncroton) configuration manual.

Describe new blacklist and GAL options

Jun 19 2017, 10:43 AM

Jun 16 2017

machniak created T2483: Support MeetingResponse.
Jun 16 2017, 7:33 PM · Syncroton
machniak committed rRPK3036593869ab: Fix recognizing an organizer in event delete confirmation dialog (authored by machniak).
Fix recognizing an organizer in event delete confirmation dialog
Jun 16 2017, 5:44 PM
machniak committed rS07a86bbd51c6: Fix MeetingStatus value (Bifrost#T34257) (authored by machniak).
Fix MeetingStatus value (Bifrost#T34257)
Jun 16 2017, 5:09 PM
machniak closed T2477: GAL for Outlook as Resolved.

This is done. Required configuration for Outlook:

$config['activesync_gal_sync'] = array('windowsoutlook');
$config['activesync_multifolder_blacklist_contact'] = array('windowsoutlook');
Jun 16 2017, 10:44 AM · Syncroton
machniak committed rS3695940a9949: T2477: GAL for Outlook (authored by machniak).
T2477: GAL for Outlook
Jun 16 2017, 10:43 AM

Jun 15 2017

machniak created T2477: GAL for Outlook.
Jun 15 2017, 3:12 PM · Syncroton
machniak added a comment to T1246: Various issues when using dtstart/dtend in a request.

1-3 is fixed via merged D204.

Jun 15 2017, 11:51 AM · Free/Busy, Restricted Project, Bug Reports
machniak committed rFf95dd433504d: T1246: Fix various issues when using dtstart/dtend in a request (authored by machniak).
T1246: Fix various issues when using dtstart/dtend in a request
Jun 15 2017, 11:50 AM
machniak closed D204: T1246: Fix various issues when using dtstart/dtend in a request by committing rFf95dd433504d: T1246: Fix various issues when using dtstart/dtend in a request.
Jun 15 2017, 11:50 AM
machniak committed rFde5497e44ab9: Merge branch 'arcpatch-D204' (authored by machniak).
Merge branch 'arcpatch-D204'
Jun 15 2017, 11:50 AM

Jun 13 2017

machniak committed rI417f44262e5b: Add note that uid and changed fields are required for global addressbook (authored by machniak).
Add note that uid and changed fields are required for global addressbook
Jun 13 2017, 9:27 AM

Jun 12 2017

machniak committed rRPK39b874e6ebde: Let users set message expiry on folders (Bifrost#T33804) (authored by machniak).
Let users set message expiry on folders (Bifrost#T33804)
Jun 12 2017, 12:28 PM
machniak committed rRPKb11c74e0a5a6: Update localization (authored by machniak).
Update localization
Jun 12 2017, 10:57 AM

Jun 7 2017

machniak added a comment to T2313: kolab 16.1 roundcube webmail calendar internal server error parsing time string.

Search for files with content "FLE Daylight Time" in /var/spool/imap/domain/ and provide a sample file.

Jun 7 2017, 12:48 PM · Roundcube Kolab Plugins , Kolab 16, Bug Reports
machniak closed T1742: Chwala does not log failed login attempts, if the user name exists as Resolved.

Fixed.

Jun 7 2017, 12:02 PM · Chwala, Bug Reports
machniak committed rC9a07f3fb9940: Fix logging failed login attempts if the username exists (T1742) (authored by machniak).
Fix logging failed login attempts if the username exists (T1742)
Jun 7 2017, 12:02 PM
machniak closed T1739: iRony does not log failed login attempts, if user name exists as Resolved.

Fixed.

Jun 7 2017, 11:41 AM · iRony, Bug Reports
machniak committed rIde89b6ca76f9: Fix logging failed login attempts if the username exists (T1739) (authored by machniak).
Fix logging failed login attempts if the username exists (T1739)
Jun 7 2017, 11:41 AM
machniak closed T1751: Syncroton does not log failed login attempts, if the user name exists as Resolved.

Fixed.

Jun 7 2017, 11:35 AM · Syncroton, Bug Reports
machniak committed rS3601376aef5d: Fix logging failed login attempts if the username exists (T1751) (authored by machniak).
Fix logging failed login attempts if the username exists (T1751)
Jun 7 2017, 11:35 AM
machniak committed rRPKa7d37da5e11c: Improvements in kolab_auth::log_login_error() (authored by machniak).
Improvements in kolab_auth::log_login_error()
Jun 7 2017, 10:21 AM

Jun 6 2017

machniak added a comment to T2426: File viewers do not work behind a reverse proxy.

https://git.kolab.org/diffusion/C/browse/master/lib/viewers/text.php;0349c2d846613e4c828ed6f7af00b87ed6a75f79$120

Jun 6 2017, 3:15 PM · Kolab 16, Chwala
machniak added a comment to T2426: File viewers do not work behind a reverse proxy.

In this case it is Roundcube connecting to Chwala directly. It looks like the config has been ignored. I have no idea how's that possible. Maybe there's something in between that caches the request and returns old response? Check with a different file.

Jun 6 2017, 1:42 PM · Kolab 16, Chwala
machniak added a comment to T1667: Renaming an address book renders groups inaccessable.

Page refresh should fix the issue. This is a regression that is not so simple to fix. My first take on this failed.

Jun 6 2017, 12:05 PM · Roundcube Kolab Plugins , Bug Reports
machniak added a comment to T2426: File viewers do not work behind a reverse proxy.

But it should work if you set file_api_url to a full url with https:// prefix? Do you set options in /etc/roundcubemail/config.inc.php? I'm unable to reproduce.

Jun 6 2017, 12:01 PM · Kolab 16, Chwala
machniak added a comment to T2426: File viewers do not work behind a reverse proxy.

And that is with use_https=true? BTW, there's another fix: rC0349c2d84661.

Jun 6 2017, 11:40 AM · Kolab 16, Chwala
machniak committed rC0349c2d84661: Fix type: $url -> $api_url (T2426) (authored by machniak).
Fix type: $url -> $api_url (T2426)
Jun 6 2017, 11:40 AM
machniak added a comment to T2426: File viewers do not work behind a reverse proxy.

Ok, try this change: rCd0539d6f029d.

Jun 6 2017, 11:23 AM · Kolab 16, Chwala
machniak committed rCd0539d6f029d: Use HTTP_HOST instead of SERVER_NAME (to be in sync with rcube_utils… (authored by machniak).
Use HTTP_HOST instead of SERVER_NAME (to be in sync with rcube_utils…
Jun 6 2017, 11:23 AM
machniak added a comment to T2426: File viewers do not work behind a reverse proxy.

I don't see how $_SERVER['SERVER_PORT'] == 80 would make it appended to the url. The if statement requires it to be different than $port and than 80. Maybe we should use intval($_SERVER['SERVER_PORT']).

Jun 6 2017, 11:10 AM · Kolab 16, Chwala
machniak committed rC0f872f6a9c4d: Don't advertise text/plain as supported by CODE, we have other viewer for it (authored by machniak).
Don't advertise text/plain as supported by CODE, we have other viewer for it
Jun 6 2017, 11:01 AM
machniak added a comment to T2426: File viewers do not work behind a reverse proxy.

Maybe you just applied the patch incorrectly. Note the dot character in this line:

$url .= ':' . $_SERVER['SERVER_PORT'];
Jun 6 2017, 10:37 AM · Kolab 16, Chwala
machniak added a comment to T2426: File viewers do not work behind a reverse proxy.

Forget my last comment. There's no such thing like $_SERVER['HTTP_PORT'].

Jun 6 2017, 10:34 AM · Kolab 16, Chwala
machniak added a comment to T2426: File viewers do not work behind a reverse proxy.

Hmm... I'm just thinking. Maybe in your env you don't have $_SERVER['SERVER_PORT'] set either. Then try replacing this with $_SERVER['HTTP_PORT'].

Jun 6 2017, 10:12 AM · Kolab 16, Chwala
machniak added a comment to T2426: File viewers do not work behind a reverse proxy.

What if you replace $_SERVER['SERVER_NAME'] with $_SERVER['HTTP_HOST']?

Jun 6 2017, 10:09 AM · Kolab 16, Chwala
machniak closed T2426: File viewers do not work behind a reverse proxy as Resolved.

Hope rCd886aeac2aec fixes that.

Jun 6 2017, 9:04 AM · Kolab 16, Chwala
machniak committed rCd886aeac2aec: Fix port number in generated API URL when behind a reverse proxy (T2426) (authored by machniak).
Fix port number in generated API URL when behind a reverse proxy (T2426)
Jun 6 2017, 9:04 AM

Jun 5 2017

machniak reopened T2426: File viewers do not work behind a reverse proxy as "Open".
Jun 5 2017, 5:33 PM · Kolab 16, Chwala

Jun 4 2017

machniak committed rS52325937c502: More reliable folder hierarchy changes handling (Bifrost#T33552) (authored by machniak).
More reliable folder hierarchy changes handling (Bifrost#T33552)
Jun 4 2017, 12:04 PM

Jun 3 2017

machniak closed T2235: Syncroton + Outlook 2013 - folder rename does not work correctly as Resolved.

While using constant folder identifiers would be good long term solution, in meantime I've found a simpler way. With rS57c38b7aede3 the device will correctly handle folder renames and re-synchronize folder hierarchy and renamed folder content. Closing.

Jun 3 2017, 9:39 PM · Syncroton, Bug Reports
machniak committed rS57c38b7aede3: T2235: Fix folder rename (on the client) issue (authored by machniak).
T2235: Fix folder rename (on the client) issue
Jun 3 2017, 9:31 PM

Jun 2 2017

machniak committed rRPK17d18bebb144: Skip redundant folder type lookup on folders list (authored by machniak).
Skip redundant folder type lookup on folders list
Jun 2 2017, 3:15 PM
machniak added a comment to D443: More on channels management.

@seigo I'm done with this for now, will be busy with other stuff now, so you can merge this and continue. I added presence to room channel, but commented out, as I'm not sure we really need it there.

Jun 2 2017, 8:35 AM
machniak updated the diff for D443: More on channels management.

Refactor Presence

Jun 2 2017, 8:30 AM

Jun 1 2017

machniak created D449: Kolab ActiveSync (Syncroton) configuration manual.
Jun 1 2017, 7:29 PM
machniak updated the diff for D443: More on channels management.
  • Store channel metadata (basics with :ets use)
Jun 1 2017, 9:19 AM

May 31 2017

machniak closed T2438: Editing a text file does not work as Resolved.

Fixed.

May 31 2017, 10:52 AM · Roundcube Kolab Plugins , Bug Reports
machniak committed rRPK2d1bb5a23d94: T2438: Fix javascript error in a file preview (authored by machniak).
T2438: Fix javascript error in a file preview
May 31 2017, 10:51 AM
machniak closed T2426: File viewers do not work behind a reverse proxy as Resolved.

Fixed. You now would need to set use_https to true or file_api_uri to full chwala api path.

May 31 2017, 10:33 AM · Kolab 16, Chwala
machniak committed rC6bad01bd25fe: Fix file viewers behind reverse proxy (T2426) (authored by machniak).
Fix file viewers behind reverse proxy (T2426)
May 31 2017, 10:31 AM
machniak added a project to T2438: Editing a text file does not work: Roundcube Kolab Plugins .
May 31 2017, 10:07 AM · Roundcube Kolab Plugins , Bug Reports

May 30 2017

machniak added a project to T2459: Feature request: Allow viewing attachments in draft email for web application: Roundcube.

It is possible to preview or download attached files from mail compose screen in Roundcube 1.3. So likely a Kolab 18 feature.

May 30 2017, 4:46 PM · Roundcube
machniak added a project to T2441: Broken link in "Files" plugin: Roundcube Kolab Plugins .

The fix is in roundcubemail-plugins-kolab repo.

May 30 2017, 4:40 PM · Roundcube Kolab Plugins , Kolab 16, Chwala, Bug Reports
machniak closed T2441: Broken link in "Files" plugin as Resolved.

Fixed in rRPKce9ac27d783d.

May 30 2017, 4:30 PM · Roundcube Kolab Plugins , Kolab 16, Chwala, Bug Reports
machniak committed rRPKce9ac27d783d: Fix broken link to blank.tiff (T2441) (authored by machniak).
Fix broken link to blank.tiff (T2441)
May 30 2017, 4:30 PM
machniak committed rRPKecd508450e6f: Remove redundant slashes from configured Chwala URLs (authored by machniak).
Remove redundant slashes from configured Chwala URLs
May 30 2017, 4:30 PM
machniak added projects to T2441: Broken link in "Files" plugin: Chwala, Kolab 16.

Looks like rC21f6abd52a929 broke compatibility with Roundcube 1.2. Looks like we have now 3 options:

  1. Revert the change and wait with Roundcube 1.3 support until it's in Kolab, then apply it again
  2. Copy blank.tiff to blank.tif in roundcubemail package
  3. Use chwala URL to access these files.
May 30 2017, 4:03 PM · Roundcube Kolab Plugins , Kolab 16, Chwala, Bug Reports
machniak committed rRPK8ff42df5e174: Fix error on document editing page when using WOPI and assets_path… (authored by machniak).
Fix error on document editing page when using WOPI and assets_path…
May 30 2017, 2:04 PM
machniak committed rC70fb3925ca9c: Fix empty files section if Collabora response fails (Bifrost#T33285) (authored by machniak).
Fix empty files section if Collabora response fails (Bifrost#T33285)
May 30 2017, 11:34 AM

May 29 2017

machniak added a comment to T2313: kolab 16.1 roundcube webmail calendar internal server error parsing time string.

But this object has valid dates. So, how do I reproduce the issue?

May 29 2017, 9:43 PM · Roundcube Kolab Plugins , Kolab 16, Bug Reports
machniak created T2426: File viewers do not work behind a reverse proxy.
May 29 2017, 8:35 AM · Kolab 16, Chwala

May 26 2017

machniak committed rScae366edcab1: T2420: Support alarms with specified DateTime (authored by machniak).
T2420: Support alarms with specified DateTime
May 26 2017, 3:51 PM
machniak closed T2420: PHP Warning when parsing an alarm on specified datetime as Resolved.

Fixed in cae366edcab1b.

May 26 2017, 3:36 PM · Syncroton
machniak added a comment to T2420: PHP Warning when parsing an alarm on specified datetime.

Activesync supports reminders (alarms) only as "the number of minutes before a calendar item start time". So, we can just ignore these alarms or check if the datetime is before start time of the event and calculate number of minutes.

May 26 2017, 2:54 PM · Syncroton
machniak created T2420: PHP Warning when parsing an alarm on specified datetime.
May 26 2017, 2:49 PM · Syncroton
machniak committed rRPK951f9f0efc74: Don't use global $CONFIG variable (authored by machniak).
Don't use global $CONFIG variable
May 26 2017, 10:40 AM
machniak created D443: More on channels management.
May 26 2017, 10:02 AM

May 24 2017

machniak closed T2408: Files app shows file modified date not in user's timezone as Resolved.
May 24 2017, 1:47 PM · Chwala, Bug Reports, Roundcube Kolab Plugins
machniak added a project to T2408: Files app shows file modified date not in user's timezone: Chwala.

Fixed in:

May 24 2017, 1:45 PM · Chwala, Bug Reports, Roundcube Kolab Plugins
machniak committed rRPKf357819dd03f: T2408: Configure date_format/timezone for files mtime/ctime information (authored by machniak).
T2408: Configure date_format/timezone for files mtime/ctime information
May 24 2017, 1:44 PM
machniak committed rC04ff2737dc5c: T2408: Use client date_format and timezone for file mtime/ctime information (authored by machniak).
T2408: Use client date_format and timezone for file mtime/ctime information
May 24 2017, 1:40 PM
machniak committed rCe412536b1b6e: T2408: Use client date_format and timezone for file mtime/ctime information (authored by machniak).
T2408: Use client date_format and timezone for file mtime/ctime information
May 24 2017, 1:39 PM
machniak committed rC10fd2ba5a3a5: Fix include_path setting (broken recently) (authored by machniak).
Fix include_path setting (broken recently)
May 24 2017, 12:04 PM
machniak committed rRSCd63300af214f: Fix width of "Modified" column on files list (authored by machniak).
Fix width of "Modified" column on files list
May 24 2017, 11:47 AM
machniak claimed T2408: Files app shows file modified date not in user's timezone.

I'm not sure what issue do you have with email, but files are indeed stored with timestamps in UTC. The plugin displays the date as-is provided by chwala. It will be chwala's responsibility to convert it to user timezone (if provided). The timezone would need to be passed by Roundcube to chwala first.

May 24 2017, 11:22 AM · Chwala, Bug Reports, Roundcube Kolab Plugins
machniak added a comment to T2313: kolab 16.1 roundcube webmail calendar internal server error parsing time string.

I can't reproduce the issue by importing the .ics file. Could you provide the object in xml format (i.e. the message from imap folder)?

May 24 2017, 11:09 AM · Roundcube Kolab Plugins , Kolab 16, Bug Reports

May 22 2017

machniak committed rRPK72ffafaaf9ff: Fix regression where declining an event from Calendar would send CANCEL instead… (authored by machniak).
Fix regression where declining an event from Calendar would send CANCEL instead…
May 22 2017, 1:06 PM