Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Paths
Table of Contents
t
Hide Panel
f
Keyboard Reference
?
Differential
D3235
[Python 3] Remove unnecessary occurrences of .keys()
Closed
Public
Actions
Authored by
sicherha
on Jan 8 2022, 10:38 AM.
Edit Revision
Update Diff
Download Raw Diff
Edit Related Revisions...
Edit Parent Revisions
Edit Child Revisions
Edit Related Objects...
Edit Commits
Edit Tasks
Subscribe
Mute Notifications
Flag For Later
Award Token
Project Tags
None
Referenced Files
F121340361: D3235.1777329803.diff
Sun, Apr 26, 10:43 PM
2026-04-26 22:43:23 (UTC+0)
F121303498: D3235.1777293201.diff
Sun, Apr 26, 12:33 PM
2026-04-26 12:33:21 (UTC+0)
F121181963: D3235.1777176936.diff
Sat, Apr 25, 4:15 AM
2026-04-25 04:15:36 (UTC+0)
F121138481: D3235.1777133470.diff
Fri, Apr 24, 4:11 PM
2026-04-24 16:11:10 (UTC+0)
F120921234: D3235.1777063433.diff
Thu, Apr 23, 8:43 PM
2026-04-23 20:43:53 (UTC+0)
F120797667: D3235.1776913061.diff
Wed, Apr 22, 2:57 AM
2026-04-22 02:57:41 (UTC+0)
F120637940: D3235.1776777882.diff
Mon, Apr 20, 1:24 PM
2026-04-20 13:24:42 (UTC+0)
F120467483: D3235.1776727355.diff
Sun, Apr 19, 11:22 PM
2026-04-19 23:22:36 (UTC+0)
View All 32 Files
Subscribers
None
Details
Reviewers
machniak
mollekopf
Commits
rPc3b9d5557161: [Python 3] Remove unnecessary occurrences of .keys()
Summary
The following cases are covered:
for key in dict
if key in dict
len(dict)
This will make life easier for futurize.
Diff Detail
Repository
rP pykolab
Branch
05-remove-keys
Lint
Lint Errors
Severity
Location
Code
Message
Error
ext/python/Tools/freeze/freeze.py:126
E701
PEP8 E701
Error
ext/python/Tools/freeze/freeze.py:329
E701
PEP8 E701
Error
ext/python/Tools/freeze/freeze.py:435
E401
PEP8 E401
Error
ext/python/Tools/freeze/freeze.py:476
E222
PEP8 E222
Error
pykolab/auth/ldap/syncrepl.py:75
E701
PEP8 E701
Error
pykolab/auth/ldap/syncrepl.py:76
E701
PEP8 E701
Error
pykolab/imap/__init__.py:559
E714
PEP8 E714
Error
pykolab/imap/__init__.py:606
E714
PEP8 E714
Error
pykolab/imap/__init__.py:858
E714
PEP8 E714
Error
pykolab/plugins/sievemgmt/__init__.py:387
E203
PEP8 E203
Error
pykolab/setup/setup_mta.py:403
E111
PEP8 E111
Error
pykolab/setup/setup_mta.py:404
E111
PEP8 E111
Error
pykolab/wap_client/__init__.py:608
E203
PEP8 E203
Error
wallace/module_optout.py:169
E116
PEP8 E116
Error
wallace/module_optout.py:170
E116
PEP8 E116
Error
wallace/module_optout.py:171
E116
PEP8 E116
Warning
pykolab/plugins/sievemgmt/__init__.py:50
W601
PEP8 W601
Unit
No Test Coverage
Build Status
Buildable 37786
Build 15235: arc lint + arc unit
Event Timeline
sicherha
requested review of this revision.
Jan 8 2022, 10:38 AM
2022-01-08 10:38:59 (UTC+0)
sicherha
created this revision.
Harbormaster
completed remote builds in
B37786: Diff 9202
.
Jan 8 2022, 10:38 AM
2022-01-08 10:38:59 (UTC+0)
sicherha
mentioned this in
D3190: Python 3 compatibility
.
Jan 8 2022, 10:42 AM
2022-01-08 10:42:02 (UTC+0)
sicherha
mentioned this in
T6805: Port pykolab to Python 3
.
Jan 8 2022, 10:45 AM
2022-01-08 10:45:07 (UTC+0)
mollekopf
accepted this revision.
Jan 10 2022, 9:00 AM
2022-01-10 09:00:33 (UTC+0)
This revision is now accepted and ready to land.
Jan 10 2022, 9:00 AM
2022-01-10 09:00:33 (UTC+0)
This revision was landed with ongoing or failed builds.
Jan 10 2022, 7:48 PM
2022-01-10 19:48:44 (UTC+0)
Closed by commit
rPc3b9d5557161: [Python 3] Remove unnecessary occurrences of .keys()
.
·
Explain Why
This revision was automatically updated to reflect the committed changes.