Details

Reviewers

vanmeeuwen

Group Reviewers

Restricted Project

Commits

rK2de8edd9f18b: Reseller comissioning system

Diff Detail

Repository

rK kolab

Branch

dev/reseller-comissioning

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 34156
Build 13612: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Apr 9 2021, 2:03 PM

machniak created this revision.

Harbormaster completed remote builds in B33856: Diff 6847.Apr 9 2021, 2:03 PM

Rebase

Harbormaster completed remote builds in B34129: Diff 7063.May 11 2021, 3:19 PM

Rebase

Harbormaster completed remote builds in B34132: Diff 7066.May 11 2021, 3:20 PM

machniak retitled this revision from Reseller comissioning system to [WIP] Reseller comissioning system.May 12 2021, 11:37 AM

machniak edited the summary of this revision. (Show Details)

Migration fixes, tests fixes, added some simple tests

Harbormaster completed remote builds in B34144: Diff 7078.May 12 2021, 2:39 PM

Add tests
Debit reseller's wallet on user deletion (for the negative balance value)
Credit/debit reseller's wallet on Penalize/Award action

Harbormaster completed remote builds in B34156: Diff 7090.May 13 2021, 3:29 PM

machniak retitled this revision from [WIP] Reseller comissioning system to Reseller comissioning system.May 13 2021, 3:33 PM

machniak edited the summary of this revision. (Show Details)

Didn't go through the tests yet.

src/app/Http/Controllers/API/V4/Admin/WalletsController.php
103	Perhaps not the wording we'll want to be using under each of the circumstances that create a positive or negative charge. We should elaborate during the next standup perhaps.
src/app/PackageSku.php
44	It was implemented as a potential future feature, where despite the sku costs and free units, the package cost could still be set separately.
src/app/Providers/PaymentProvider.php
264	At the very least there's a spelling error in the word "commission", but since its also a FIXME, that's not even what I seek to point out.

This revision now requires changes to proceed.May 14 2021, 5:20 PM

vanmeeuwen accepted this revision.May 18 2021, 3:12 PM

This revision is now accepted and ready to land.May 18 2021, 3:12 PM

Merged into dev/reseller

Reseller comissioning systemClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 7090

bin/phpstan

src/app/Console/Commands/DomainSetWallet.php

src/app/Domain.php

src/app/Entitlement.php

src/app/Group.php

src/app/Http/Controllers/API/V4/Admin/WalletsController.php

src/app/Http/Controllers/API/V4/SkusController.php

src/app/Observers/EntitlementObserver.php

src/app/Observers/PackageObserver.php

src/app/Observers/PackageSkuObserver.php

src/app/Observers/PlanObserver.php

src/app/Observers/PlanPackageObserver.php

src/app/Observers/SkuObserver.php

src/app/Observers/UserObserver.php

src/app/Package.php

src/app/PackageSku.php

src/app/Plan.php

src/app/PlanPackage.php

src/app/Providers/AppServiceProvider.php

src/app/Providers/PaymentProvider.php

src/app/Sku.php

src/app/Tenant.php

src/app/User.php

src/app/Wallet.php

src/database/migrations/2019_12_10_100355_create_package_skus_table.php

src/database/migrations/2020_05_05_095212_create_tenants_table.php

src/database/migrations/2021_01_26_150000_change_sku_descriptions.php

src/database/migrations/2021_02_19_093832_discounts_add_tenant_id.php

src/database/migrations/2021_02_19_093833_domains_add_tenant_id.php

src/database/migrations/2021_05_07_150000_groups_add_tenant_id.php

src/database/migrations/2021_05_12_150000_groups_add_tenant_id.php

src/database/seeds/local/TenantSeeder.php

src/tests/Feature/Controller/Admin/WalletsTest.php

src/tests/Feature/Controller/Reseller/WalletsTest.php

src/tests/Feature/EntitlementTest.php

src/tests/Feature/PlanTest.php

src/tests/Feature/SkuTest.php

src/tests/Feature/TenantTest.php

src/tests/Feature/UserTest.php

src/tests/Feature/WalletTest.php

src/tests/TestCase.php

Reseller comissioning system
ClosedPublic
Actions

Revision Contents
Changeset List