Page MenuHomekolab.org

FontAwesome v6 and refactor the way we include icons
ClosedPublic

Authored by machniak on Apr 28 2022, 11:33 AM.

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK352a3753e6bc: FontAwesome v6 and refactor the way we include icons
Summary

Register icons from vue components that use them. The main reason for that
is to keep user.js as small as possible. Initially we saved 20KB, but
it would grow with new features added in the future.

Test Plan

`./phpunit --testsuite=Browser"

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Apr 28 2022, 11:33 AM
machniak created this revision.
machniak updated this revision to Diff 10129.Apr 28 2022, 2:39 PM
  • Merge branch 'master' into dev/fontawesome-refactor
vanmeeuwen accepted this revision.Apr 29 2022, 12:13 PM
This revision is now accepted and ready to land.Apr 29 2022, 12:13 PM
This revision was automatically updated to reflect the committed changes.