Page MenuHomePhorge
Differential D3526

FontAwesome v6 and refactor the way we include icons
ClosedPublic
Actions

Authored by machniak on Apr 28 2022, 11:33 AM.
Tags
None
Referenced Files
F11869617: D3526.id10135.diff
Tue, Apr 23, 7:53 PM
Unknown Object (File)
Sun, Apr 21, 4:50 PM
Unknown Object (File)
Sun, Apr 21, 4:50 PM
Unknown Object (File)
Sun, Apr 21, 4:50 PM
Unknown Object (File)
Sun, Apr 21, 4:50 PM
Unknown Object (File)
Fri, Apr 19, 10:09 PM
Unknown Object (File)
Thu, Apr 18, 10:15 AM
Unknown Object (File)
Wed, Apr 17, 9:24 AM
View All 72 Files
Subscribers
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK352a3753e6bc: FontAwesome v6 and refactor the way we include icons
Summary

Register icons from vue components that use them. The main reason for that
is to keep user.js as small as possible. Initially we saved 20KB, but
it would grow with new features added in the future.

Test Plan

`./phpunit --testsuite=Browser"

Diff Detail

Repository
rK kolab
Branch
dev/fontawesome-refactor
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 38989
Build 15808: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Apr 28 2022, 11:33 AM
machniak created this revision.
Harbormaster completed remote builds in B38989: Diff 10123.Apr 28 2022, 11:33 AM
machniak updated this revision to Diff 10129.Apr 28 2022, 2:39 PM
  • Merge branch 'master' into dev/fontawesome-refactor
Harbormaster completed remote builds in B39001: Diff 10129.Apr 28 2022, 2:39 PM
vanmeeuwen accepted this revision.Apr 29 2022, 12:13 PM
This revision is now accepted and ready to land.Apr 29 2022, 12:13 PM
Closed by commit rK352a3753e6bc: FontAwesome v6 and refactor the way we include icons (authored by machniak). · Explain WhyApr 29 2022, 12:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
108 lines
6 lines
resources/
js/
13 lines
meet/
4 lines
themes/
8 lines
vue/
Admin/
6 lines
11 lines
30 lines
Distlist/
2 lines
6 lines
Domain/
12 lines
6 lines
File/
10 lines
9 lines
10 lines
Meet/
63 lines
6 lines
Reseller/
8 lines
12 lines
Resource/
2 lines
10 lines
SharedFolder/
2 lines
9 lines
6 lines
User/
12 lines
2 lines
2 lines
8 lines
Widgets/
2 lines
4 lines
2 lines
2 lines
2 lines
10 lines
9 lines
2 lines
16 lines
2 lines
2 lines

Diff 10123

View Options

src/package-lock.json

Loading...
View Options

src/package.json

Loading...
View Options

src/resources/js/bootstrap.js

Loading...
View Options

src/resources/js/fontawesome.js

Loading...
View Options

src/resources/js/meet/room.js

Loading...
View Options

src/resources/themes/app.scss

Loading...
View Options

src/resources/vue/Admin/Dashboard.vue

Loading...
View Options

src/resources/vue/Admin/User.vue

Loading...
View Options

src/resources/vue/Dashboard.vue

Loading...
View Options

src/resources/vue/Distlist/Info.vue

Loading...
View Options

src/resources/vue/Distlist/List.vue

Loading...
View Options

src/resources/vue/Domain/Info.vue

Loading...
View Options

src/resources/vue/Domain/List.vue

Loading...
View Options

src/resources/vue/File/Info.vue

Loading...
View Options

src/resources/vue/File/List.vue

Loading...
View Options

src/resources/vue/Login.vue

Loading...
View Options

src/resources/vue/Meet/Room.vue

Loading...
View Options

src/resources/vue/PasswordReset.vue

Loading...
View Options

src/resources/vue/Reseller/Dashboard.vue

Loading...
View Options

src/resources/vue/Reseller/Invitations.vue

Loading...
View Options

src/resources/vue/Resource/Info.vue

Loading...
View Options

src/resources/vue/Resource/List.vue

Loading...
View Options

src/resources/vue/SharedFolder/Info.vue

Loading...
View Options

src/resources/vue/SharedFolder/List.vue

Loading...
View Options

src/resources/vue/Signup.vue

Loading...
View Options

src/resources/vue/User/Info.vue

Loading...
View Options

src/resources/vue/User/Profile.vue

Loading...
View Options

src/resources/vue/User/ProfileDelete.vue

Loading...
View Options

src/resources/vue/Wallet.vue

Loading...
View Options

src/resources/vue/Widgets/AclInput.vue

Loading...
View Options

src/resources/vue/Widgets/CompanionappList.vue

Loading...
View Options

src/resources/vue/Widgets/ListInput.vue

Loading...
View Options

src/resources/vue/Widgets/ListTools.vue

Loading...
View Options

src/resources/vue/Widgets/PackageSelect.vue

Loading...
View Options

src/resources/vue/Widgets/Status.vue

Loading...
View Options

src/resources/vue/Widgets/StatusMessage.vue

Loading...
View Options

src/resources/vue/Widgets/SubscriptionSelect.vue

Loading...
View Options

src/resources/vue/Widgets/ToastMessage.vue

Loading...
View Options

src/resources/vue/Widgets/TransactionLog.vue

Loading...
View Options

src/resources/vue/Widgets/UserSearch.vue

Loading...