Differential D3190

Python 3 compatibility
AbandonedPublic
Actions

Authored by sicherha on Jan 6 2022, 11:37 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 4, 8:58 AM

	Unknown Object (File)
	Wed, Sep 11, 6:26 AM

	Unknown Object (File)
	Sep 7 2024, 5:48 AM

	Unknown Object (File)
	Sep 7 2024, 4:33 AM

	Unknown Object (File)
	Sep 4 2024, 9:47 PM

	Unknown Object (File)
	Sep 4 2024, 8:37 PM

	Unknown Object (File)
	Sep 1 2024, 4:51 PM

	Unknown Object (File)
	Aug 25 2024, 11:06 AM

View All 94 Files

Subscribers

None

Details

Reviewers

Summary

These commits are a first step towards making pykolab compatible with Python 3 while still maintaining compatibility with Python 2.6.

Test Plan

Review thoroughly, then try out on a test system (unsatisfactory, I know).

Diff Detail

Repository

Branch

master

Lint

Lint Errors

Severity	Location	Code	Message
Error	cyruslib.py:45	E203	PEP8 E203
Error	cyruslib.py:46	E203	PEP8 E203
Error	cyruslib.py:47	E203	PEP8 E203
Error	cyruslib.py:50	E203	PEP8 E203
Error	cyruslib.py:78	E701	PEP8 E701
Error	cyruslib.py:90	E701	PEP8 E701
Error	cyruslib.py:109	E701	PEP8 E701
Error	cyruslib.py:403	E701	PEP8 E701
Error	cyruslib.py:514	E701	PEP8 E701
Error	cyruslib.py:531	E701	PEP8 E701
Error	cyruslib.py:533	E701	PEP8 E701
Error	cyruslib.py:802	E701	PEP8 E701
Error	cyruslib.py:816	E701	PEP8 E701
Error	cyruslib.py:818	E701	PEP8 E701
Error	ext/python/Tools/freeze/checkextensions_win32.py:25	E401	PEP8 E401
Error	ext/python/Tools/freeze/checkextensions_win32.py:49	E301	PEP8 E301
Error	ext/python/Tools/freeze/checkextensions_win32.py:54	E301	PEP8 E301
Error	ext/python/Tools/freeze/checkextensions_win32.py:70	E115	PEP8 E115
Error	ext/python/Tools/freeze/checkextensions_win32.py:73	E115	PEP8 E115
Error	ext/python/Tools/freeze/checkextensions_win32.py:83	E701	PEP8 E701
Error	ext/python/Tools/freeze/checkextensions_win32.py:128	E115	PEP8 E115
Error	ext/python/Tools/freeze/checkextensions_win32.py:147	E211	PEP8 E211
Error	ext/python/Tools/freeze/checkextensions_win32.py:154	E211	PEP8 E211
Error	ext/python/Tools/freeze/checkextensions_win32.py:159	E211	PEP8 E211
Error	ext/python/Tools/freeze/freeze.py:126	E701	PEP8 E701

Unit

No Test Coverage

Build Status

Buildable 37687
Build 15148: arc lint + arc unit

Event Timeline

sicherha requested review of this revision.Jan 6 2022, 11:37 AM

sicherha created this revision.

Harbormaster completed remote builds in B37687: Diff 9124.Jan 6 2022, 11:37 AM

Harbormaster completed remote builds in B37687: Diff 9124.

sicherha mentioned this in T6805: Port pykolab to Python 3.Jan 6 2022, 11:43 AM

Superseded by D3223, D3226, D3229, D3232, D3235, D3241 and D3244.

Large Diff

This large diff affects 117 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

bin/

kolab_smtp_access_policy.py

6 lines

8 lines

34 lines

ext/

python/

Tools/

freeze/

checkextensions.py

6 lines

checkextensions_win32.py

2 lines

28 lines

2 lines

4 lines

4 lines

12 lines

winmakemakefile.py

126 lines

8 lines

kolabd/

4 lines

pykolab/

auth/

ldap/

16 lines

6 lines

cli/

6 lines

cmd_acl_cleanup.py

6 lines

cmd_add_alias.py

30 lines

cmd_add_domain.py

2 lines

cmd_add_user_subscription.py

12 lines

cmd_check_quota.py

10 lines

cmd_count_domain_mailboxes.py

6 lines

cmd_create_mailbox.py

2 lines

cmd_delete_domain.py

2 lines

cmd_delete_mailbox.py

10 lines

cmd_delete_mailbox_acl.py

8 lines

cmd_export_mailbox.py

6 lines

cmd_find_domain.py

2 lines

cmd_list_deleted_mailboxes.py

6 lines

cmd_list_domain_mailboxes.py

6 lines

cmd_list_domains.py

10 lines

cmd_list_mailbox_acls.py

12 lines

cmd_list_mailbox_metadata.py

16 lines

cmd_list_mailboxes.py

4 lines

cmd_list_messages.py

12 lines

cmd_list_ous.py

2 lines

cmd_list_quota.py

32 lines

cmd_list_user_subscriptions.py

14 lines

cmd_list_users.py

2 lines

cmd_mailbox_cleanup.py

10 lines

cmd_remove_mailaddress.py

10 lines

cmd_remove_user_subscription.py

22 lines

cmd_rename_mailbox.py

16 lines

cmd_server_info.py

2 lines

cmd_set_mailbox_acl.py

10 lines

cmd_set_mailbox_metadata.py

10 lines

cmd_set_quota.py

10 lines

2 lines

cmd_sync_mailhost_attrs.py

10 lines

cmd_user_info.py

12 lines

36 lines

sieve/

8 lines

22 lines

18 lines

telemetry/

cmd_examine_command_issue.py

14 lines

cmd_examine_session.py

10 lines

cmd_list_sessions.py

4 lines

wap/

cmd_system_capabilities.py

10 lines

cmd_user_types_list.py

2 lines

conf/

12 lines

34 lines

constants.py.in

2 lines

imap/

18 lines

26 lines

8 lines

2 lines

2 lines

plugins/

20 lines

defaultfolders/

4 lines

dynamicquota/

2 lines

recipientpolicy/

24 lines

roundcubedb/

2 lines

sievemgmt/

24 lines

setup/

2 lines

36 lines

setup_freebusy.py

6 lines

56 lines

6 lines

16 lines

5 lines

setup_roundcube.py

12 lines

setup_syncroton.py

8 lines

2 lines

18 lines

6 lines

wap_client/

68 lines

xml/

34 lines

26 lines

contact_reference.py

2 lines

90 lines

14 lines

recurrence_rule.py

16 lines

24 lines

26 lines

8 lines

saslauthd/

33 lines

8 lines

tests/

functional/

resource_func.py

6 lines

test_kolabd/

test_001_user_sync.py

6 lines

test_002_user_rename.py

4 lines

test_wallace/

test_002_footer.py

2 lines

test_006_resource_performance.py

4 lines

test_wap_client/

test_002_user_add.py

6 lines

test_003_user_add_fr_FR.py

2 lines

6 lines

unit/

test-002-attendee.py

48 lines

test-003-event.py

24 lines

test-008-sievelib.py

2 lines

ucs/

6 lines

6 lines

8 lines

wallace/

module_gpgencrypt.py

4 lines

module_invitationpolicy.py

62 lines

module_optout.py

12 lines

module_resources.py

2 lines

module_signature.py

2 lines

8 lines

Diff 9124

bin/kolab_smtp_access_policy.py

conf.py

cyruslib.py

ext/python/Tools/freeze/checkextensions.py

ext/python/Tools/freeze/checkextensions_win32.py

ext/python/Tools/freeze/freeze.py

ext/python/Tools/freeze/hello.py

ext/python/Tools/freeze/makeconfig.py

ext/python/Tools/freeze/makefreeze.py

ext/python/Tools/freeze/parsesetup.py

ext/python/Tools/freeze/winmakemakefile.py

kolab-cli.py

kolabd/init.py

pykolab/auth/ldap/init.py

pykolab/auth/ldap/syncrepl.py

pykolab/cli/init.py

pykolab/cli/cmd_acl_cleanup.py

pykolab/cli/cmd_add_alias.py

pykolab/cli/cmd_add_domain.py

pykolab/cli/cmd_add_user_subscription.py

pykolab/cli/cmd_check_quota.py

pykolab/cli/cmd_count_domain_mailboxes.py

pykolab/cli/cmd_create_mailbox.py

pykolab/cli/cmd_delete_domain.py

pykolab/cli/cmd_delete_mailbox.py

pykolab/cli/cmd_delete_mailbox_acl.py

pykolab/cli/cmd_export_mailbox.py

pykolab/cli/cmd_find_domain.py

pykolab/cli/cmd_list_deleted_mailboxes.py

pykolab/cli/cmd_list_domain_mailboxes.py

pykolab/cli/cmd_list_domains.py

pykolab/cli/cmd_list_mailbox_acls.py

pykolab/cli/cmd_list_mailbox_metadata.py

pykolab/cli/cmd_list_mailboxes.py

pykolab/cli/cmd_list_messages.py

pykolab/cli/cmd_list_ous.py

pykolab/cli/cmd_list_quota.py

pykolab/cli/cmd_list_user_subscriptions.py

pykolab/cli/cmd_list_users.py

pykolab/cli/cmd_mailbox_cleanup.py

pykolab/cli/cmd_remove_mailaddress.py

pykolab/cli/cmd_remove_user_subscription.py

pykolab/cli/cmd_rename_mailbox.py

pykolab/cli/cmd_server_info.py

pykolab/cli/cmd_set_mailbox_acl.py

pykolab/cli/cmd_set_mailbox_metadata.py

pykolab/cli/cmd_set_quota.py

pykolab/cli/cmd_sync.py

pykolab/cli/cmd_sync_mailhost_attrs.py

pykolab/cli/cmd_user_info.py

pykolab/cli/commands.py

pykolab/cli/sieve/cmd_list.py

pykolab/cli/sieve/cmd_refresh.py

pykolab/cli/sieve/cmd_test.py

pykolab/cli/telemetry/cmd_examine_command_issue.py

pykolab/cli/telemetry/cmd_examine_session.py

pykolab/cli/telemetry/cmd_list_sessions.py

pykolab/cli/wap/cmd_system_capabilities.py

pykolab/cli/wap/cmd_user_types_list.py

pykolab/conf/init.py

pykolab/conf/entitlement.py

pykolab/constants.py.in

pykolab/imap/init.py

pykolab/imap/cyrus.py

pykolab/imap/dovecot.py

pykolab/imap_utf7.py

pykolab/logger.py

pykolab/plugins/init.py

pykolab/plugins/defaultfolders/init.py

pykolab/plugins/dynamicquota/init.py

pykolab/plugins/recipientpolicy/init.py

pykolab/plugins/roundcubedb/init.py

pykolab/plugins/sievemgmt/init.py

pykolab/setup/init.py

pykolab/setup/components.py

pykolab/setup/setup_freebusy.py

pykolab/setup/setup_ldap.py

pykolab/setup/setup_mta.py

pykolab/setup/setup_mysql.py

pykolab/setup/setup_php.py

pykolab/setup/setup_roundcube.py

pykolab/setup/setup_syncroton.py

pykolab/telemetry.py

pykolab/translit.py

pykolab/utils.py

pykolab/wap_client/init.py

pykolab/xml/attendee.py

pykolab/xml/contact.py

pykolab/xml/contact_reference.py

pykolab/xml/event.py

pykolab/xml/note.py

pykolab/xml/recurrence_rule.py

pykolab/xml/todo.py

pykolab/xml/utils.py

saslauthd.py

saslauthd/init.py

setup-kolab.py

tests/functional/resource_func.py

tests/functional/test_kolabd/test_001_user_sync.py

tests/functional/test_kolabd/test_002_user_rename.py

tests/functional/test_wallace/test_002_footer.py

tests/functional/test_wallace/test_006_resource_performance.py

tests/functional/test_wap_client/test_002_user_add.py

tests/functional/test_wap_client/test_003_user_add_fr_FR.py

tests/functional/user_add.py

tests/unit/test-002-attendee.py

tests/unit/test-003-event.py

tests/unit/test-008-sievelib.py

ucs/kolab_sieve.py

ucs/listener.py

wallace.py

wallace/module_gpgencrypt.py

wallace/module_invitationpolicy.py

wallace/module_optout.py

wallace/module_resources.py

wallace/module_signature.py

wallace/modules.py