Page MenuHomePhorge

Publisher-to-subscriber and vice-versa
ClosedPublic

Authored by machniak on Jan 21 2021, 3:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 29, 6:54 PM
Unknown Object (File)
Wed, Feb 28, 2:42 AM
Unknown Object (File)
Fri, Feb 23, 2:06 PM
Unknown Object (File)
Tue, Feb 20, 12:28 PM
Unknown Object (File)
Thu, Feb 15, 8:23 AM
Unknown Object (File)
Sat, Feb 10, 1:23 AM
Unknown Object (File)
Jan 31 2024, 7:42 PM
Unknown Object (File)
Jan 30 2024, 10:12 PM
Subscribers
Restricted Project

Details

Summary
  • Added Permissions section in the user options dropdown
  • Use proper event system to handle audio/video status indication
  • Add "Nickname" item to the participant options menu
  • Code improvements
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/openvidu-pub-to-sub-demote
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 32878
Build 12778: arc lint + arc unit

Event Timeline

machniak created this revision.
  • Cleanup
  • Simplify resize() calls
  • More tests
  • Test updateConnection endpoint
  • Add tests for media setup dialog

I've found one issue. The role change is not propagated to new connections. Scenario:

  1. User1 joins as a subscriber
  2. Moderator promotes him to a publisher
  3. User2 joins and sees a UI issue, because the User1 tail is a subscriber-like tile, and there's a video element of User1 "out of the matrix".
  • Cleanup
  • Simplify resize() calls
  • More tests
  • Test updateConnection endpoint
  • Media setup dialog
  • Fix test regressions
  • Add tests for media setup dialog
  • Fix connection role propagation to new connections
This revision is now accepted and ready to land.Feb 2 2021, 11:42 AM
This revision was automatically updated to reflect the committed changes.