Page MenuHomekolab.org

Publisher-to-subscriber and vice-versa
ClosedPublic

Authored by machniak on Jan 21 2021, 3:21 PM.

Details

Summary
  • Added Permissions section in the user options dropdown
  • Use proper event system to handle audio/video status indication
  • Add "Nickname" item to the participant options menu
  • Code improvements
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/openvidu-pub-to-sub-demote
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 32821
Build 12730: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Jan 21 2021, 3:21 PM
machniak created this revision.
machniak updated this revision to Diff 5947.Jan 22 2021, 11:00 AM
  • Cleanup
  • Simplify resize() calls
  • More tests
  • Test updateConnection endpoint
machniak updated this revision to Diff 5992.Jan 26 2021, 11:34 AM
  • Media setup dialog
machniak updated this revision to Diff 5998.Jan 26 2021, 11:53 AM
  • Fix test regressions
machniak updated this revision to Diff 6004.Jan 26 2021, 12:31 PM
  • Add tests for media setup dialog
machniak planned changes to this revision.Jan 26 2021, 1:15 PM

I've found one issue. The role change is not propagated to new connections. Scenario:

  1. User1 joins as a subscriber
  2. Moderator promotes him to a publisher
  3. User2 joins and sees a UI issue, because the User1 tail is a subscriber-like tile, and there's a video element of User1 "out of the matrix".
machniak updated this revision to Diff 6061.Jan 27 2021, 12:19 PM
  • Cleanup
  • Simplify resize() calls
  • More tests
  • Test updateConnection endpoint
  • Media setup dialog
  • Fix test regressions
  • Add tests for media setup dialog
  • Fix connection role propagation to new connections
vanmeeuwen accepted this revision.Feb 2 2021, 11:42 AM
This revision is now accepted and ready to land.Feb 2 2021, 11:42 AM
This revision was automatically updated to reflect the committed changes.