Page MenuHomekolab.org

Do not set the active status until after the ownership of or management access to has been confirmed.
ClosedPublic

Authored by vanmeeuwen on Oct 6 2020, 10:22 AM.

Details

Summary

When the domain is confirmed, we also know it to exist in DNS, even if verify() fails.

Only when the domain is confirmed and verified, do we set the active status

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vanmeeuwen requested review of this revision.Oct 6 2020, 10:22 AM
vanmeeuwen created this revision.
vanmeeuwen added a reviewer: Restricted Project.Oct 6 2020, 10:22 AM
vanmeeuwen added a subscriber: Restricted Project.
vanmeeuwen updated this revision to Diff 4558.Oct 6 2020, 10:24 AM
  • Actually, any active domain is definitely no longer new
vanmeeuwen updated this revision to Diff 4564.Oct 6 2020, 10:36 AM
  • Test for active/new before subtracting active/new
machniak added inline comments.
src/app/Domain.php
259

You don't really need this if, just use the else code.

vanmeeuwen updated this revision to Diff 4570.Oct 6 2020, 10:59 AM
  • Simply the bitflip addition code
vanmeeuwen marked an inline comment as done.Oct 6 2020, 11:02 AM
vanmeeuwen updated this revision to Diff 4582.Oct 6 2020, 4:32 PM
  • Adjust and enhance tests
vanmeeuwen updated this revision to Diff 4630.Oct 9 2020, 12:05 PM
  • Fix typo
  • Add Functional as a test suite
  • Add at least one functional test
  • If a domain was verified and confirmed before it was suspended, we need to restore the active state.
  • Improve legibility of this exception
  • Clarify why we can activate a domain in unsuspend, provided the right conditions
  • Also verify we can unsuspend a domain that was verified but unconfirmed, without setting the status to active.
  • Merge remote-tracking branch 'origin/master' into arcpatch-D1708
vanmeeuwen updated this revision to Diff 4636.Oct 9 2020, 12:12 PM
  • No need for return statement here
machniak accepted this revision.Oct 9 2020, 12:56 PM
This revision is now accepted and ready to land.Oct 9 2020, 12:56 PM
This revision was automatically updated to reflect the committed changes.