Page MenuHomePhorge

Do not set the active status until after the ownership of or management access to has been confirmed.
ClosedPublic

Authored by vanmeeuwen on Oct 6 2020, 10:22 AM.
Tags
None
Referenced Files
F11587056: D1708.id4630.diff
Thu, Mar 28, 4:30 PM
F11586045: D1708.id4570.diff
Thu, Mar 28, 1:45 PM
Unknown Object (File)
Thu, Mar 7, 6:51 AM
Unknown Object (File)
Sat, Mar 2, 10:08 PM
Unknown Object (File)
Feb 11 2024, 8:20 PM
Unknown Object (File)
Feb 9 2024, 7:55 PM
Unknown Object (File)
Feb 8 2024, 8:32 PM
Unknown Object (File)
Feb 4 2024, 6:51 PM
Subscribers
Restricted Project

Details

Summary

When the domain is confirmed, we also know it to exist in DNS, even if verify() fails.

Only when the domain is confirmed and verified, do we set the active status

Diff Detail

Repository
rK kolab
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 31159
Build 11713: arc lint + arc unit

Event Timeline

vanmeeuwen created this revision.
vanmeeuwen added a reviewer: Restricted Project.Oct 6 2020, 10:22 AM
vanmeeuwen added a subscriber: Restricted Project.
  • Actually, any active domain is definitely no longer new
  • Test for active/new before subtracting active/new
machniak added inline comments.
src/app/Domain.php
259

You don't really need this if, just use the else code.

  • Simply the bitflip addition code
  • Fix typo
  • Add Functional as a test suite
  • Add at least one functional test
  • If a domain was verified and confirmed before it was suspended, we need to restore the active state.
  • Improve legibility of this exception
  • Clarify why we can activate a domain in unsuspend, provided the right conditions
  • Also verify we can unsuspend a domain that was verified but unconfirmed, without setting the status to active.
  • Merge remote-tracking branch 'origin/master' into arcpatch-D1708
  • No need for return statement here
This revision is now accepted and ready to land.Oct 9 2020, 12:56 PM
This revision was automatically updated to reflect the committed changes.