When the domain is confirmed, we also know it to exist in DNS, even if verify() fails.
Only when the domain is confirmed and verified, do we set the active status
Details
Details
- Reviewers
machniak - Group Reviewers
Restricted Project - Commits
- rKbe57ffd52035: Do not set the active status until after the ownership of or management access…
Diff Detail
Diff Detail
- Repository
- rK kolab
- Branch
- arcpatch-D1708
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 31228 Build 11779: arc lint + arc unit
Event Timeline
| src/app/Domain.php | ||
|---|---|---|
| 259 | You don't really need this if, just use the else code. | |
Comment Actions
- Fix typo
- Add Functional as a test suite
- Add at least one functional test
- If a domain was verified and confirmed before it was suspended, we need to restore the active state.
- Improve legibility of this exception
- Clarify why we can activate a domain in unsuspend, provided the right conditions
- Also verify we can unsuspend a domain that was verified but unconfirmed, without setting the status to active.
- Merge remote-tracking branch 'origin/master' into arcpatch-D1708