HomePhorge

Fix posix exec provider spec failures on Windows
2681ca536042Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix posix exec provider spec failures on Windows

These specs were assuming that paths such as /foo were always absolute, which
is not the case on Windows. Thus, when run on Windows, the provider was
complaining about receiving relative paths when it expected absolute, rather
than succeeding or failing in the intended way. Now we expand all paths we want
to be absolute, to guarantee they will be absolute everywhere.

Also, some specs were failing because they were trying to test the case where a
file isn't executable. That's not something we can reliably check on Windows,
so instead just stub the appropriate executable? methods.

Reviewed-By: Matt Robinson <matt@puppetlabs.com>
(cherry picked from commit e9b558dd35eec6e221aef9de3f300a5843347454)

Details

Provenance
Nick Lewis <nick@puppetlabs.com>Authored on
Jacob Helwig <jacob@puppetlabs.com>Committed on Aug 19 2011, 10:52 PM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU3812fc35eae9: (#5495) Remove dead Windows-specific code from posix exec provider
Branches
Unknown
Tags
Unknown

Event Timeline

Jacob Helwig <jacob@puppetlabs.com> committed rPU2681ca536042: Fix posix exec provider spec failures on Windows (authored by Nick Lewis <nick@puppetlabs.com>).Aug 19 2011, 10:52 PM