HomePhorge

Fix posix exec provider spec failures on Windows
e9b558dd35eeUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix posix exec provider spec failures on Windows

These specs were assuming that paths such as /foo were always absolute, which
is not the case on Windows. Thus, when run on Windows, the provider was
complaining about receiving relative paths when it expected absolute, rather
than succeeding or failing in the intended way. Now we expand all paths we want
to be absolute, to guarantee they will be absolute everywhere.

Also, some specs were failing because they were trying to test the case where a
file isn't executable. That's not something we can reliably check on Windows,
so instead just stub the appropriate executable? methods.

Reviewed-By: Matt Robinson <matt@puppetlabs.com>

Details

Provenance
Nick Lewis <nick@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUb28bcb031346: (#5495) Remove dead Windows-specific code from posix exec provider
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Lewis <nick@puppetlabs.com> committed rPUe9b558dd35ee: Fix posix exec provider spec failures on Windows (authored by Nick Lewis <nick@puppetlabs.com>).Aug 16 2011, 9:45 PM