HomePhorge

(#5495) Remove dead Windows-specific code from posix exec provider
3812fc35eae9Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#5495) Remove dead Windows-specific code from posix exec provider

Because this provider only applies when the posix feature is present (and thus
not the windows feature), it can never be used on Windows. Thus, the
Windows-specific command handling is unnecessary and unused.

Also added more specific error messages for the cases where a command doesn't
exist, isn't a file, and isn't executable. These only apply when the command
path is absolute (otherwise the message is simply command not found).

Reviewed-By: Matt Robinson <matt@puppetlabs.com>
(cherry picked from commit b28bcb031346cfd2026361ec5ffb420c1dcf60d7)

Conflicts:

spec/unit/provider/exec/posix_spec.rb

Details

Provenance
Nick Lewis <nick@puppetlabs.com>Authored on
Jacob Helwig <jacob@puppetlabs.com>Committed on Aug 19 2011, 10:52 PM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUb6ca78cc8d28: Stop trying to make config directories in Windows specs
Branches
Unknown
Tags
Unknown

Event Timeline

Jacob Helwig <jacob@puppetlabs.com> committed rPU3812fc35eae9: (#5495) Remove dead Windows-specific code from posix exec provider (authored by Nick Lewis <nick@puppetlabs.com>).Aug 19 2011, 10:52 PM