Page MenuHomePhorge
Feed All Stories

Jul 3 2025

machniak accepted D5430: Sleep when a client keeps resending the same FolderSync request..
Jul 3 2025, 8:08 AM
mollekopf requested review of D5442: Ping retry counter.
Jul 3 2025, 8:05 AM
mollekopf requested review of D5439: Make sure we always get the correct data for a FolderSync..
Jul 3 2025, 8:05 AM
mollekopf requested review of D5436: flat_mode for kolab4.
Jul 3 2025, 8:05 AM
mollekopf updated the diff for D5430: Sleep when a client keeps resending the same FolderSync request..

Return a 503 and sleep, because the 503 doesn't actually seem to stop the client.

Jul 3 2025, 8:05 AM

Jul 2 2025

machniak requested review of D5433: Make sure that user data is deleted in user:force-delete command.
Jul 2 2025, 1:19 PM
mollekopf added inline comments to D5430: Sleep when a client keeps resending the same FolderSync request..
Jul 2 2025, 12:09 PM
machniak added inline comments to D5430: Sleep when a client keeps resending the same FolderSync request..
Jul 2 2025, 12:00 PM
mollekopf added a comment to D5430: Sleep when a client keeps resending the same FolderSync request..

If we assume 1 request per device per second and an average execution time of 1s, then we'd reduce our capacity by ~11 by making all requests take 11s, because all processing slots in php-fpm will be occupied.
So while this should work well for protecting e.g. imap from getting overloaded, we may introduce another bottleneck....

Jul 2 2025, 11:28 AM
mollekopf added a reviewer for D5430: Sleep when a client keeps resending the same FolderSync request.: Syncroton Developers.
Jul 2 2025, 11:20 AM
mollekopf requested review of D5430: Sleep when a client keeps resending the same FolderSync request..
Jul 2 2025, 11:18 AM
machniak added a comment to D5427: Slim down number of wallet check jobs.

This may not be a big win because non-owner users do have meet room entitlements in their wallets. Hopefully abusers never visited the Video chat page in dashboard, i.e. the entitlement wasn't created for them.

Jul 2 2025, 10:38 AM
machniak committed rK0d614824b30c: Skip shared folders namespace in IMAP::unshareFolders().
Jul 2 2025, 10:32 AM
machniak committed rK16c1906f1922: Fix Roundcube::createDelegatedIdentities() so it does not create duplicates.
Jul 2 2025, 10:14 AM
machniak committed rRPK4cbdc933cdb0: Calendar: Don't display errors in UI if freebusy is disabled.
Jul 2 2025, 8:52 AM
machniak committed rRPK7681c16dde02: Kolab: Fix setting a delegation context for an invitation message.
Jul 2 2025, 8:32 AM

Jul 1 2025

mollekopf committed rRPKbb7e211d1b46: Outlook can't deal with Spam or Junk Email re-enabled either..
Jul 1 2025, 2:49 PM
machniak updated the diff for D5427: Slim down number of wallet check jobs.
  • Fix test regression
Jul 1 2025, 11:11 AM
machniak requested review of D5427: Slim down number of wallet check jobs.
Jul 1 2025, 10:53 AM
mollekopf committed rRPK094ea588671c: Anchor the pattern os we don't match subfolders if we don't intend to.
Jul 1 2025, 10:03 AM
machniak requested review of D5424: Add `user:resync --deleted-only` to the schedule.
Jul 1 2025, 9:23 AM
mollekopf closed D5421: Debug message to explain why a change has been detected.
Jul 1 2025, 8:50 AM
mollekopf closed D5418: Count FolderSync retries, and warn after 10 failures.
Jul 1 2025, 8:50 AM
mollekopf committed rS149185894023: Count FolderSync retries, and warn after 10 failures.
Jul 1 2025, 8:50 AM
mollekopf committed rS59e08a3f0c8f: Debug message to explain why a change has been detected.
Jul 1 2025, 8:50 AM
mollekopf committed rSfebdd60e334e: php8 compat.
Jul 1 2025, 8:50 AM
mollekopf committed rS092430556bc7: Test activesync_force_subscriptions.
Jul 1 2025, 8:50 AM
machniak closed D5412: Allow distribution list creation for email that existed before.
Jul 1 2025, 8:03 AM
machniak committed rKe77a421f6699: Allow distribution list creation for email that existed before.
Jul 1 2025, 8:03 AM
machniak closed D5409: Silently exit a job on "object already deleted" case, unify behvior across all jobs.
Jul 1 2025, 8:03 AM
machniak committed rKaff681f9686d: Silently exit a job on "object already deleted" case, unify behvior across all….
Jul 1 2025, 8:03 AM
machniak closed D5403: Password expiration.
Jul 1 2025, 8:03 AM
machniak closed D5415: Add support for --with-deleted option in scalpel:*:read commands.
Jul 1 2025, 8:03 AM
machniak committed rK09867f493e1f: Add support for --with-deleted option in scalpel:*:read commands.
Jul 1 2025, 8:03 AM
machniak committed rK51913a95f935: Password expiration.
Jul 1 2025, 8:03 AM
machniak accepted D5421: Debug message to explain why a change has been detected.
Jul 1 2025, 5:11 AM
machniak accepted D5418: Count FolderSync retries, and warn after 10 failures.

Probably 5 instead of 10 would be enough.

Jul 1 2025, 5:11 AM

Jun 30 2025

mollekopf accepted D5409: Silently exit a job on "object already deleted" case, unify behvior across all jobs.
Jun 30 2025, 7:43 PM
mollekopf updated the diff for D5421: Debug message to explain why a change has been detected.

Ensure we match servids and not parent ids.

Jun 30 2025, 7:13 PM
mollekopf updated the diff for D5418: Count FolderSync retries, and warn after 10 failures.

Initial log message as info, cleanup of the counterNext situation

Jun 30 2025, 7:06 PM
mollekopf closed D5406: activesync_force_subscriptionstate support.
Jun 30 2025, 7:04 PM
mollekopf committed rRPK66c3a62aef58: Support for activesync_force_subscriptions.
Jun 30 2025, 7:04 PM
mollekopf added inline comments to D5418: Count FolderSync retries, and warn after 10 failures.
Jun 30 2025, 6:37 PM
mollekopf added inline comments to D5418: Count FolderSync retries, and warn after 10 failures.
Jun 30 2025, 6:34 PM
machniak requested changes to D5418: Count FolderSync retries, and warn after 10 failures.
Jun 30 2025, 4:22 PM
machniak requested changes to D5421: Debug message to explain why a change has been detected.
Jun 30 2025, 4:04 PM
machniak accepted D5406: activesync_force_subscriptionstate support.
Jun 30 2025, 3:59 PM
mollekopf accepted D5412: Allow distribution list creation for email that existed before.

Looks like it's at least the same logic as before.

Jun 30 2025, 3:49 PM
mollekopf added inline comments to D5412: Allow distribution list creation for email that existed before.
Jun 30 2025, 3:40 PM
mollekopf accepted D5403: Password expiration.
Jun 30 2025, 3:35 PM
mollekopf accepted D5415: Add support for --with-deleted option in scalpel:*:read commands.
Jun 30 2025, 3:33 PM
mollekopf added a reviewer for D5418: Count FolderSync retries, and warn after 10 failures: Syncroton Developers.

This will turn a read-only operation into an UPDATE query, and the getting the abstraction lasagna to execute the update query is fairly messy, but I suppose it's still worth it unless there's a better approach.

Jun 30 2025, 3:19 PM
mollekopf added a reviewer for D5421: Debug message to explain why a change has been detected: Syncroton Developers.

Makes it a lot easier to see what's happening.

Jun 30 2025, 3:17 PM
mollekopf requested review of D5421: Debug message to explain why a change has been detected.
Jun 30 2025, 3:15 PM
mollekopf requested review of D5418: Count FolderSync retries, and warn after 10 failures.
Jun 30 2025, 3:10 PM
mollekopf updated the diff for D5406: activesync_force_subscriptionstate support.

Merge the two config options

Jun 30 2025, 3:01 PM
machniak committed rKd1fbb62e3571: Fix labels order on the All Users chart.
Jun 30 2025, 1:14 PM
mollekopf committed rK1902738c64a3: Make sure we have a valid php.ini during build.
Jun 30 2025, 11:54 AM
mollekopf committed rK3d1c1f771385: Make sure we have activesync_storage set for tests.
Jun 30 2025, 11:54 AM
mollekopf committed rK8e3649cf59fd: null and not having the entry is not the same.
Jun 30 2025, 11:54 AM
mollekopf committed rKbab92f6ac1b1: Fixed database seed.
Jun 30 2025, 11:54 AM
machniak requested review of D5415: Add support for --with-deleted option in scalpel:*:read commands.
Jun 30 2025, 9:52 AM

Jun 27 2025

machniak committed rRPK3babbf5d5ace: Fix phpunit.xml.
Jun 27 2025, 12:49 PM
machniak committed rRPKf1c621911716: Kolab: Add X-Client-IP header to the Cockpit API requests.
Jun 27 2025, 12:38 PM
machniak added a comment to D5406: activesync_force_subscriptionstate support.

We already have $config['activesync_force_subscriptions'] in the kolab_activesync plugin. It would make sense to de-duplicate.

How do we deduplicate accross plugin boundaries?

Jun 27 2025, 11:38 AM
mollekopf added a comment to D5406: activesync_force_subscriptionstate support.

We already have $config['activesync_force_subscriptions'] in the kolab_activesync plugin. It would make sense to de-duplicate.

Jun 27 2025, 11:32 AM
machniak committed rK8e9c5f28a6d8: Add missing test user cleanup.
Jun 27 2025, 10:24 AM
machniak requested review of D5412: Allow distribution list creation for email that existed before.
Jun 27 2025, 9:54 AM
machniak added a comment to D5406: activesync_force_subscriptionstate support.

We already have $config['activesync_force_subscriptions'] in the kolab_activesync plugin. It would make sense to de-duplicate.

Jun 27 2025, 9:01 AM
machniak requested review of D5409: Silently exit a job on "object already deleted" case, unify behvior across all jobs.
Jun 27 2025, 7:40 AM

Jun 26 2025

mollekopf added a comment to D5406: activesync_force_subscriptionstate support.

My outlook is in a state where enabling the Calendar will break FolderSync because of the Add, but disabling the Calendar will result in a sync loop via Ping because the Calendar is not available.

Jun 26 2025, 3:48 PM
mollekopf added a comment to D5406: activesync_force_subscriptionstate support.

I think a problem with this will be that if you have an existing outlook, but the Calendar has been disabled on the server, then enabling it will trigger an "Add" for the Calendar, which Outlook doesn't like, so I'm not sure how to reconcile that.
Perhaps we need to suppress the Add for folders that are supposed to be always enabled.

Jun 26 2025, 3:46 PM
mollekopf added a reviewer for D5406: activesync_force_subscriptionstate support: Roundcube Kolab Plugins Developers.

Tested via test in syncroton repository where I nuke all subscriptions and make sure we still get the expected default folders in FolderSync.

Jun 26 2025, 3:33 PM
mollekopf requested review of D5406: activesync_force_subscriptionstate support.
Jun 26 2025, 3:32 PM
machniak closed D5400: Stats: Added 'suspended' line on the All users chart.
Jun 26 2025, 1:30 PM
machniak closed D5397: Performance: Optimize User::wallet() and Domain::users().
Jun 26 2025, 1:30 PM
machniak closed D5394: Performance: Introduce mutable version of walletOwner().
Jun 26 2025, 1:30 PM
machniak committed rK08443288e0cf: Performance: Introduce mutable version of walletOwner().
Jun 26 2025, 1:30 PM
machniak committed rK4d4a066daa39: Performance: Optimize User::wallet() and Domain::users().
Jun 26 2025, 1:30 PM
machniak committed rK761b1d680948: Stats: Added 'suspended' line on the All users chart.
Jun 26 2025, 1:30 PM
machniak updated the diff for D5403: Password expiration.
  • Reset password only after full authentication
  • Wording
Jun 26 2025, 1:10 PM
machniak updated the diff for D5403: Password expiration.
  • Revert possibility to check password policy using email address
Jun 26 2025, 7:02 AM

Jun 25 2025

machniak updated the diff for D5403: Password expiration.
  • Move checks into the SQL query
Jun 25 2025, 2:12 PM
mollekopf committed rK70fbc9b7dbdd: Option to enable proxy protocol support.
Jun 25 2025, 2:12 PM
mollekopf committed rK4356f2b9f436: Custom swoole php.ini to configure the memory limit.
Jun 25 2025, 2:12 PM
mollekopf committed rKe26507c7fa2f: Configurable postfix message size limit.
Jun 25 2025, 2:12 PM
mollekopf committed rK2a87e8118621: Log request failures.
Jun 25 2025, 2:12 PM
mollekopf committed rKb039615a4745: Attachment support for mailtransporttest.
Jun 25 2025, 2:12 PM
mollekopf committed rK9040c302f2a3: Configurable swoole concurrency.
Jun 25 2025, 2:12 PM
mollekopf committed rK9dd84834916c: Log roundcube request durations.
Jun 25 2025, 2:12 PM
mollekopf committed rK59150120c9af: Only pin refs if not already specified.
Jun 25 2025, 2:12 PM
mollekopf committed rKccfb2b0b9e46: Set the dav cache to redis.
Jun 25 2025, 2:12 PM
machniak requested review of D5403: Password expiration.
Jun 25 2025, 1:29 PM

Jun 23 2025

mollekopf accepted D5394: Performance: Introduce mutable version of walletOwner().
Jun 23 2025, 7:40 PM
mollekopf accepted D5400: Stats: Added 'suspended' line on the All users chart.
Jun 23 2025, 7:30 PM
mollekopf closed D5385: Always log requests.
Jun 23 2025, 8:37 AM
mollekopf committed rK0cd1183685fe: Always log requests.
Jun 23 2025, 8:37 AM
Harbormaster failed to build B6113: rPB492e1057e07b: puppetboard/app: Disabling CSRF protection globally. for rPB492e1057e07b: puppetboard/app: Disabling CSRF protection globally.!
Jun 23 2025, 3:42 AM

Jun 20 2025

mollekopf committed rS0fbb31c5a6ca: Measure processing time per message.
Jun 20 2025, 9:32 AM
machniak requested review of D5400: Stats: Added 'suspended' line on the All users chart.
Jun 20 2025, 9:24 AM