Page MenuHomePhorge
Feed All Stories

Apr 20 2025

joe1860 closed T8412: Kolab4 New deployment fails with amavis/spamassasin as Resolved.
Apr 20 2025, 8:31 AM · Bug Reports

Apr 19 2025

mollekopf accepted D4686: Subscriptions engine.
Apr 19 2025, 2:28 AM
mollekopf abandoned D5190: Skip folder tests that don't work in the containers.
Apr 19 2025, 2:25 AM
mollekopf committed rScf37d42b4c44: Get FolderTest to pass.
Apr 19 2025, 2:15 AM
mollekopf closed D5187: Clear caches so we can detect new folders.
Apr 19 2025, 2:15 AM
mollekopf committed rS0b20b674125c: Fixed analyzelogs extraction regex after change of debug message.
Apr 19 2025, 2:15 AM
mollekopf committed rS056e00cd8096: Force default folders to be always subscribed.
Apr 19 2025, 2:15 AM
mollekopf closed D5193: Force default folders to be always subscribed.
Apr 19 2025, 2:15 AM
mollekopf committed rS5dbe9ecc84fe: Clear caches so we can detect new folders.
Apr 19 2025, 2:15 AM
mollekopf closed D5184: Sleep after the loop so we can respond immediately.
Apr 19 2025, 2:15 AM
mollekopf committed rSa6d45341475d: Sleep after the loop so we can respond immediately.
Apr 19 2025, 2:15 AM

Apr 18 2025

machniak added a comment to D4686: Subscriptions engine.

I think kolab_subscriptions.php is missing?

Apr 18 2025, 6:34 PM
machniak accepted D5187: Clear caches so we can detect new folders.
Apr 18 2025, 6:28 PM
mollekopf requested changes to D4686: Subscriptions engine.

I think kolab_subscriptions.php is missing?
We should probably just get this merged, but it would be nice if we could fall-back to the metadata value for a seamless upgrade path (not sure what the current state is).

Apr 18 2025, 5:20 PM
mollekopf abandoned D5211: Get redis cache clearing to work.
Apr 18 2025, 5:00 PM
mollekopf updated the diff for D5187: Clear caches so we can detect new folders.

Cache clearing works now

Apr 18 2025, 4:51 PM
mollekopf committed R113:bfd0a4adfaf6: Support configuring the oauth redirect uri.
Apr 18 2025, 4:45 PM
mollekopf committed R113:a04e5fe89d47: Avoid reparenting special folders..
Apr 18 2025, 4:45 PM
mollekopf committed R113:72fd8f7332ae: Log exceptions to stdout also with the logfmt driver.
Apr 18 2025, 4:44 PM
mollekopf committed R113:2be2b1822b5d: logfmt stdout logger.
Apr 18 2025, 4:44 PM
mollekopf committed R113:880f8b653bd1: Also print an error on E_COMPILE_ERROR.
Apr 18 2025, 4:44 PM
mollekopf committed R113:2e61770bd2e3: php8 warning.
Apr 18 2025, 4:44 PM
mollekopf committed R113:6d7461bbe3d8: per_user_logging for stdout logging.
Apr 18 2025, 4:44 PM
mollekopf committed R113:bd99f89be5c1: Add a backtrace when an exception is raised so we know where it.
Apr 18 2025, 4:44 PM
mollekopf committed R113:d616e697da7e: php8 compat.
Apr 18 2025, 4:44 PM
mollekopf committed R113:12d34757c6c1: Do not log deprecation messages no production systems.
Apr 18 2025, 4:44 PM
mollekopf committed R113:8a25d57336e7: php8 compat.
Apr 18 2025, 4:44 PM
mollekopf committed R113:370ddd0f07c0: php8 compat.
Apr 18 2025, 4:44 PM
mollekopf committed R113:f97e02f0049c: Optimize fetchPartBody() for huge results w/o formatting and decoding (authored by machniak).
Apr 18 2025, 4:44 PM
mollekopf committed R113:42968c046e99: kolab skin updates.
Apr 18 2025, 4:44 PM
mollekopf committed R113:da48bf12165d: Fixed managesieve.js.
Apr 18 2025, 4:44 PM
mollekopf committed R113:923915745211: Don't log an imap authentication error when log_logins=true (authored by machniak).
Apr 18 2025, 4:44 PM
mollekopf committed R113:68fb8d8a0c7d: Added the kolab skin because the other repo is not publicly available.
Apr 18 2025, 4:44 PM
mollekopf committed R113:648f0cb6c50d: php8 compat.
Apr 18 2025, 4:44 PM
mollekopf committed R113:b10cc3cb17e3: Update changelog (authored by machniak).
Apr 18 2025, 4:44 PM
mollekopf committed R113:edb262482c5b: CS fixes, update changelog (authored by machniak).
Apr 18 2025, 4:44 PM
mollekopf committed R113:e3da525d6b26: Introduce optional support to inject PROXY protocol headers after.
Apr 18 2025, 4:44 PM
mollekopf committed R113:447f7041fdcd: Add a warning regarding implicit ssl.
Apr 18 2025, 4:44 PM
mollekopf committed R113:8f74781861e0: Added a composer.json.
Apr 18 2025, 4:44 PM
mollekopf committed R113:e5fb140988cb: Enigma: WOAT Support (#8626).
Apr 18 2025, 4:44 PM
mollekopf committed R113:9af1c575871f: Use rcube_utils::remote_addr() to take HTTP_X_FORWARDED_FOR into account.
Apr 18 2025, 4:44 PM
machniak committed R113:3cf128da4b6f: Fix HTML message preview if it contains floating tables (#9804).
Apr 18 2025, 4:44 PM
machniak committed R113:67d5dfc95063: Fix removing/expiring redis/memcache records when using a key prefix.
Apr 18 2025, 4:44 PM
machniak committed R113:8e2acf1a5b62: Tests: Move getEnv() to Browser class.
Apr 18 2025, 4:44 PM
machniak committed R113:17b21a4f6768: Bump laravel/dusk version.
Apr 18 2025, 4:44 PM
machniak committed R113:3ed9e8afe14f: Tests: Start Chrome Driver with port specified.
Apr 18 2025, 4:44 PM
machniak committed R113:56ad7aae2f3d: Fix dark mode bug where wrong colors were used for blockquotes in HTML mail….
Apr 18 2025, 4:44 PM
machniak committed R113:eda029157f6a: Fix PHP warning in index.php (#9813).
Apr 18 2025, 4:44 PM
machniak committed R113:b86fd45abbc8: OAuth: Fix/improve token refresh.
Apr 18 2025, 4:44 PM
machniak added a comment to D5211: Get redis cache clearing to work.

I believe I fixed the issue in https://github.com/roundcube/roundcubemail/commit/67d5dfc95063c4a97c84fd0a5ef48bf42ba656eb

Apr 18 2025, 12:44 PM
mollekopf added inline comments to D5187: Clear caches so we can detect new folders.
Apr 18 2025, 10:54 AM
mollekopf added a reviewer for D5211: Get redis cache clearing to work: machniak.
Apr 18 2025, 10:22 AM
mollekopf added inline comments to D5187: Clear caches so we can detect new folders.
Apr 18 2025, 10:22 AM
mollekopf requested review of D5211: Get redis cache clearing to work.
Apr 18 2025, 10:20 AM
machniak added inline comments to D5187: Clear caches so we can detect new folders.
Apr 18 2025, 9:56 AM
mollekopf added inline comments to D5187: Clear caches so we can detect new folders.
Apr 18 2025, 9:54 AM
mollekopf added inline comments to D5187: Clear caches so we can detect new folders.
Apr 18 2025, 9:46 AM
mollekopf added inline comments to D5187: Clear caches so we can detect new folders.
Apr 18 2025, 9:44 AM
machniak updated the diff for D5172: Delegation.
  • Merge branch 'master' into dev/delegation
Apr 18 2025, 9:44 AM
machniak added inline comments to D5187: Clear caches so we can detect new folders.
Apr 18 2025, 9:27 AM
mollekopf added inline comments to D5187: Clear caches so we can detect new folders.
Apr 18 2025, 9:22 AM
machniak closed D5208: Add more facades for backend classes.
Apr 18 2025, 9:09 AM
machniak committed rK7dd914f87a4c: Add more facades for backend classes.
Apr 18 2025, 9:09 AM
mollekopf accepted D5208: Add more facades for backend classes.
Apr 18 2025, 9:08 AM
machniak closed D5205: Webmail configuration API.
Apr 18 2025, 9:08 AM
machniak committed rK470c2443200f: Webmail configuration API.
Apr 18 2025, 9:08 AM
machniak requested review of D5208: Add more facades for backend classes.
Apr 18 2025, 9:05 AM
machniak closed D5202: IMAP and LDAP Facades (mocking).
Apr 18 2025, 8:58 AM
machniak committed rK643b6d12b915: IMAP and LDAP Facades (mocking).
Apr 18 2025, 8:58 AM
mollekopf added inline comments to D5202: IMAP and LDAP Facades (mocking).
Apr 18 2025, 8:56 AM
mollekopf accepted D5205: Webmail configuration API.

Looks good. For the theme / logo we'll have to contemplate where to store the actual image/theme. I could see it being an http link to with the backend being s3 or cephfs. I suppose for the image that would just work, and for the theme we would require some caching logic to download the theme as required.

Apr 18 2025, 8:54 AM
machniak added inline comments to D5202: IMAP and LDAP Facades (mocking).
Apr 18 2025, 8:53 AM
mollekopf accepted D5202: IMAP and LDAP Facades (mocking).

Looks good apart from the comment.

Apr 18 2025, 8:45 AM
mollekopf added inline comments to D5202: IMAP and LDAP Facades (mocking).
Apr 18 2025, 8:44 AM
mollekopf abandoned D5196: Test caching in Ping.
Apr 18 2025, 8:40 AM
machniak closed D5181: Metrics: Improve collectPayersCount() - use transactions instead of payments.
Apr 18 2025, 6:10 AM
machniak committed rKe28b38b374ca: Metrics: Improve collectPayersCount() - use transactions instead of payments.
Apr 18 2025, 6:10 AM
machniak closed D5178: Stats: Make payers count depend on transactions not payments.
Apr 18 2025, 6:10 AM
machniak committed rK572831c5be12: Stats: Make payers count depend on transactions not payments.
Apr 18 2025, 6:10 AM
machniak closed D5175: Rate Limit: Check wallet transactions instead of payments.
Apr 18 2025, 6:10 AM
machniak committed rK8f92cf54215b: Rate Limit: Check wallet transactions instead of payments.
Apr 18 2025, 6:10 AM
machniak requested changes to D5187: Clear caches so we can detect new folders.
Apr 18 2025, 6:04 AM
machniak committed rS42a25d1899f6: Fix phpstan errors on PHP 8.2.
Apr 18 2025, 6:03 AM
machniak abandoned D5160: Remove usage of undeclared variable.

The line was removed in 11d585165aee0.

Apr 18 2025, 5:33 AM
machniak updated the diff for D5199: Kolab integration plugin.
  • Add configuration feature to the kolab plugin
Apr 18 2025, 5:22 AM
machniak updated the diff for D5205: Webmail configuration API.
  • Add a sample on skin/logo
Apr 18 2025, 4:56 AM
mollekopf updated the diff for D5187: Clear caches so we can detect new folders.

This now properly tests the metadata cache issue.

Apr 18 2025, 1:56 AM

Apr 17 2025

machniak requested review of D5205: Webmail configuration API.
Apr 17 2025, 1:39 PM
machniak retitled D5172: Delegation from [WIP] Delegation
Apr 17 2025, 8:44 AM
machniak updated the diff for D5172: Delegation.
  • Replace delegation activated_at column with typical status column
Apr 17 2025, 8:43 AM

Apr 16 2025

machniak added a comment to D5202: IMAP and LDAP Facades (mocking).

This is now completed for LDAP and IMAP facades and ready for review. There were some more tricks needed, but I like the result. These changes already revealed two small bugs that I fixed.

Apr 16 2025, 1:42 PM
machniak retitled D5202: IMAP and LDAP Facades (mocking) from [POC] IMAP Facade (mocking)
Apr 16 2025, 1:38 PM
machniak updated the diff for D5202: IMAP and LDAP Facades (mocking).
  • Add LDAP facade and migrate tests
Apr 16 2025, 1:37 PM
machniak accepted D5184: Sleep after the loop so we can respond immediately.
Apr 16 2025, 7:48 AM
mollekopf updated the diff for D5184: Sleep after the loop so we can respond immediately.

We either have time left to sleep, or we break. So no point in having the min anymore.

Apr 16 2025, 7:40 AM
mollekopf added inline comments to D5184: Sleep after the loop so we can respond immediately.
Apr 16 2025, 7:36 AM
mollekopf added inline comments to D5184: Sleep after the loop so we can respond immediately.
Apr 16 2025, 7:31 AM
mollekopf updated the diff for D5184: Sleep after the loop so we can respond immediately.

Avoid unnecessary and confusing secondsLeft updates

Apr 16 2025, 7:30 AM
mollekopf added a comment to D5202: IMAP and LDAP Facades (mocking).

I'm going to keep tests against a real backend in tests/Feature/Backends/, where all IMAP methods should have it's test. Also DataMigrator tests and Infrastructure tests will stay this way.

But anywhere else we can use mocking.

Apr 16 2025, 7:18 AM
machniak added a comment to D5202: IMAP and LDAP Facades (mocking).

I'm going to keep tests against a real backend in tests/Feature/Backends/, where all IMAP methods should have it's test. Also DataMigrator tests and Infrastructure tests will stay this way.

Apr 16 2025, 7:00 AM