For existing installations that do not use a DAV backend; I suppose we'll just loose the subscription state, but it should otherwise work? And we'll loose the integration between imap subscription state and the syncroton subscription state, correct?

lib/kolab_sync_storage.php
1928	This used to operate on cached data, but now we seem to be executing a sql query everything to list the subscriptions, which might actually matter for this function (we'll end up doing the lookup once per folder). Maybe we should just populate the cache for all folders in one go?
tests/SyncTestCase.php
75	delete then?

Add 2nd arg to folder_subscriptions() calls

Harbormaster completed remote builds in B47100: Diff 13497.Apr 17 2024, 1:47 PM

I agree that the way we do id2name and vice versa sucks. Passing type (model name) everywhere is not great. I think in future we could improve that (e.g. by using IDs in form of "<type-class>:<id>", but it would be a BC break requiring a full re-sync.

I'm also thinking about using Cyrus v3 MAILBOXID (RFC 8474) for IMAP folders (for DAV the URI is fine, imo). Unfortunately Dovecot does not support that, and I'm not sure if falling back to using IMAP annotations (and setting them with generated uuid) would be a step in the right direction.

lib/kolab_sync_storage.php
1928	It shouldn't be a big problem. We're doing a query per folder type class, not per folder. `$this->folder_uids` is being populated with all subscribed folders of a specified class.
tests/SyncTestCase.php
75	That was a tricky part to figure out before, so I'll leave it in case we need to use IMAP in future here.

machniak mentioned this in D5187: Clear caches so we can detect new folders.Apr 18 2025, 6:04 AM

I think kolab_subscriptions.php is missing?
We should probably just get this merged, but it would be nice if we could fall-back to the metadata value for a seamless upgrade path (not sure what the current state is).

This revision now requires changes to proceed.Apr 18 2025, 5:20 PM

In D4686#66579, @mollekopf wrote:

I think kolab_subscriptions.php is missing?

It is part of D4683: Activesync subscriptions (in SQL database)

We should probably just get this merged, but it would be nice if we could fall-back to the metadata value for a seamless upgrade path (not sure what the current state is).

There is a fallback in kolab_subscriptions::get_subscriptions().

mollekopf accepted this revision.Apr 19 2025, 2:28 AM

This revision is now accepted and ready to land.Apr 19 2025, 2:28 AM

Merge branch 'master' into dev/kolab-subscriptions
Move DB migration file forward
Cleanup
Fix merge regressions
Remove redundant queries
CS fixes

Harbormaster completed remote builds in B53376: Diff 15015.Apr 30 2025, 10:17 AM

Fix merge regression, cleanup, skip some more tests on 'kolab' storage

Harbormaster completed remote builds in B53379: Diff 15018.Apr 30 2025, 11:05 AM

Closed by commit rS6c0a8768f156: Subscriptions engine. · Explain WhyApr 30 2025, 11:06 AM

This revision was automatically updated to reflect the committed changes.

machniak added a commit: rS6c0a8768f156: Subscriptions engine.

Subscriptions engine
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 15021

bin/inspect.php

config/config.inc.php.dist

docs/SQL/mysql.initial.sql

docs/SQL/mysql/2025042900.sql

lib/ext/Syncroton/Command/Ping.php

lib/kolab_sync_backend_device.php

lib/kolab_sync_data.php

lib/kolab_sync_data_calendar.php

lib/kolab_sync_data_email.php

lib/kolab_sync_storage.php

lib/kolab_sync_storage_kolab4.php

tests/Sync/FoldersTest.php

tests/Sync/PingTest.php

tests/Sync/Sync/CalendarTest.php

tests/Sync/Sync/ContactsTest.php

tests/SyncTestCase.php

tests/bootstrap.php

tests/setmetadata.php

Subscriptions engineClosedPublicActions