Page MenuHomePhorge
Feed Search

Jul 6 2025

mollekopf committed rSf90fc266ba35: Mark devices as broken.
Jul 6 2025, 6:28 PM
mollekopf committed rS5b7a47c4156c: Remove redundant log message.
Jul 6 2025, 6:28 PM
mollekopf closed D5439: Make sure we always get the correct data for a FolderSync..
Jul 6 2025, 6:28 PM
mollekopf closed D5430: Sleep when a client keeps resending the same FolderSync request..
Jul 6 2025, 6:28 PM
mollekopf committed rSbe70d827b464: Make sure we always get the correct data for a FolderSync..
Jul 6 2025, 6:28 PM
mollekopf committed rS2c1ea388f5ea: Sleep when a client keeps resending the same FolderSync request..
Jul 6 2025, 6:28 PM
mollekopf committed rSa773e8e91d18: Prepared some time measurements in relevant places.
Jul 6 2025, 6:28 PM

Jul 4 2025

mollekopf requested changes to D5451: Delete an existing user mailbox in IMAP::createUser().
Jul 4 2025, 6:48 AM
mollekopf added inline comments to D5451: Delete an existing user mailbox in IMAP::createUser().
Jul 4 2025, 6:48 AM
mollekopf accepted D5433: Make sure that user data is deleted in user:force-delete command.

This means we can only execute this command from where we also have imap admin access, but that's ok I suppose.

Jul 4 2025, 6:42 AM

Jul 3 2025

mollekopf updated the diff for D5448: Show broken state in Activesync UI.

Use boxwarning

Jul 3 2025, 2:03 PM
mollekopf added inline comments to D5448: Show broken state in Activesync UI.
Jul 3 2025, 2:02 PM
mollekopf updated the diff for D5445: Mark devices as broken.

Boolean broken state with the rest in extraData

Jul 3 2025, 1:49 PM
mollekopf added a comment to D5436: flat_mode for kolab4.

We should make this new code consistent with kolab_sync_storage_kolab4::folders_list(). You can find there how we handle special folders type. kolab_storage::folders_typedata() should not be used.

Jul 3 2025, 1:14 PM
mollekopf added a comment to D5445: Mark devices as broken.

I don't see how you unset the "broken" state. You said that when you reset Outlook according to your manual it will use the same device identifier. How it will unlock itself then? A test would be nice.

Jul 3 2025, 12:44 PM
mollekopf added a comment to D5445: Mark devices as broken.

This is how outlook looks once we block the device (as you can see it enters "Disconnected/Getrennt" state).

image.png (1,782×1,003 px, 64 KB)

Jul 3 2025, 12:42 PM
mollekopf updated the diff for D5436: flat_mode for kolab4.

Separate kolab4 implementation

Jul 3 2025, 12:33 PM
mollekopf added inline comments to D5448: Show broken state in Activesync UI.
Jul 3 2025, 12:05 PM
mollekopf updated the diff for D5445: Mark devices as broken.

Handle blocking of devices via config option

Jul 3 2025, 11:44 AM
mollekopf added a reviewer for D5448: Show broken state in Activesync UI: Syncroton Developers.

Clearly with room for improvement, but this gets the job done.
I'm open to some easy to implement suggestions, as I'm not very familiar with registering new forms (which is why I'm hijacking the subscriptions list).

Jul 3 2025, 11:25 AM
mollekopf added a reviewer for D5445: Mark devices as broken: Syncroton Developers.

My plan is to deploy this, review which devices get marked as broken, and only then start failing requests early.

Jul 3 2025, 11:23 AM
mollekopf requested review of D5448: Show broken state in Activesync UI.
Jul 3 2025, 11:22 AM
mollekopf updated the diff for D5445: Mark devices as broken.

mysql.initial version

Jul 3 2025, 10:44 AM
mollekopf requested review of D5445: Mark devices as broken.
Jul 3 2025, 10:39 AM
mollekopf added inline comments to D5436: flat_mode for kolab4.
Jul 3 2025, 8:44 AM
mollekopf accepted D5376: Include shared folders and resources when looking for a mail recipient.
Jul 3 2025, 8:24 AM
mollekopf added a reviewer for D5442: Ping retry counter: Syncroton Developers.

Basically the same as we do for FolderSync, but useful for loops that don't report changes on FolderSync (and thus get no counting), or for loops that don't include FolderSync at all.

Jul 3 2025, 8:10 AM
mollekopf added a reviewer for D5439: Make sure we always get the correct data for a FolderSync.: Syncroton Developers.
Jul 3 2025, 8:09 AM
mollekopf added a reviewer for D5436: flat_mode for kolab4: Syncroton Developers.

Seems to work for the delegation case.

Jul 3 2025, 8:08 AM
mollekopf added inline comments to D5427: Slim down number of wallet check jobs.
Jul 3 2025, 8:08 AM
mollekopf requested review of D5442: Ping retry counter.
Jul 3 2025, 8:05 AM
mollekopf requested review of D5439: Make sure we always get the correct data for a FolderSync..
Jul 3 2025, 8:05 AM
mollekopf requested review of D5436: flat_mode for kolab4.
Jul 3 2025, 8:05 AM
mollekopf updated the diff for D5430: Sleep when a client keeps resending the same FolderSync request..

Return a 503 and sleep, because the 503 doesn't actually seem to stop the client.

Jul 3 2025, 8:05 AM

Jul 2 2025

mollekopf added inline comments to D5430: Sleep when a client keeps resending the same FolderSync request..
Jul 2 2025, 12:09 PM
mollekopf added a comment to D5430: Sleep when a client keeps resending the same FolderSync request..

If we assume 1 request per device per second and an average execution time of 1s, then we'd reduce our capacity by ~11 by making all requests take 11s, because all processing slots in php-fpm will be occupied.
So while this should work well for protecting e.g. imap from getting overloaded, we may introduce another bottleneck....

Jul 2 2025, 11:28 AM
mollekopf added a reviewer for D5430: Sleep when a client keeps resending the same FolderSync request.: Syncroton Developers.
Jul 2 2025, 11:20 AM
mollekopf requested review of D5430: Sleep when a client keeps resending the same FolderSync request..
Jul 2 2025, 11:18 AM

Jul 1 2025

mollekopf committed rRPKbb7e211d1b46: Outlook can't deal with Spam or Junk Email re-enabled either..
Jul 1 2025, 2:49 PM
mollekopf committed rRPK094ea588671c: Anchor the pattern os we don't match subfolders if we don't intend to.
Jul 1 2025, 10:03 AM
mollekopf closed D5421: Debug message to explain why a change has been detected.
Jul 1 2025, 8:50 AM
mollekopf closed D5418: Count FolderSync retries, and warn after 10 failures.
Jul 1 2025, 8:50 AM
mollekopf committed rS149185894023: Count FolderSync retries, and warn after 10 failures.
Jul 1 2025, 8:50 AM
mollekopf committed rS59e08a3f0c8f: Debug message to explain why a change has been detected.
Jul 1 2025, 8:50 AM
mollekopf committed rSfebdd60e334e: php8 compat.
Jul 1 2025, 8:50 AM
mollekopf committed rS092430556bc7: Test activesync_force_subscriptions.
Jul 1 2025, 8:50 AM

Jun 30 2025

mollekopf accepted D5409: Silently exit a job on "object already deleted" case, unify behvior across all jobs.
Jun 30 2025, 7:43 PM
mollekopf updated the diff for D5421: Debug message to explain why a change has been detected.

Ensure we match servids and not parent ids.

Jun 30 2025, 7:13 PM
mollekopf updated the diff for D5418: Count FolderSync retries, and warn after 10 failures.

Initial log message as info, cleanup of the counterNext situation

Jun 30 2025, 7:06 PM
mollekopf closed D5406: activesync_force_subscriptionstate support.
Jun 30 2025, 7:04 PM
mollekopf committed rRPK66c3a62aef58: Support for activesync_force_subscriptions.
Jun 30 2025, 7:04 PM
mollekopf added inline comments to D5418: Count FolderSync retries, and warn after 10 failures.
Jun 30 2025, 6:37 PM
mollekopf added inline comments to D5418: Count FolderSync retries, and warn after 10 failures.
Jun 30 2025, 6:34 PM
mollekopf accepted D5412: Allow distribution list creation for email that existed before.

Looks like it's at least the same logic as before.

Jun 30 2025, 3:49 PM
mollekopf added inline comments to D5412: Allow distribution list creation for email that existed before.
Jun 30 2025, 3:40 PM
mollekopf accepted D5403: Password expiration.
Jun 30 2025, 3:35 PM
mollekopf accepted D5415: Add support for --with-deleted option in scalpel:*:read commands.
Jun 30 2025, 3:33 PM
mollekopf added a reviewer for D5418: Count FolderSync retries, and warn after 10 failures: Syncroton Developers.

This will turn a read-only operation into an UPDATE query, and the getting the abstraction lasagna to execute the update query is fairly messy, but I suppose it's still worth it unless there's a better approach.

Jun 30 2025, 3:19 PM
mollekopf added a reviewer for D5421: Debug message to explain why a change has been detected: Syncroton Developers.

Makes it a lot easier to see what's happening.

Jun 30 2025, 3:17 PM
mollekopf requested review of D5421: Debug message to explain why a change has been detected.
Jun 30 2025, 3:15 PM
mollekopf requested review of D5418: Count FolderSync retries, and warn after 10 failures.
Jun 30 2025, 3:10 PM
mollekopf updated the diff for D5406: activesync_force_subscriptionstate support.

Merge the two config options

Jun 30 2025, 3:01 PM
mollekopf committed rK1902738c64a3: Make sure we have a valid php.ini during build.
Jun 30 2025, 11:54 AM
mollekopf committed rK3d1c1f771385: Make sure we have activesync_storage set for tests.
Jun 30 2025, 11:54 AM
mollekopf committed rK8e3649cf59fd: null and not having the entry is not the same.
Jun 30 2025, 11:54 AM
mollekopf committed rKbab92f6ac1b1: Fixed database seed.
Jun 30 2025, 11:54 AM

Jun 27 2025

mollekopf added a comment to D5406: activesync_force_subscriptionstate support.

We already have $config['activesync_force_subscriptions'] in the kolab_activesync plugin. It would make sense to de-duplicate.

Jun 27 2025, 11:32 AM

Jun 26 2025

mollekopf added a comment to D5406: activesync_force_subscriptionstate support.

My outlook is in a state where enabling the Calendar will break FolderSync because of the Add, but disabling the Calendar will result in a sync loop via Ping because the Calendar is not available.

Jun 26 2025, 3:48 PM
mollekopf added a comment to D5406: activesync_force_subscriptionstate support.

I think a problem with this will be that if you have an existing outlook, but the Calendar has been disabled on the server, then enabling it will trigger an "Add" for the Calendar, which Outlook doesn't like, so I'm not sure how to reconcile that.
Perhaps we need to suppress the Add for folders that are supposed to be always enabled.

Jun 26 2025, 3:46 PM
mollekopf added a reviewer for D5406: activesync_force_subscriptionstate support: Roundcube Kolab Plugins Developers.

Tested via test in syncroton repository where I nuke all subscriptions and make sure we still get the expected default folders in FolderSync.

Jun 26 2025, 3:33 PM
mollekopf requested review of D5406: activesync_force_subscriptionstate support.
Jun 26 2025, 3:32 PM

Jun 25 2025

mollekopf committed rK70fbc9b7dbdd: Option to enable proxy protocol support.
Jun 25 2025, 2:12 PM
mollekopf committed rK4356f2b9f436: Custom swoole php.ini to configure the memory limit.
Jun 25 2025, 2:12 PM
mollekopf committed rKe26507c7fa2f: Configurable postfix message size limit.
Jun 25 2025, 2:12 PM
mollekopf committed rK2a87e8118621: Log request failures.
Jun 25 2025, 2:12 PM
mollekopf committed rKb039615a4745: Attachment support for mailtransporttest.
Jun 25 2025, 2:12 PM
mollekopf committed rK9040c302f2a3: Configurable swoole concurrency.
Jun 25 2025, 2:12 PM
mollekopf committed rK9dd84834916c: Log roundcube request durations.
Jun 25 2025, 2:12 PM
mollekopf committed rK59150120c9af: Only pin refs if not already specified.
Jun 25 2025, 2:12 PM
mollekopf committed rKccfb2b0b9e46: Set the dav cache to redis.
Jun 25 2025, 2:12 PM

Jun 23 2025

mollekopf accepted D5394: Performance: Introduce mutable version of walletOwner().
Jun 23 2025, 7:40 PM
mollekopf accepted D5400: Stats: Added 'suspended' line on the All users chart.
Jun 23 2025, 7:30 PM
mollekopf closed D5385: Always log requests.
Jun 23 2025, 8:37 AM
mollekopf committed rK0cd1183685fe: Always log requests.
Jun 23 2025, 8:37 AM

Jun 20 2025

mollekopf committed rS0fbb31c5a6ca: Measure processing time per message.
Jun 20 2025, 9:32 AM

Jun 18 2025

mollekopf accepted D5388: Performance: Support minimum response in api/auth/login request.

A more generic solution might be that the client can simply list the thing's it wants. which would be 'id' in this case (I suppose having the access_token implicit makes sense?).

Jun 18 2025, 11:39 AM
mollekopf added a reviewer for D5385: Always log requests: Restricted Project.
Jun 18 2025, 10:14 AM
mollekopf requested review of D5385: Always log requests.
Jun 18 2025, 10:13 AM
mollekopf requested review of D5382: Expose some swoole metrics.
Jun 18 2025, 10:06 AM

Jun 17 2025

mollekopf accepted D5379: Mailfilter debug logs.

I think at some point we should come up with a generic solution for more granular logging, but this will work for now.

Jun 17 2025, 1:42 PM
mollekopf committed rKd8275c2d7c89: Configurable roundcube limits.
Jun 17 2025, 1:28 PM
mollekopf committed rK7087cf87f9dc: Nginx proxy: allow tlsv1.3 for imap, avoid SSL errors about unexpected eof.
Jun 17 2025, 1:28 PM
mollekopf committed rS1da5cae30c2a: manage-subscriptions.php fixes.
Jun 17 2025, 1:18 PM

Jun 16 2025

mollekopf accepted D5373: External sender warning: Configurable list of additional internal domains.
Jun 16 2025, 10:18 AM

Jun 13 2025

mollekopf closed D5370: manage-subscriptions.php --dropempty.
Jun 13 2025, 7:28 AM
mollekopf committed rSbcc0a734f310: manage-subscriptions.php --dropempty.
Jun 13 2025, 7:28 AM

Jun 12 2025

mollekopf edited reviewers for D5370: manage-subscriptions.php --dropempty, added: Syncroton Developers; removed: Roundcube Kolab Plugins Developers.
Jun 12 2025, 3:09 PM
mollekopf added a reviewer for D5370: manage-subscriptions.php --dropempty: Roundcube Kolab Plugins Developers.
Jun 12 2025, 3:09 PM
mollekopf requested review of D5370: manage-subscriptions.php --dropempty.
Jun 12 2025, 3:08 PM
mollekopf accepted D5358: Kolab plugin compatibility.
Jun 12 2025, 1:09 PM