• Fix CS

• Merge branch 'master' into dev/delegation
• Merge branch 'master' into dev/delegation
• Fix phpstan issues
• CS fixes

• Merge branch 'master' into dev/kolab4
• Kolab4: Global Addressbook

• Add test

Replaced by D5232: Fix synchronization of email addresses for DAV contacts

FN property is required, but can be empty.

Wouldn't it be easier to remember which folder is missing in Sync/Ping (e.g. using cache) and then in FolderSync treat it as deleted?

Maybe setting it to an empty string would work, but we're ignoring such values on our side (AXMLEntry::appendXML()), so we'd have to change how we handle empty strings. Maybe it was a problem for the original Syncroton authors implementation, but I think this change should be safe for us. So, I'd propose to try this first.

The Kolab3 XML objects are read like this:

$emails = $this->obj->emailAddresses();
if ($emails instanceof vectoremail) {
    $emailtypes = array_flip($this->emailtypes);
    for ($i = 0; $i < $emails->size(); $i++) {
        $email = $emails->get($i);
        $object['email'][] = ['address' => $email->address(), 'type' => $emailtypes[$email->types()]];
    }
} else {
    $object['email'] = self::vector2array($emails);
}

but Kolab4 vCards are read using rcube_vcard::get_assoc(), so the output is different. We have to support both. And looking at the code it seems that writing is also broken. I can work on this.

• Fix merge regression, cleanup, skip some more tests on 'kolab' storage

• Merge branch 'master' into dev/kolab-subscriptions
• Move DB migration file forward
• Cleanup
• Fix merge regressions
• Remove redundant queries
• CS fixes

• Merge branch 'master' into dev/kolab-subscriptions

• Comment out the Sender/X-Sender header addition to a sent mail

• SmtpAccess policy cleanup

• Merge branch 'master' into dev/delegation

• Remove redundant @group markers

• App\Policy\Greylist\Request.php -> App\Policy\Greylist.php - improved tests
• Extract SPF policy code from the controller into App\Policy namespace, improve tests
• app/Policy/Mailfilter/RequestHandler.php -> app/Policy/Mailfilter.php
• Cleanup

• Move RateLimitWhitelist class into app/Policy/RateLimit dir

• Merge branch 'master' into dev/delegation
• Fix regression
• Tests

• Add TODO

• Remove redundant print()
• Add TODO

• Submission policy implementation

In D4686#66579, @mollekopf wrote:

I think kolab_subscriptions.php is missing?

I believe I fixed the issue in https://github.com/roundcube/roundcubemail/commit/67d5dfc95063c4a97c84fd0a5ef48bf42ba656eb

• Merge branch 'master' into dev/delegation

The line was removed in 11d585165aee0.

• Add configuration feature to the kolab plugin

• Add a sample on skin/logo

• Replace delegation activated_at column with typical status column

This is now completed for LDAP and IMAP facades and ready for review. There were some more tricks needed, but I like the result. These changes already revealed two small bugs that I fixed.

• Add LDAP facade and migrate tests

I'm going to keep tests against a real backend in tests/Feature/Backends/, where all IMAP methods should have it's test. Also DataMigrator tests and Infrastructure tests will stay this way.

• Include delegator name in the response
• Fix UI

• Exclude self from user autocomplete result

That's not exactly the same as doing it in another client. I don't like the test code in Ping command code. Maybe create a php script that will sleep for a few seconds and then do the metadata update, which you could call using exec() before the Ping request in the test.