Page MenuHomePhorge
Differential D3379

Password expiration notification
ClosedPublic
Actions

Authored by machniak on Feb 16 2022, 1:54 PM.
Tags
None
Referenced Files
F12249270: D3379.id10087.diff
Sun, May 19, 2:13 PM
F12245784: D3379.id9658.diff
Sun, May 19, 10:37 AM
Unknown Object (File)
Sat, May 18, 11:33 AM
Unknown Object (File)
Fri, May 17, 2:40 PM
Unknown Object (File)
Wed, May 8, 8:34 PM
Unknown Object (File)
Sat, May 4, 10:01 PM
Unknown Object (File)
Fri, May 3, 4:49 AM
Unknown Object (File)
Thu, May 2, 12:38 PM
View All 61 Files
Subscribers
mollekopf
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK8a62ff5ce853: Password expiration notification
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/password-retention
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/resources/views/emails/html/password_expiration_reminder.blade.php:1PHPCS.W.Internal.NoCodeFoundInternal.NoCodeFound
Warningsrc/resources/views/emails/plain/password_expiration_reminder.blade.php:1PHPCS.W.Internal.NoCodeFoundInternal.NoCodeFound
Unit
No Test Coverage
Build Status
Buildable 38461
Build 15547: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Feb 16 2022, 1:54 PM
machniak created this revision.
Harbormaster completed remote builds in B38437: Diff 9658.Feb 16 2022, 1:54 PM
Harbormaster completed remote builds in B38437: Diff 9658.
machniak updated this revision to Diff 9664.Feb 17 2022, 10:16 AM
  • Add missing command description
  • Merge branch 'master' into dev/password-retention
Harbormaster completed remote builds in B38461: Diff 9664.Feb 17 2022, 10:16 AM
Harbormaster completed remote builds in B38461: Diff 9664.
mollekopf accepted this revision.Apr 1 2022, 10:46 AM
mollekopf subscribed.

Using months as unit of the max_password_age seems rather coarse, but if it's good enough for the end users it's good enough for me (don't know to which extent this has already been discussed).

src/app/Console/Commands/PasswordRetentionCommand.php
49

I think skipping suspended users makes sense. I wouldn't skip degraded users.

src/app/Traits/UserConfigTrait.php
40

nitpick: intval($value) > 0 would do the job I think.

This revision is now accepted and ready to land.Apr 1 2022, 10:46 AM
machniak updated this revision to Diff 10024.Apr 21 2022, 10:42 AM
  • Suggested changes
Harbormaster completed remote builds in B38878: Diff 10024.Apr 21 2022, 10:42 AM
machniak updated this revision to Diff 10084.Apr 21 2022, 1:44 PM
  • Merge branch 'master' into dev/password-retention
Harbormaster completed remote builds in B38893: Diff 10084.Apr 21 2022, 1:44 PM
machniak updated this revision to Diff 10087.Apr 21 2022, 1:55 PM
  • Fix test
Harbormaster completed remote builds in B38896: Diff 10087.Apr 21 2022, 1:55 PM
Closed by commit rK8a62ff5ce853: Password expiration notification (authored by machniak). · Explain WhyApr 21 2022, 2:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Console/
Commands/
84 lines
4 lines
Http/
Controllers/
API/
6 lines
Jobs/
Password/
68 lines
Mail/
82 lines
Observers/
8 lines
Traits/
17 lines
resources/
lang/
en/
3 lines
8 lines
views/
emails/
html/
16 lines
plain/
9 lines
vue/
26 lines
tests/
Browser/
13 lines
Feature/
Console/
117 lines
Controller/
7 lines
13 lines
Jobs/
Password/
73 lines
26 lines
Unit/
Mail/
46 lines

Diff 9664

View Options

src/app/Console/Commands/PasswordRetentionCommand.php

Loading...
View Options

src/app/Console/Kernel.php

Loading...
View Options

src/app/Http/Controllers/API/PasswordPolicyController.php

Loading...
View Options

src/app/Jobs/Password/RetentionEmailJob.php

Loading...
View Options

src/app/Mail/PasswordExpirationReminder.php

Loading...
View Options

src/app/Observers/UserObserver.php

Loading...
View Options

src/app/Traits/UserConfigTrait.php

Loading...
View Options

src/resources/lang/en/mail.php

Loading...
View Options

src/resources/lang/en/ui.php

Loading...
View Options

src/resources/views/emails/html/password_expiration_reminder.blade.php

Loading...
View Options

src/resources/views/emails/plain/password_expiration_reminder.blade.php

Loading...
View Options

src/resources/vue/Settings.vue

Loading...
View Options

src/tests/Browser/SettingsTest.php

Loading...
View Options

src/tests/Feature/Console/PasswordRetentionTest.php

Loading...
View Options

src/tests/Feature/Controller/PasswordPolicyTest.php

Loading...
View Options

src/tests/Feature/Controller/UsersTest.php

Loading...
View Options

src/tests/Feature/Jobs/Password/RetentionEmailJobTest.php

Loading...
View Options

src/tests/Feature/UserTest.php

Loading...
View Options

src/tests/Unit/Mail/PasswordExpirationReminderTest.php

Loading...