Paths

Table of Contentst

Signup limits
ClosedPublic
Actions

Authored by vanmeeuwen on Dec 24 2021, 9:52 AM.

Project Tags

None

Referenced Files

	F117763652: D3149.1775219985.diff
	Thu, Apr 2, 12:39 PM

	F117755940: D3149.1775204636.diff
	Thu, Apr 2, 8:23 AM

	F117755937: D3149.1775204627.diff
	Thu, Apr 2, 8:23 AM

Subscribers

mollekopf

Restricted Project

Details

Reviewers

machniak
vanmeeuwen

Group Reviewers

Restricted Project

Commits

rKce233afa436f: Signup limits

Summary

TODO:

add index on signup_codes.ip_address and signup_codes.email columns
make sure the stored email is lowercased?

Test Plan

./phpunit

Diff Detail

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak requested review of this revision.Dec 24 2021, 9:52 AM

machniak created this revision.

Harbormaster completed remote builds in B37463: Diff 8972.Dec 24 2021, 9:53 AM

mollekopf subscribed.Dec 24 2021, 9:58 AM

mollekopf added inline comments.

src/app/Rules/SignupExternalEmail.php
31	Add a comment that we deliberately give the "wrong" reason to not disclose information.

vanmeeuwen commandeered this revision.Dec 24 2021, 2:04 PM

vanmeeuwen added a reviewer: machniak.

Add commentary about the apparent inaccuracy of the message

Harbormaster completed remote builds in B37469: Diff 8978.Dec 24 2021, 2:07 PM

vanmeeuwen accepted this revision.Dec 24 2021, 2:09 PM

This revision is now accepted and ready to land.Dec 24 2021, 2:09 PM

Closed by commit rKce233afa436f: Signup limits. · Explain WhyDec 24 2021, 2:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

.env.example

lines

app/

Http/

Controllers/

API/

SignupController.php

lines

Rules/

ExternalEmail.php

lines

SignupExternalEmail.php

lines

config/

app.php

lines

tests/

Feature/

Controller/

SignupTest.php

lines

Diff 8984

View Options

src/.env.example

View Options

src/app/Http/Controllers/API/SignupController.php

View Options

src/app/Rules/ExternalEmail.php

View Options

src/app/Rules/SignupExternalEmail.php

View Options

src/config/app.php

View Options

src/tests/Feature/Controller/SignupTest.php

Signup limitsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8984

src/.env.example

src/app/Http/Controllers/API/SignupController.php

src/app/Rules/ExternalEmail.php

src/app/Rules/SignupExternalEmail.php

src/config/app.php

src/tests/Feature/Controller/SignupTest.php

Signup limits
ClosedPublic
Actions

Revision Contents
Changeset List