Page MenuHomePhorge
Differential D3038

Code de-duplication, API unification
ClosedPublic
Actions

Authored by machniak on Nov 18 2021, 1:10 PM.
Tags
None
Referenced Files
F16178265: D3038.id8669.diff
Thu, Oct 17, 5:32 AM
Unknown Object (File)
Sun, Oct 6, 10:53 PM
Unknown Object (File)
Sep 7 2024, 4:09 AM
Unknown Object (File)
Sep 7 2024, 3:39 AM
Unknown Object (File)
Aug 29 2024, 9:29 PM
Unknown Object (File)
Aug 18 2024, 10:16 AM
Unknown Object (File)
Aug 3 2024, 7:02 PM
Unknown Object (File)
Aug 3 2024, 7:02 PM
View All 84 Files
Subscribers
mollekopf
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK4211ad138d60: Code de-duplication, API unification
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/dedup
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 37136
Build 14840: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Nov 18 2021, 1:10 PM
machniak created this revision.
Harbormaster completed remote builds in B37112: Diff 8651.Nov 18 2021, 1:10 PM
machniak updated this revision to Diff 8669.Nov 18 2021, 4:16 PM
  • De-duplicate code for handling status update process
Harbormaster completed remote builds in B37130: Diff 8669.Nov 18 2021, 4:16 PM
machniak updated this revision to Diff 8675.Nov 19 2021, 8:41 AM
  • Even more deduplication
Harbormaster completed remote builds in B37136: Diff 8675.Nov 19 2021, 8:41 AM
mollekopf accepted this revision.Nov 19 2021, 2:39 PM
mollekopf subscribed.
mollekopf added inline comments.
src/app/Http/Controllers/Controller.php
210

Personally I would prefer passing $objectProps as argument instead of $full, unless $objectProps becomes useful for other functions as well.

It would make it a bit clearer IMO what's going on: Either you serialize everything, or just the requested $objectProps.

That's not a blocker though.

This revision is now accepted and ready to land.Nov 19 2021, 2:39 PM
machniak added inline comments.Nov 19 2021, 2:53 PM
src/app/Http/Controllers/Controller.php
210

Yes, but this way we define the common props once (per object type), so we don't have to pass them all the time as an argument. This makes also the API responses unified "automatically", i.e. reseller, admin, user end-points, all of them return the same set of object properties.

Closed by commit rK4211ad138d60: Code de-duplication, API unification (authored by machniak). · Explain WhyNov 19 2021, 2:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Http/
Controllers/
API/
V4/
Admin/
10 lines
15 lines
4 lines
117 lines
116 lines
Reseller/
10 lines
15 lines
10 lines
113 lines
142 lines
tests/
Unit/
Controller/

Diff 8675

View Options

src/app/Http/Controllers/API/V4/Admin/DomainsController.php

Loading...
View Options

src/app/Http/Controllers/API/V4/Admin/GroupsController.php

Loading...
View Options

src/app/Http/Controllers/API/V4/Admin/UsersController.php

Loading...
View Options

src/app/Http/Controllers/API/V4/DomainsController.php

Loading...
View Options

src/app/Http/Controllers/API/V4/GroupsController.php

Loading...
View Options

src/app/Http/Controllers/API/V4/Reseller/DomainsController.php

Loading...
View Options

src/app/Http/Controllers/API/V4/Reseller/GroupsController.php

Loading...
View Options

src/app/Http/Controllers/API/V4/Reseller/UsersController.php

Loading...
View Options

src/app/Http/Controllers/API/V4/UsersController.php

Loading...
View Options

src/app/Http/Controllers/Controller.php

Loading...
View Options

src/tests/Unit/Controller/DomainsTest.php

Loading...
View Options

src/tests/Unit/Controller/UsersTest.php

Loading...