- Group Reviewers
- rK4211ad138d60: Code de-duplication, API unification
Personally I would prefer passing $objectProps as argument instead of $full, unless $objectProps becomes useful for other functions as well.
It would make it a bit clearer IMO what's going on: Either you serialize everything, or just the requested $objectProps.
That's not a blocker though.
Yes, but this way we define the common props once (per object type), so we don't have to pass them all the time as an argument. This makes also the API responses unified "automatically", i.e. reseller, admin, user end-points, all of them return the same set of object properties.