Page MenuHomePhorge

Code de-duplication, API unification
ClosedPublic

Authored by machniak on Nov 18 2021, 1:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 11, 1:03 AM
Unknown Object (File)
Fri, May 10, 4:23 PM
Unknown Object (File)
Tue, Apr 30, 11:13 AM
Unknown Object (File)
Fri, Apr 26, 8:49 AM
Unknown Object (File)
Thu, Apr 25, 6:45 PM
Unknown Object (File)
Wed, Apr 24, 6:47 PM
Unknown Object (File)
Mar 31 2024, 5:25 PM
Unknown Object (File)
Mar 29 2024, 12:27 PM
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK4211ad138d60: Code de-duplication, API unification
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak created this revision.
  • De-duplicate code for handling status update process
mollekopf subscribed.
mollekopf added inline comments.
src/app/Http/Controllers/Controller.php
210

Personally I would prefer passing $objectProps as argument instead of $full, unless $objectProps becomes useful for other functions as well.

It would make it a bit clearer IMO what's going on: Either you serialize everything, or just the requested $objectProps.

That's not a blocker though.

This revision is now accepted and ready to land.Nov 19 2021, 2:39 PM
src/app/Http/Controllers/Controller.php
210

Yes, but this way we define the common props once (per object type), so we don't have to pass them all the time as an argument. This makes also the API responses unified "automatically", i.e. reseller, admin, user end-points, all of them return the same set of object properties.

This revision was automatically updated to reflect the committed changes.