Details

Reviewers

machniak
mollekopf

Group Reviewers

Restricted Project

Commits

rKb70dbda55bad: Allow search with transaction and customer IDs

Test Plan

None

Diff Detail

Repository

rK kolab

Branch

arcpatch-D2740

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 36172
Build 14236: arc lint + arc unit

Event Timeline

vanmeeuwen requested review of this revision.Aug 17 2021, 11:17 AM

vanmeeuwen created this revision.

Harbormaster completed remote builds in B36121: Diff 7810.Aug 17 2021, 11:17 AM

Because both these additional searches are mollie-specific maybe this code should be abstracted-on/moved-to the Providers/PaymentProvider. E.g. isPaymentId(), isCustomerId(), findWalletByPaymentOrCustomerId() or sth like that.

src/app/Http/Controllers/API/V4/Admin/UsersController.php
94	This should include `->where('key', 'mollie_id')`, but even then it will not use an index and might be slow.

This revision now requires changes to proceed.Aug 18 2021, 8:00 AM

mollekopf subscribed.Aug 18 2021, 8:43 AM

mollekopf added inline comments.

src/app/Http/Controllers/API/V4/Admin/UsersController.php
94	I believe if not found first() will return null and therefore you'd try to invoke wallet() on null?
94	Is it intended that the value is matched against "cst_$something" or should the search only be executed against $something without the cst_ prefix? Same below.

mollekopf added inline comments.Aug 18 2021, 8:48 AM

src/app/Http/Controllers/API/V4/Admin/UsersController.php
93	Add a comment that this is a search by mollie customerId
94	Nevermind, I figured out what the cst_ and tr_ prefixes are.
101	Add a comment that this is a search by mollie payment id.