None
Details
Details
- Reviewers
machniak mollekopf - Group Reviewers
Restricted Project - Commits
- rKb70dbda55bad: Allow search with transaction and customer IDs
Diff Detail
Diff Detail
- Repository
- rK kolab
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 36157 Build 14218: arc lint + arc unit
Event Timeline
Comment Actions
Because both these additional searches are mollie-specific maybe this code should be abstracted-on/moved-to the Providers/PaymentProvider. E.g. isPaymentId(), isCustomerId(), findWalletByPaymentOrCustomerId() or sth like that.
src/app/Http/Controllers/API/V4/Admin/UsersController.php | ||
---|---|---|
94 | This should include ->where('key', 'mollie_id'), but even then it will not use an index and might be slow. |
src/app/Http/Controllers/API/V4/Admin/UsersController.php | ||
---|---|---|
94 | I believe if not found first() will return null and therefore you'd try to invoke wallet() on null? | |
94 | Is it intended that the value is matched against "cst_$something" or should the search only be executed against $something without the cst_ prefix? Same below. |
src/app/Http/Controllers/API/V4/Admin/UsersController.php | ||
---|---|---|
104 | $wallet does not exist. |
src/app/Http/Controllers/API/V4/Admin/UsersController.php | ||
---|---|---|
114 | Should be $payment->wallet->... |