./phpunit
Details
- Reviewers
mollekopf - Group Reviewers
Restricted Project - Commits
- rKad947512d7ff: Degraded accounts
rK2deb4c185040: Degraded accounts
rK6ffdfb56b891: Degraded accounts
rKb6bf76e1b772: Degraded accounts
rK26edf013bc60: Degraded accounts
Diff Detail
- Repository
- rK kolab
- Branch
- dev/status-degraded
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 35401 Build 13831: arc lint + arc unit
Event Timeline
- Merge branch 'master' into dev/status-degraded
- Fix regressions regarding tenants
- Fix more regressions
- Small cleanup
After having another look it doesn't seem like there is a good way to contain the isDegrated logic much more.
As mentioned in the comment, there may be an opportunity to rely more on UsersController::statusInfo, but it's not currently a large problem since there are few degraded checks that can be replaced by it (I still think it could be worthwhile though in the long run).
src/resources/vue/Rooms.vue | ||
---|---|---|
44 | How about moving the isDegraded check to hasSKU instead? Or even more centrally in UsersController::statusInfo, which seems to be where we decide who can view what. Same goes for all the checks above, so something different than hasSKU is perhaps required: |
- Merge branch 'master' into dev/status-degraded
- Merge branch 'master' into dev/status-degraded
- Also hide Create list button in degraded mode
src/resources/vue/Rooms.vue | ||
---|---|---|
44 | I would agree that we could do something better in statusInfo, but I don't think we have to do this here. hasSKU + isDegraded is used in one place. In other places we have to just hide some elements like Create buttons. So, it would not give us much. When we decide to do something more sophisticated with the UI we might get to that. Diff has been rebased. |
- Merge branch 'master' into dev/status-degraded
- Hide more create buttons
- Fix test regression
- Fix regression
- Cleanup