Page MenuHomePhorge

Degraded accounts
ClosedPublic

Authored by machniak on Mar 8 2021, 1:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 6:59 PM
Unknown Object (File)
Sun, Mar 24, 9:59 PM
Unknown Object (File)
Sun, Mar 17, 10:32 PM
Unknown Object (File)
Mon, Mar 11, 8:03 PM
Unknown Object (File)
Wed, Mar 6, 3:59 PM
Unknown Object (File)
Mon, Mar 4, 9:10 AM
Unknown Object (File)
Sun, Mar 3, 4:25 AM
Unknown Object (File)
Feb 23 2024, 1:17 AM
Subscribers
Restricted Project

Diff Detail

Repository
rK kolab
Branch
dev/status-degraded
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 36848
Build 14654: arc lint + arc unit

Event Timeline

machniak created this revision.
machniak retitled this revision from {WIP] Degraded accounts to [WIP] Degraded accounts.Mar 8 2021, 1:35 PM
machniak retitled this revision from [WIP] Degraded accounts to Degraded accounts.Mar 10 2021, 2:53 PM
  • Fix quota/roles of a degraded user
  • Add degraded status to user:status command
  • Add degraded status to some cli commands
  • Add periodic reminder mail to degraded accounts
  • Merge branch 'master' into dev/status-degraded
  • Fix regressions regarding tenants
  • Fix more regressions
  • Small cleanup
  • Remove unintentionally recovered app/Console/Development/UserStatus.php
  • Cleanup
  • Merge branch 'master' into dev/status-degraded
  • Add some French localization
mollekopf added inline comments.
src/resources/lang/en/mail.php
28

"Thank you for your business!" / "Thank you for your consideration!" ?

39

Without the ","

42

Without ","

src/resources/lang/en/ui.php
348

Some features *have* been disabled.

349

"Please make a payment." without the ","

The changes look reasonable to me, haven't tested them though.

  • Merge branch 'master' into dev/status-degraded
  • Merge branch 'master' into dev/status-degraded
  • Hide create domain button on a degraded account

After having another look it doesn't seem like there is a good way to contain the isDegrated logic much more.

As mentioned in the comment, there may be an opportunity to rely more on UsersController::statusInfo, but it's not currently a large problem since there are few degraded checks that can be replaced by it (I still think it could be worthwhile though in the long run).

src/resources/vue/Rooms.vue
44

How about moving the isDegraded check to hasSKU instead?

Or even more centrally in UsersController::statusInfo, which seems to be where we decide who can view what.

Same goes for all the checks above, so something different than hasSKU is perhaps required:
hasCapability("identifier") or so.

  • Merge branch 'master' into dev/status-degraded
  • Merge branch 'master' into dev/status-degraded
  • Also hide Create list button in degraded mode
src/resources/vue/Rooms.vue
44

I would agree that we could do something better in statusInfo, but I don't think we have to do this here. hasSKU + isDegraded is used in one place. In other places we have to just hide some elements like Create buttons. So, it would not give us much. When we decide to do something more sophisticated with the UI we might get to that.

Diff has been rebased.

This revision is now accepted and ready to land.Dec 17 2021, 11:43 AM
  • Merge branch 'master' into dev/status-degraded
  • Hide more create buttons
  • Fix test regression
  • Fix regression
  • Cleanup
This revision was automatically updated to reflect the committed changes.