Page MenuHomePhorge

[Admin] Distribution lists UI
ClosedPublic

Authored by machniak on Apr 30 2021, 11:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 1:49 PM
Unknown Object (File)
Thu, Mar 7, 2:58 AM
Unknown Object (File)
Feb 19 2024, 3:15 AM
Unknown Object (File)
Feb 12 2024, 8:48 AM
Unknown Object (File)
Feb 9 2024, 8:31 PM
Unknown Object (File)
Feb 7 2024, 3:57 AM
Unknown Object (File)
Jan 31 2024, 11:34 AM
Unknown Object (File)
Jan 23 2024, 11:07 AM
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rKe11caabd056a: [Admin] Distribution lists UI
Summary

Add UI elements for admins and make LDAP backend to reflect group suspended state

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/groups-admin
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 34072
Build 13567: arc lint + arc unit

Event Timeline

I thought we agreed on calling this Distlists instead of Groups (to leave "groups" as a more generic term for another feature), other than that this looks ok to me.

src/routes/api.php
157

Wasn't this supposed to become distlists or so instead of groups?

This revision now requires changes to proceed.May 6 2021, 3:36 PM
machniak added inline comments.
src/routes/api.php
157

Well, It was groups before and it is internally 'groups' still. I hesitate to change everything to distlists now. It is 'distlist' in the UI, though.

So, we can change everything to 'distlist' later, but I'm not sure that was Jeroen's intention. I remember it was his decission to make it 'groups' (and I asked that it might not be the best name then) when it was implemented in the first place. It looks that he changed his mind, but I don't know if it includes internals.

One probem I see is existence of both App\Handlers\Group and App\Handlers\Distlist (see D2500) but this can be resolved by renaming the later to AllowDistlist or sth like that.

So, @vanmeeuwen should I rename everything to distlist including the DB table name? Anyway, I think this can be done after merging these diffs.

This revision was not accepted when it landed; it landed in state Needs Revision.May 7 2021, 10:57 AM
This revision was automatically updated to reflect the committed changes.