Proposed fix for the bug reported in T1784
The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>)
and therefore fails to retrieve the right properties from plugin config. This change fixes this at the right place.
Paths
| Differential D242 Authored by bruederli on Oct 30 2016, 2:54 PM.
Tags None Referenced Files
Subscribers
Details Summary Proposed fix for the bug reported in T1784 The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>)
Diff Detail
Event Timelinebruederli retitled this revision from to Fix driver initialization with config properties for the right method (T1784)
The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>)
and therefore fails to retrieve the right properties from plugin config. This.... bruederli updated this object. bruederli retitled this revision from Fix driver initialization with config properties for the right method (T1784)
The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>)
and therefore fails to retrieve the right properties from plugin config. This... to Fix driver initialization with config properties for the right method (T1784).Oct 30 2016, 2:55 PM2016-10-30 14:55:26 (UTC+1) bruederli updated this object. Comment Actions You recommended to remove the $config definition from plugins/kolab_2fa/lib/Kolab2FA/Driver/Yubikey,php, but that hunk is missing, machniak edited edge metadata. This revision is now accepted and ready to land.Nov 9 2016, 9:51 AM2016-11-09 09:51:56 (UTC+1) Closed by commit rRPKdb2d3bc800fe: Fix driver initialization with config properties for the right method (T1784) (authored by bruederli, committed by machniak). · Explain WhyNov 9 2016, 9:56 AM2016-11-09 09:56:20 (UTC+1) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 605 plugins/kolab_2fa/config.inc.php.dist
plugins/kolab_2fa/kolab_2fa.php
plugins/kolab_2fa/lib/Kolab2FA/Driver/Yubikey.php
|