Page MenuHomePhorge
Differential D2098

[MEET]: Generic implementation of Roles/Permissions
ClosedPublic
Actions

Authored by machniak on Jan 14 2021, 2:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 17, 5:05 AM
Unknown Object (File)
Mon, Jun 17, 12:10 AM
Unknown Object (File)
Sun, Jun 16, 11:39 PM
Unknown Object (File)
Sun, Jun 16, 5:24 AM
Unknown Object (File)
Sun, Jun 16, 1:16 AM
Unknown Object (File)
Thu, May 30, 7:46 AM
Unknown Object (File)
Wed, May 29, 6:56 PM
Unknown Object (File)
Sun, May 26, 2:23 AM
View All 64 Files
Subscribers
vanmeeuwen
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK768848eaa55c: [MEET]: Generic implementation of Roles/Permissions
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/openvidu-roles
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 32773
Build 12703: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Jan 14 2021, 2:04 PM
machniak created this revision.
Harbormaster completed remote builds in B32653: Diff 5782.Jan 14 2021, 2:04 PM
machniak updated this revision to Diff 5788.Jan 14 2021, 2:24 PM
  • Improve constants handling
Harbormaster completed remote builds in B32659: Diff 5788.Jan 14 2021, 2:24 PM
vanmeeuwen subscribed.Jan 15 2021, 9:50 AM
vanmeeuwen added inline comments.
src/database/migrations/2021_01_13_120000_create_openvidu_connections_table.php
32

TODO for Jeroen: examine which indexes to use.

machniak updated this revision to Diff 5830.Jan 18 2021, 9:07 AM
  • Add unique key on openvidu_connections.session_id
Harbormaster completed remote builds in B32701: Diff 5830.Jan 18 2021, 9:07 AM
machniak updated this revision to Diff 5836.Jan 18 2021, 10:15 AM
  • Fix: session_id should be indexed but not unique
Harbormaster completed remote builds in B32707: Diff 5836.Jan 18 2021, 10:15 AM
vanmeeuwen requested changes to this revision.Jan 19 2021, 10:57 AM
vanmeeuwen added inline comments.
src/database/migrations/2021_01_13_120000_create_openvidu_connections_table.php
32

there should be an additional index on ['room_id', 'session_id'] because of Room.php 364

This revision now requires changes to proceed.Jan 19 2021, 10:57 AM
machniak updated this revision to Diff 5887.Jan 19 2021, 11:26 AM
  • Improve constants handling
  • Add unique key on openvidu_connections.session_id
  • Fix: session_id should be indexed but not unique
  • Remove redundant where clause
Harbormaster completed remote builds in B32764: Diff 5887.Jan 19 2021, 11:26 AM
machniak updated this revision to Diff 5899.Jan 19 2021, 12:41 PM
  • Fix typo
Harbormaster completed remote builds in B32773: Diff 5899.Jan 19 2021, 12:41 PM
vanmeeuwen accepted this revision.Jan 19 2021, 3:29 PM
This revision is now accepted and ready to land.Jan 19 2021, 3:29 PM
Closed by commit rK768848eaa55c: [MEET]: Generic implementation of Roles/Permissions (authored by machniak). · Explain WhyJan 19 2021, 4:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Http/
Controllers/
API/
V4/
38 lines
OpenVidu/
57 lines
76 lines
database/
migrations/
46 lines
resources/
js/
meet/
28 lines
lang/
en/
3 lines
vue/
Meet/
15 lines
tests/
Feature/
Controller/
11 lines

Diff 5899

View Options

src/app/Http/Controllers/API/V4/OpenViduController.php

Loading...
View Options

src/app/OpenVidu/Connection.php

Loading...
View Options

src/app/OpenVidu/Room.php

Loading...
View Options

src/database/migrations/2021_01_13_120000_create_openvidu_connections_table.php

Loading...
View Options

src/resources/js/meet/app.js

Loading...
View Options

src/resources/lang/en/meet.php

Loading...
View Options

src/resources/vue/Meet/Room.vue

Loading...
View Options

src/tests/Feature/Controller/OpenViduTest.php

Loading...