Page MenuHomePhorge
Differential D1666

Make sure user email and domain is lowercase
ClosedPublic
Actions

Authored by machniak on Sep 30 2020, 10:17 AM.
Tags
None
Referenced Files
F12375873: D1666.id4441.diff
Tue, May 28, 9:02 AM
Unknown Object (File)
Mon, May 20, 8:41 AM
Unknown Object (File)
Wed, May 8, 7:36 PM
Unknown Object (File)
Wed, May 8, 5:22 PM
Unknown Object (File)
Wed, May 8, 10:18 AM
Unknown Object (File)
Apr 27 2024, 12:36 AM
Unknown Object (File)
Apr 24 2024, 9:06 PM
Unknown Object (File)
Apr 23 2024, 3:07 PM
View All 31 Files
Subscribers
vanmeeuwen
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK98d114517f48: Make sure user email and domain is lowercase
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/user-email-lc
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 31027
Build 11611: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Sep 30 2020, 10:17 AM
machniak created this revision.
Harbormaster completed remote builds in B31021: Diff 4423.Sep 30 2020, 10:17 AM
vanmeeuwen requested changes to this revision.Sep 30 2020, 10:20 AM
vanmeeuwen subscribed.
vanmeeuwen added inline comments.
src/database/seeds/local/UserSeeder.php
136

This won't work, we don't want role to be in $fillable.

This revision now requires changes to proceed.Sep 30 2020, 10:20 AM
machniak updated this revision to Diff 4429.Sep 30 2020, 10:24 AM
  • Revert the admin role-related change
Harbormaster completed remote builds in B31027: Diff 4429.Sep 30 2020, 10:24 AM
vanmeeuwen accepted this revision.Sep 30 2020, 10:24 AM
This revision is now accepted and ready to land.Sep 30 2020, 10:24 AM
Closed by commit rK98d114517f48: Make sure user email and domain is lowercase (authored by machniak). · Explain WhySep 30 2020, 10:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Http/
Controllers/
API/
V4/
4 lines
Observers/
2 lines
2 lines
database/
seeds/
local/
3 lines
tests/
Feature/
21 lines
95 lines

Diff 4429

View Options

src/app/Http/Controllers/API/V4/UsersController.php

Loading...
View Options

src/app/Observers/DomainObserver.php

Loading...
View Options

src/app/Observers/UserObserver.php

Loading...
View Options

src/database/seeds/local/UserSeeder.php

Loading...
View Options

src/tests/Feature/DomainTest.php

Loading...
View Options

src/tests/Feature/UserTest.php

Loading...