Page MenuHomekolab.org
Differential D1666

Make sure user email and domain is lowercase
ClosedPublic
Actions

Authored by machniak on Sep 30 2020, 10:17 AM.

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK98d114517f48: Make sure user email and domain is lowercase
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Sep 30 2020, 10:17 AM
machniak created this revision.
vanmeeuwen requested changes to this revision.Sep 30 2020, 10:20 AM
vanmeeuwen added a subscriber: vanmeeuwen.
vanmeeuwen added inline comments.
src/database/seeds/local/UserSeeder.php
136

This won't work, we don't want role to be in $fillable.

This revision now requires changes to proceed.Sep 30 2020, 10:20 AM
machniak updated this revision to Diff 4429.Sep 30 2020, 10:24 AM
  • Revert the admin role-related change
vanmeeuwen accepted this revision.Sep 30 2020, 10:24 AM
This revision is now accepted and ready to land.Sep 30 2020, 10:24 AM
Closed by commit rK98d114517f48: Make sure user email and domain is lowercase (authored by machniak). · Explain WhySep 30 2020, 10:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4441

View Options

src/app/Http/Controllers/API/V4/UsersController.php

Loading...
View Options

src/app/Observers/DomainObserver.php

Loading...
View Options

src/app/Observers/UserObserver.php

Loading...
View Options

src/database/seeds/local/UserSeeder.php

Loading...
View Options

src/tests/Feature/DomainTest.php

Loading...
View Options

src/tests/Feature/UserTest.php

Loading...